From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH 09/11] multipath tools tests/Makefile: Fix OBJDEPS for hwtable-test
Date: Tue, 12 May 2020 00:39:29 +0200 [thread overview]
Message-ID: <20200511223931.18261-10-mwilck@suse.com> (raw)
In-Reply-To: <20200511223931.18261-1-mwilck@suse.com>
From: Martin Wilck <mwilck@suse.com>
OBJDEPS needs to list object files that _call_ functions we want
to wrap, but it should _not_ list the object files where these
functions are defined; otherwise the linker might resolve these
symbols before they can be wrapped.
(Observed on i586 with gcc 9.3.1, ld 2.34.0, where wrapping
prio_getprio() doesn't work with prio.o in OBJDEPS).
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index 028c9ea7..1b8706a7 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -41,7 +41,7 @@ endif
dmevents-test_LIBDEPS = -lpthread -ldevmapper -lurcu
hwtable-test_TESTDEPS := test-lib.o
hwtable-test_OBJDEPS := ../libmultipath/discovery.o ../libmultipath/blacklist.o \
- ../libmultipath/prio.o ../libmultipath/callout.o ../libmultipath/structs.o
+ ../libmultipath/structs.o
hwtable-test_LIBDEPS := -ludev -lpthread -ldl
blacklist-test_TESTDEPS := test-log.o
blacklist-test_OBJDEPS := ../libmultipath/blacklist.o
--
2.26.2
next prev parent reply other threads:[~2020-05-11 22:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 22:39 [PATCH 00/11] Minor fixes for multipath-tools mwilck
2020-05-11 22:39 ` [PATCH 01/11] multipath-tools: Makefile: more dependency fixes for parallel build mwilck
2020-05-11 22:39 ` [PATCH 02/11] multipath-tools: Makefile.inc: separate out OPTFLAGS mwilck
2020-05-11 22:39 ` [PATCH 03/11] multipath-tools: Makefile.inc: allow user settings for LDFLAGS mwilck
2020-05-11 22:39 ` [PATCH 04/11] multipath-tools: Makefile.inc: set -Wno-error=clobbered mwilck
2020-05-11 22:39 ` [PATCH 05/11] libmultipath: discovery.c: use %z qualifier for size_t mwilck
2020-05-11 22:39 ` [PATCH 06/11] libmultipath: eliminate more signed/unsigned comparisons mwilck
2020-05-11 22:39 ` [PATCH 07/11] libmultipath: set_uint: fix parsing for 32bit mwilck
2020-05-11 22:39 ` [PATCH 08/11] multipath-tools tests/Makefile: add -lmpathcmd to LIBDEPS mwilck
2020-05-11 22:39 ` mwilck [this message]
2020-05-11 22:39 ` [PATCH 10/11] multipath-tools tests/test-lib.c: drop __wrap_is_claimed_by_foreign mwilck
2020-05-11 22:39 ` [PATCH 11/11] multipath-tools tests/directio: fix -Wmaybe-uninitalized warning mwilck
2020-05-15 1:30 ` [PATCH 00/11] Minor fixes for multipath-tools Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511223931.18261-10-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.