From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Tue, 12 May 2020 07:15:48 +0300
Subject: [PATCH 1/5 v2] efi_loader: Add headers for EDK2 StandAloneMM
 communication
In-Reply-To: <ad0a910a-cea0-c35a-12dc-2e381f377eb6@gmx.de>
References: <20200511181403.19448-1-ilias.apalodimas@linaro.org>
 <20200511181403.19448-2-ilias.apalodimas@linaro.org>
 <ad0a910a-cea0-c35a-12dc-2e381f377eb6@gmx.de>
Message-ID: <20200512041548.GA39567@apalos.home>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heinrich

On Mon, May 11, 2020 at 09:39:51PM +0200, Heinrich Schuchardt wrote:
> On 5/11/20 8:13 PM, Ilias Apalodimas wrote:
> > +

[...] 

> > +/*
> > + * Interface to the pseudo TA, which provides a communication channel with
> 
> U-Boot developers might not know the OP-TEE terms. So I would tend to
> avoid abbreviations at least in the first reference.
> 
> %s/pseudo TA/Pseudo Trusted Application/
> 
> > + * the StandaloneMM Secure Partition (StMM) running at S-EL0
> 
> What does MM stand for? Management Mode?
> 

Yes 

> > + */
> > +
> > +#define PTA_STMM_CMDID_COMMUNICATE 0
> > +
> > +			0x9c, 0xc0, 0x2d, 0x72, 0xcd, 0xd9, 0x98, 0xa7 } }

[...]

> > +
> > +#define EFI_MM_VARIABLE_GUID \
> > + *
> > + * Defined in EDK2 as SMM_VARIABLE_COMMUNICATE_GET_PAYLOAD_SIZE
> 
> %s/SMM_VARIABLE_COMMUNICATE_GET_PAYLOAD_SIZE/SMM_VARIABLE_COMMUNICATE_GET_NEXT_VARIABLE_NAME./
> 
> Too much copy and paste ;)
> 

Indeed! Thanks for cathcing those

> > + */
> > +struct smm_variable_getnext {
> > +	efi_guid_t  guid;
> > +	efi_uintn_t name_size;
> > +	u16         name[];
> > +};
> > +
> > +#define MM_VARIABLE_GET_NEXT_HEADER_SIZE \
> > +	(sizeof(struct smm_variable_getnext))
> > +
> > +/**
> > + * struct smm_variable_query_info - Used to communicate with StMM for
> > + *                                  QueryVariableInfo.
> > + *
> > + * @max_variable_storage:        max available storage
> > + * @remaining_variable_storage:  remaining available storage
> > + * @max_variable_size:           max variable supported size
> > + * @attr:                        attributes to query storage for
> > + *
> > + * Defined in EDK2 as SMM_VARIABLE_COMMUNICATE_GET_PAYLOAD_SIZE
> 
> %s/SMM_VARIABLE_COMMUNICATE_GET_PAYLOAD_SIZE/SMM_VARIABLE_COMMUNICATE_QUERY_VARIABLE_INFO./
> 
> I hope I caught all comment errors. Please, recheck.

Ok will do

> 
> Otherwise:
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> 

Thanks!
/Ilias