From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814BDC54E8B for ; Tue, 12 May 2020 06:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65C4F20746 for ; Tue, 12 May 2020 06:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728814AbgELG3J (ORCPT ); Tue, 12 May 2020 02:29:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:17012 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgELG3J (ORCPT ); Tue, 12 May 2020 02:29:09 -0400 IronPort-SDR: Fx5LTXu93RNPTLwZaqRKglOYx70HqVNTXzAHSsGlSpCGAln726/PXVEkyt0Tg6GbDl2uMVAJsz I0sR89HouAWQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 23:29:05 -0700 IronPort-SDR: /Y5kg64+S31ucd4p+4SmiR92N4ZG/BgCIhfNT4xaQeFfxwlNgLfZwi5/LlB/d7o47z4SuN7JJN W5kkDOGBmCXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,382,1583222400"; d="scan'208";a="463653475" Received: from xsang-optiplex-9020.sh.intel.com (HELO xsang-OptiPlex-9020) ([10.239.159.140]) by fmsmga006.fm.intel.com with ESMTP; 11 May 2020 23:29:02 -0700 Date: Tue, 12 May 2020 14:39:03 +0800 From: kbuild test robot To: Yongbo Zhang , broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kuninori Morimoto , Chen Li Cc: kbuild-all@lists.01.org, alsa-devel@alsa-project.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Yongbo Zhang , Kuninori Morimoto Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Message-ID: <20200512063903.GB20612@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yongbo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v5.7-rc4 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Yongbo-Zhang/ASoC-rsnd-add-interrupt-support-for-SSI-BUSIF-buffer/20200509-035713 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot cppcheck warnings: (new ones prefixed by >>) >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: ''. [syntaxError] { ^ >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: 'DEBUG'. [syntaxError] { ^ # https://github.com/0day-ci/linux/commit/391d452251464b78f72ba3a1fd9b6091b3d4a942 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 391d452251464b78f72ba3a1fd9b6091b3d4a942 vim +531 sound/soc/sh/rcar/ssi.c ae5c322303fff5 Kuninori Morimoto 2013-07-21 527 ae5c322303fff5 Kuninori Morimoto 2013-07-21 528 static int rsnd_ssi_quit(struct rsnd_mod *mod, 2c0fac19de2cd7 Kuninori Morimoto 2015-06-15 529 struct rsnd_dai_stream *io, 690602fcd85385 Kuninori Morimoto 2015-01-15 530 struct rsnd_priv *priv) ae5c322303fff5 Kuninori Morimoto 2013-07-21 @531 { ae5c322303fff5 Kuninori Morimoto 2013-07-21 532 struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod); ae5c322303fff5 Kuninori Morimoto 2013-07-21 533 struct device *dev = rsnd_priv_to_dev(priv); 391d452251464b Yongbo Zhang 2020-05-08 534 int is_tdm, is_tdm_split; 391d452251464b Yongbo Zhang 2020-05-08 535 int id = rsnd_mod_id(mod); 391d452251464b Yongbo Zhang 2020-05-08 536 int i; 391d452251464b Yongbo Zhang 2020-05-08 537 u32 sys_int_enable = 0; 391d452251464b Yongbo Zhang 2020-05-08 538 391d452251464b Yongbo Zhang 2020-05-08 539 is_tdm = rsnd_runtime_is_tdm(io); 391d452251464b Yongbo Zhang 2020-05-08 540 is_tdm_split = rsnd_runtime_is_tdm_split(io); ae5c322303fff5 Kuninori Morimoto 2013-07-21 541 fd9adcfdc1434f Kuninori Morimoto 2016-02-18 542 if (!rsnd_ssi_is_run_mods(mod, io)) fd9adcfdc1434f Kuninori Morimoto 2016-02-18 543 return 0; fd9adcfdc1434f Kuninori Morimoto 2016-02-18 544 e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 545 if (!ssi->usrcnt) { c0ea089dbad47a Kuninori Morimoto 2018-10-30 546 dev_err(dev, "%s usrcnt error\n", rsnd_mod_name(mod)); e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 547 return -EIO; e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 548 } e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 549 26d34b11af6a34 Kuninori Morimoto 2016-02-18 550 rsnd_ssi_master_clk_stop(mod, io); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 551 e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 552 rsnd_mod_power_off(mod); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 553 e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 554 ssi->usrcnt--; e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 555 203cdf51f28820 Kuninori Morimoto 2018-06-12 556 if (!ssi->usrcnt) { 203cdf51f28820 Kuninori Morimoto 2018-06-12 557 ssi->cr_own = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 558 ssi->cr_mode = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 559 ssi->wsr = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 560 } 203cdf51f28820 Kuninori Morimoto 2018-06-12 561 391d452251464b Yongbo Zhang 2020-05-08 562 /* disable busif buffer over/under run interrupt. */ 391d452251464b Yongbo Zhang 2020-05-08 563 if (is_tdm || is_tdm_split) { 391d452251464b Yongbo Zhang 2020-05-08 564 switch (id) { 391d452251464b Yongbo Zhang 2020-05-08 565 case 0: 391d452251464b Yongbo Zhang 2020-05-08 566 case 1: 391d452251464b Yongbo Zhang 2020-05-08 567 case 2: 391d452251464b Yongbo Zhang 2020-05-08 568 case 3: 391d452251464b Yongbo Zhang 2020-05-08 569 case 4: 391d452251464b Yongbo Zhang 2020-05-08 570 for (i = 0; i < 4; i++) { 391d452251464b Yongbo Zhang 2020-05-08 571 sys_int_enable = rsnd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 572 SSI_SYS_INT_ENABLE(i * 2)); 391d452251464b Yongbo Zhang 2020-05-08 573 sys_int_enable &= ~(0xf << (id * 4)); 391d452251464b Yongbo Zhang 2020-05-08 574 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 575 SSI_SYS_INT_ENABLE(i * 2), 391d452251464b Yongbo Zhang 2020-05-08 576 sys_int_enable); 391d452251464b Yongbo Zhang 2020-05-08 577 } 391d452251464b Yongbo Zhang 2020-05-08 578 391d452251464b Yongbo Zhang 2020-05-08 579 break; 391d452251464b Yongbo Zhang 2020-05-08 580 case 9: 391d452251464b Yongbo Zhang 2020-05-08 581 for (i = 0; i < 4; i++) { 391d452251464b Yongbo Zhang 2020-05-08 582 sys_int_enable = rsnd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 583 SSI_SYS_INT_ENABLE((i * 2) + 1)); 391d452251464b Yongbo Zhang 2020-05-08 584 sys_int_enable &= ~(0xf << 4); 391d452251464b Yongbo Zhang 2020-05-08 585 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 586 SSI_SYS_INT_ENABLE((i * 2) + 1), 391d452251464b Yongbo Zhang 2020-05-08 587 sys_int_enable); 391d452251464b Yongbo Zhang 2020-05-08 588 } 391d452251464b Yongbo Zhang 2020-05-08 589 391d452251464b Yongbo Zhang 2020-05-08 590 break; 391d452251464b Yongbo Zhang 2020-05-08 591 } 391d452251464b Yongbo Zhang 2020-05-08 592 ae5c322303fff5 Kuninori Morimoto 2013-07-21 593 return 0; ae5c322303fff5 Kuninori Morimoto 2013-07-21 594 } ae5c322303fff5 Kuninori Morimoto 2013-07-21 595 :::::: The code at line 531 was first introduced by commit :::::: ae5c322303fff50b93d60e34c6563f1264a5941b ASoC: add Renesas R-Car SSI feature :::::: TO: Kuninori Morimoto :::::: CC: Mark Brown --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E766DC54E4B for ; Tue, 12 May 2020 06:30:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70F2B20714 for ; Tue, 12 May 2020 06:30:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j/VplIpQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70F2B20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB5E01607; Tue, 12 May 2020 08:29:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB5E01607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589265012; bh=BqNx/dQTl7ln0zglCVgEECnUeAHUY675G9o5yc8RsEo=; h=Date:From:To:Subject:In-Reply-To:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=j/VplIpQqJfjboVxB7+mzFS499b5Sx4oI5wpTtboG+NGyiX5NBgK6n2IeAlBQ3Uy+ VP9meS9L4yU2GnpRdy6Klqn/OcA6E8GVWAKtfcGaK5MHDI0Z3BQ7bozx7QTY10hBTR leCezzHxw8llJ13Us1Gh6up+Li/+31UH7ZMC4L2U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48BCDF800AA; Tue, 12 May 2020 08:29:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BEA2EF8014C; Tue, 12 May 2020 08:29:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5F8B2F800E3 for ; Tue, 12 May 2020 08:29:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5F8B2F800E3 IronPort-SDR: JJBLxjU+lRNbh6d2476FaWO7U2wWX8YFCZB3TDszyHIlKkMKMuW9tuM7H99O/sL4LxHt/QMpLZ 0BF5IOZChrjg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 23:29:05 -0700 IronPort-SDR: /Y5kg64+S31ucd4p+4SmiR92N4ZG/BgCIhfNT4xaQeFfxwlNgLfZwi5/LlB/d7o47z4SuN7JJN W5kkDOGBmCXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,382,1583222400"; d="scan'208";a="463653475" Received: from xsang-optiplex-9020.sh.intel.com (HELO xsang-OptiPlex-9020) ([10.239.159.140]) by fmsmga006.fm.intel.com with ESMTP; 11 May 2020 23:29:02 -0700 Date: Tue, 12 May 2020 14:39:03 +0800 From: kbuild test robot To: Yongbo Zhang , broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kuninori Morimoto , Chen Li Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Message-ID: <20200512063903.GB20612@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, kbuild-all@lists.01.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yongbo Zhang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Yongbo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v5.7-rc4 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Yongbo-Zhang/ASoC-rsnd-add-interrupt-support-for-SSI-BUSIF-buffer/20200509-035713 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot cppcheck warnings: (new ones prefixed by >>) >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: ''. [syntaxError] { ^ >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: 'DEBUG'. [syntaxError] { ^ # https://github.com/0day-ci/linux/commit/391d452251464b78f72ba3a1fd9b6091b3d4a942 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 391d452251464b78f72ba3a1fd9b6091b3d4a942 vim +531 sound/soc/sh/rcar/ssi.c ae5c322303fff5 Kuninori Morimoto 2013-07-21 527 ae5c322303fff5 Kuninori Morimoto 2013-07-21 528 static int rsnd_ssi_quit(struct rsnd_mod *mod, 2c0fac19de2cd7 Kuninori Morimoto 2015-06-15 529 struct rsnd_dai_stream *io, 690602fcd85385 Kuninori Morimoto 2015-01-15 530 struct rsnd_priv *priv) ae5c322303fff5 Kuninori Morimoto 2013-07-21 @531 { ae5c322303fff5 Kuninori Morimoto 2013-07-21 532 struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod); ae5c322303fff5 Kuninori Morimoto 2013-07-21 533 struct device *dev = rsnd_priv_to_dev(priv); 391d452251464b Yongbo Zhang 2020-05-08 534 int is_tdm, is_tdm_split; 391d452251464b Yongbo Zhang 2020-05-08 535 int id = rsnd_mod_id(mod); 391d452251464b Yongbo Zhang 2020-05-08 536 int i; 391d452251464b Yongbo Zhang 2020-05-08 537 u32 sys_int_enable = 0; 391d452251464b Yongbo Zhang 2020-05-08 538 391d452251464b Yongbo Zhang 2020-05-08 539 is_tdm = rsnd_runtime_is_tdm(io); 391d452251464b Yongbo Zhang 2020-05-08 540 is_tdm_split = rsnd_runtime_is_tdm_split(io); ae5c322303fff5 Kuninori Morimoto 2013-07-21 541 fd9adcfdc1434f Kuninori Morimoto 2016-02-18 542 if (!rsnd_ssi_is_run_mods(mod, io)) fd9adcfdc1434f Kuninori Morimoto 2016-02-18 543 return 0; fd9adcfdc1434f Kuninori Morimoto 2016-02-18 544 e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 545 if (!ssi->usrcnt) { c0ea089dbad47a Kuninori Morimoto 2018-10-30 546 dev_err(dev, "%s usrcnt error\n", rsnd_mod_name(mod)); e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 547 return -EIO; e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 548 } e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 549 26d34b11af6a34 Kuninori Morimoto 2016-02-18 550 rsnd_ssi_master_clk_stop(mod, io); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 551 e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 552 rsnd_mod_power_off(mod); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 553 e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 554 ssi->usrcnt--; e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 555 203cdf51f28820 Kuninori Morimoto 2018-06-12 556 if (!ssi->usrcnt) { 203cdf51f28820 Kuninori Morimoto 2018-06-12 557 ssi->cr_own = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 558 ssi->cr_mode = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 559 ssi->wsr = 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 560 } 203cdf51f28820 Kuninori Morimoto 2018-06-12 561 391d452251464b Yongbo Zhang 2020-05-08 562 /* disable busif buffer over/under run interrupt. */ 391d452251464b Yongbo Zhang 2020-05-08 563 if (is_tdm || is_tdm_split) { 391d452251464b Yongbo Zhang 2020-05-08 564 switch (id) { 391d452251464b Yongbo Zhang 2020-05-08 565 case 0: 391d452251464b Yongbo Zhang 2020-05-08 566 case 1: 391d452251464b Yongbo Zhang 2020-05-08 567 case 2: 391d452251464b Yongbo Zhang 2020-05-08 568 case 3: 391d452251464b Yongbo Zhang 2020-05-08 569 case 4: 391d452251464b Yongbo Zhang 2020-05-08 570 for (i = 0; i < 4; i++) { 391d452251464b Yongbo Zhang 2020-05-08 571 sys_int_enable = rsnd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 572 SSI_SYS_INT_ENABLE(i * 2)); 391d452251464b Yongbo Zhang 2020-05-08 573 sys_int_enable &= ~(0xf << (id * 4)); 391d452251464b Yongbo Zhang 2020-05-08 574 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 575 SSI_SYS_INT_ENABLE(i * 2), 391d452251464b Yongbo Zhang 2020-05-08 576 sys_int_enable); 391d452251464b Yongbo Zhang 2020-05-08 577 } 391d452251464b Yongbo Zhang 2020-05-08 578 391d452251464b Yongbo Zhang 2020-05-08 579 break; 391d452251464b Yongbo Zhang 2020-05-08 580 case 9: 391d452251464b Yongbo Zhang 2020-05-08 581 for (i = 0; i < 4; i++) { 391d452251464b Yongbo Zhang 2020-05-08 582 sys_int_enable = rsnd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 583 SSI_SYS_INT_ENABLE((i * 2) + 1)); 391d452251464b Yongbo Zhang 2020-05-08 584 sys_int_enable &= ~(0xf << 4); 391d452251464b Yongbo Zhang 2020-05-08 585 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 586 SSI_SYS_INT_ENABLE((i * 2) + 1), 391d452251464b Yongbo Zhang 2020-05-08 587 sys_int_enable); 391d452251464b Yongbo Zhang 2020-05-08 588 } 391d452251464b Yongbo Zhang 2020-05-08 589 391d452251464b Yongbo Zhang 2020-05-08 590 break; 391d452251464b Yongbo Zhang 2020-05-08 591 } 391d452251464b Yongbo Zhang 2020-05-08 592 ae5c322303fff5 Kuninori Morimoto 2013-07-21 593 return 0; ae5c322303fff5 Kuninori Morimoto 2013-07-21 594 } ae5c322303fff5 Kuninori Morimoto 2013-07-21 595 :::::: The code at line 531 was first introduced by commit :::::: ae5c322303fff50b93d60e34c6563f1264a5941b ASoC: add Renesas R-Car SSI feature :::::: TO: Kuninori Morimoto :::::: CC: Mark Brown --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2968277211178743710==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Date: Tue, 12 May 2020 14:39:03 +0800 Message-ID: <20200512063903.GB20612@xsang-OptiPlex-9020> In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com> List-Id: --===============2968277211178743710== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Yongbo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v5.7-rc4 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Yongbo-Zhang/ASoC-rsnd-add= -interrupt-support-for-SSI-BUSIF-buffer/20200509-035713 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git f= or-next :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot cppcheck warnings: (new ones prefixed by >>) >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: ''= . [syntaxError] { ^ >> sound/soc/sh/rcar/ssi.c:531:1: warning: Unmatched '{'. Configuration: 'D= EBUG'. [syntaxError] { ^ # https://github.com/0day-ci/linux/commit/391d452251464b78f72ba3a1fd9b6091b= 3d4a942 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 391d452251464b78f72ba3a1fd9b6091b3d4a942 vim +531 sound/soc/sh/rcar/ssi.c ae5c322303fff5 Kuninori Morimoto 2013-07-21 527 = ae5c322303fff5 Kuninori Morimoto 2013-07-21 528 static int rsnd_ssi_quit(= struct rsnd_mod *mod, 2c0fac19de2cd7 Kuninori Morimoto 2015-06-15 529 struct rsnd_dai_strea= m *io, 690602fcd85385 Kuninori Morimoto 2015-01-15 530 struct rsnd_priv *pri= v) ae5c322303fff5 Kuninori Morimoto 2013-07-21 @531 { ae5c322303fff5 Kuninori Morimoto 2013-07-21 532 struct rsnd_ssi *ssi =3D= rsnd_mod_to_ssi(mod); ae5c322303fff5 Kuninori Morimoto 2013-07-21 533 struct device *dev =3D r= snd_priv_to_dev(priv); 391d452251464b Yongbo Zhang 2020-05-08 534 int is_tdm, is_tdm_split; 391d452251464b Yongbo Zhang 2020-05-08 535 int id =3D rsnd_mod_id(m= od); 391d452251464b Yongbo Zhang 2020-05-08 536 int i; 391d452251464b Yongbo Zhang 2020-05-08 537 u32 sys_int_enable =3D 0; 391d452251464b Yongbo Zhang 2020-05-08 538 = 391d452251464b Yongbo Zhang 2020-05-08 539 is_tdm =3D rsnd_runtime= _is_tdm(io); 391d452251464b Yongbo Zhang 2020-05-08 540 is_tdm_split =3D rsnd_ru= ntime_is_tdm_split(io); ae5c322303fff5 Kuninori Morimoto 2013-07-21 541 = fd9adcfdc1434f Kuninori Morimoto 2016-02-18 542 if (!rsnd_ssi_is_run_mod= s(mod, io)) fd9adcfdc1434f Kuninori Morimoto 2016-02-18 543 return 0; fd9adcfdc1434f Kuninori Morimoto 2016-02-18 544 = e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 545 if (!ssi->usrcnt) { c0ea089dbad47a Kuninori Morimoto 2018-10-30 546 dev_err(dev, "%s usrcnt= error\n", rsnd_mod_name(mod)); e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 547 return -EIO; e5d9cfc6f5fe56 Andrzej Hajda 2015-12-24 548 } e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 549 = 26d34b11af6a34 Kuninori Morimoto 2016-02-18 550 rsnd_ssi_master_clk_stop= (mod, io); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 551 = e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 552 rsnd_mod_power_off(mod); e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 553 = e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 554 ssi->usrcnt--; e7d850dd10f4e6 Kuninori Morimoto 2015-10-26 555 = 203cdf51f28820 Kuninori Morimoto 2018-06-12 556 if (!ssi->usrcnt) { 203cdf51f28820 Kuninori Morimoto 2018-06-12 557 ssi->cr_own =3D 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 558 ssi->cr_mode =3D 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 559 ssi->wsr =3D 0; 203cdf51f28820 Kuninori Morimoto 2018-06-12 560 } 203cdf51f28820 Kuninori Morimoto 2018-06-12 561 = 391d452251464b Yongbo Zhang 2020-05-08 562 /* disable busif buffer = over/under run interrupt. */ 391d452251464b Yongbo Zhang 2020-05-08 563 if (is_tdm || is_tdm_spl= it) { 391d452251464b Yongbo Zhang 2020-05-08 564 switch (id) { 391d452251464b Yongbo Zhang 2020-05-08 565 case 0: 391d452251464b Yongbo Zhang 2020-05-08 566 case 1: 391d452251464b Yongbo Zhang 2020-05-08 567 case 2: 391d452251464b Yongbo Zhang 2020-05-08 568 case 3: 391d452251464b Yongbo Zhang 2020-05-08 569 case 4: 391d452251464b Yongbo Zhang 2020-05-08 570 for (i =3D 0; i < 4; i= ++) { 391d452251464b Yongbo Zhang 2020-05-08 571 sys_int_enable =3D rs= nd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 572 SSI_SYS_INT_ENABLE(= i * 2)); 391d452251464b Yongbo Zhang 2020-05-08 573 sys_int_enable &=3D ~= (0xf << (id * 4)); 391d452251464b Yongbo Zhang 2020-05-08 574 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 575 SSI_SYS_INT_E= NABLE(i * 2), 391d452251464b Yongbo Zhang 2020-05-08 576 sys_int_enabl= e); 391d452251464b Yongbo Zhang 2020-05-08 577 } 391d452251464b Yongbo Zhang 2020-05-08 578 = 391d452251464b Yongbo Zhang 2020-05-08 579 break; 391d452251464b Yongbo Zhang 2020-05-08 580 case 9: 391d452251464b Yongbo Zhang 2020-05-08 581 for (i =3D 0; i < 4; i= ++) { 391d452251464b Yongbo Zhang 2020-05-08 582 sys_int_enable =3D rs= nd_mod_read(mod, 391d452251464b Yongbo Zhang 2020-05-08 583 SSI_SYS_INT_ENABLE((= i * 2) + 1)); 391d452251464b Yongbo Zhang 2020-05-08 584 sys_int_enable &=3D ~= (0xf << 4); 391d452251464b Yongbo Zhang 2020-05-08 585 rsnd_mod_write(mod, 391d452251464b Yongbo Zhang 2020-05-08 586 SSI_SYS_INT_E= NABLE((i * 2) + 1), 391d452251464b Yongbo Zhang 2020-05-08 587 sys_int_enabl= e); 391d452251464b Yongbo Zhang 2020-05-08 588 } 391d452251464b Yongbo Zhang 2020-05-08 589 = 391d452251464b Yongbo Zhang 2020-05-08 590 break; 391d452251464b Yongbo Zhang 2020-05-08 591 } 391d452251464b Yongbo Zhang 2020-05-08 592 = ae5c322303fff5 Kuninori Morimoto 2013-07-21 593 return 0; ae5c322303fff5 Kuninori Morimoto 2013-07-21 594 } ae5c322303fff5 Kuninori Morimoto 2013-07-21 595 = :::::: The code@line 531 was first introduced by commit :::::: ae5c322303fff50b93d60e34c6563f1264a5941b ASoC: add Renesas R-Car SSI= feature :::::: TO: Kuninori Morimoto :::::: CC: Mark Brown --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2968277211178743710==--