From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64857C54E8F for ; Tue, 12 May 2020 08:08:27 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36326206D6 for ; Tue, 12 May 2020 08:08:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36326206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7D8A411A6261C; Tue, 12 May 2020 01:05:57 -0700 (PDT) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver= Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 192D311A618C9 for ; Tue, 12 May 2020 01:05:55 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 1BC1368BEB; Tue, 12 May 2020 10:08:21 +0200 (CEST) Date: Tue, 12 May 2020 10:08:20 +0200 From: Christoph Hellwig To: Dan Williams Subject: Re: remove a few uses of ->queuedata Message-ID: <20200512080820.GA2336@lst.de> References: <20200508161517.252308-1-hch@lst.de> <20200509082352.GB21834@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Message-ID-Hash: GF756KC5FK7VVEOEJJH7RZWWRAHMFFO5 X-Message-ID-Hash: GF756KC5FK7VVEOEJJH7RZWWRAHMFFO5 X-MailFrom: hch@lst.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Christoph Hellwig , Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k@lists.linux-m68k.org, Linux Kernel Mailing List , linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > which are all used in the I/O submission path (generic_make_request / > > generic_make_request_checks). This is mostly a prep cleanup patch to > > also remove the pointless queue argument from ->make_request - then > > ->queue is an extra dereference and extra churn. > > Ah ok. If the changelogs had been filled in with something like "In > preparation for removing @q from make_request_fn, stop using > ->queuedata", I probably wouldn't have looked twice. > > For the nvdimm/ driver updates you can add: > > Reviewed-by: Dan Williams > > ...or just let me know if you want me to pick those up through the nvdimm tree. I'd love you to pick them up through the nvdimm tree. Do you want to fix up the commit message yourself? _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: remove a few uses of ->queuedata Date: Tue, 12 May 2020 10:08:20 +0200 Message-ID: <20200512080820.GA2336@lst.de> References: <20200508161517.252308-1-hch@lst.de> <20200509082352.GB21834@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dan Williams Cc: Christoph Hellwig , Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k@lists.linux-m68k.org, Linux Kernel Mailing List , linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid , linux-nvdimm List-Id: linux-raid.ids On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > which are all used in the I/O submission path (generic_make_request / > > generic_make_request_checks). This is mostly a prep cleanup patch to > > also remove the pointless queue argument from ->make_request - then > > ->queue is an extra dereference and extra churn. > > Ah ok. If the changelogs had been filled in with something like "In > preparation for removing @q from make_request_fn, stop using > ->queuedata", I probably wouldn't have looked twice. > > For the nvdimm/ driver updates you can add: > > Reviewed-by: Dan Williams > > ...or just let me know if you want me to pick those up through the nvdimm tree. I'd love you to pick them up through the nvdimm tree. Do you want to fix up the commit message yourself? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C8AC54E4B for ; Tue, 12 May 2020 08:10:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8FAC2078E for ; Tue, 12 May 2020 08:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8FAC2078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Lr835321zDqlS for ; Tue, 12 May 2020 18:10:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Lr662bnrzDqlQ for ; Tue, 12 May 2020 18:08:28 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 1BC1368BEB; Tue, 12 May 2020 10:08:21 +0200 (CEST) Date: Tue, 12 May 2020 10:08:20 +0200 From: Christoph Hellwig To: Dan Williams Subject: Re: remove a few uses of ->queuedata Message-ID: <20200512080820.GA2336@lst.de> References: <20200508161517.252308-1-hch@lst.de> <20200509082352.GB21834@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-xtensa@linux-xtensa.org, linux-raid , Sergey Senozhatsky , linux-nvdimm , Geoff Levand , Linux Kernel Mailing List , Jim Paris , Joshua Morris , linux-block@vger.kernel.org, Minchan Kim , linux-m68k@lists.linux-m68k.org, Philip Kelleher , linux-bcache@vger.kernel.org, linuxppc-dev , Christoph Hellwig , Nitin Gupta , drbd-dev@lists.linbit.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > which are all used in the I/O submission path (generic_make_request / > > generic_make_request_checks). This is mostly a prep cleanup patch to > > also remove the pointless queue argument from ->make_request - then > > ->queue is an extra dereference and extra churn. > > Ah ok. If the changelogs had been filled in with something like "In > preparation for removing @q from make_request_fn, stop using > ->queuedata", I probably wouldn't have looked twice. > > For the nvdimm/ driver updates you can add: > > Reviewed-by: Dan Williams > > ...or just let me know if you want me to pick those up through the nvdimm tree. I'd love you to pick them up through the nvdimm tree. Do you want to fix up the commit message yourself?