From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: [for-linus][PATCH 1/3] tools/bootconfig: Fix apply_xbc() to return zero on success
Date: Tue, 12 May 2020 09:23:18 -0400 [thread overview]
Message-ID: <20200512132347.742114772@goodmis.org> (raw)
In-Reply-To: 20200512132317.343672858@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The return of apply_xbc() returns the result of the last write() call, which
is not what is expected. It should only return zero on success.
Link: https://lore.kernel.org/r/20200508093059.GF9365@kadam
Fixes: 8842604446d1 ("tools/bootconfig: Fix resource leak in apply_xbc()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tools/bootconfig/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
index 001076c51712..0efaf45f7367 100644
--- a/tools/bootconfig/main.c
+++ b/tools/bootconfig/main.c
@@ -337,6 +337,7 @@ int apply_xbc(const char *path, const char *xbc_path)
pr_err("Failed to apply a boot config magic: %d\n", ret);
goto out;
}
+ ret = 0;
out:
close(fd);
free(data);
--
2.26.2
next prev parent reply other threads:[~2020-05-12 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:23 [for-linus][PATCH 0/3] tracing: More fixes for 5.7 Steven Rostedt
2020-05-12 13:23 ` Steven Rostedt [this message]
2020-05-12 13:23 ` [for-linus][PATCH 2/3] tracing: Wait for preempt irq delay thread to execute Steven Rostedt
2020-05-12 13:23 ` [for-linus][PATCH 3/3] bootconfig: Fix to prevent warning message if no bootconfig option Steven Rostedt
2020-05-12 14:40 ` Paul Menzel
[not found] ` <0686d98b-5eba-b761-6d84-f93edfbbb5a6@molgen.mpg.de>
2020-05-12 14:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512132347.742114772@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.