All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Sandipan Das <sandipan@linux.ibm.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	leo.yan@linaro.org, jolsa@kernel.org,
	naveen.n.rao@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
Date: Tue, 12 May 2020 10:27:37 -0300	[thread overview]
Message-ID: <20200512132737.GH28888@kernel.org> (raw)
In-Reply-To: <88066ce0-f586-b88d-75b5-2706684818d7@linux.ibm.com>

Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
> 
> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > removed powerpc specific sym-handling.c file from Build. This wasn't
> > caught by build CI because all functions in this file are declared
> > as __weak in common code. Fix it.
> > 
> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > Reported-by: Sandipan Das <sandipan@linux.ibm.com>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> > ---
> >  tools/perf/arch/powerpc/util/Build | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> > index e5c9504f8586..e86e210bf514 100644
> > --- a/tools/perf/arch/powerpc/util/Build
> > +++ b/tools/perf/arch/powerpc/util/Build
> > @@ -2,6 +2,7 @@ perf-y += header.o
> >  perf-y += kvm-stat.o
> >  perf-y += perf_regs.o
> >  perf-y += mem-events.o
> > +perf-y += sym-handling.o
> >  
> >  perf-$(CONFIG_DWARF) += dwarf-regs.o
> >  perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> > 
> 
> Thanks for fixing this!
> 
> Acked-by: Sandipan Das <sandipan@linux.ibm.com>

Leo, Naveen, can you comment on this?

- Arnaldo

  reply	other threads:[~2020-05-12 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 11:21 [PATCH] perf powerpc: Don't ignore sym-handling.c file Ravi Bangoria
2020-05-11 18:15 ` Sandipan Das
2020-05-12 13:27   ` Arnaldo Carvalho de Melo [this message]
2020-05-13 14:16     ` Naveen N. Rao
2020-05-12 13:59 ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512132737.GH28888@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=sandipan@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.