[PATCH v1 0/1] target/microblaze: Fix mfs from EDR

[PATCH v1 0/1] target/microblaze: Fix mfs from EDR

[Edgar E. Iglesias]

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

We're missing mfs from EDR support, this adds it.
Showed up in Xilinx Versal PLM code.

Cheers,
Edgar

Tong Ho (1):
  target/microblaze: Add MFS Rd,EDR translation

 target/microblaze/translate.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

[PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation

[Edgar E. Iglesias]

From: Tong Ho <tong.ho@xilinx.com>

This is to fix cpu-abort with 'qemu: fatal: unknown mfs reg d'
(in the default case) when microblaze guest issues 'MFS Rd,EDR'
instruction.

Since embeddedsw release 2019.2, XPlm_ExceptionHandler() issues
the instruction on exception, and microblaze model aborts when
PLM firmware guest encounters an exception.

Signed-off-by: Tong Ho <tong.ho@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target/microblaze/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 20b7427811..92b3630804 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -581,6 +581,7 @@ static void dec_msr(DisasContext *dc)
             case SR_ESR:
             case SR_FSR:
             case SR_BTR:
+            case SR_EDR:
                 tcg_gen_extrl_i64_i32(cpu_R[dc->rd], cpu_SR[sr]);
                 break;
             case 0x800:
-- 
2.20.1

Re: [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation

[Luc Michel]

On 5/12/20 4:36 PM, Edgar E. Iglesias wrote:
> From: Tong Ho <tong.ho@xilinx.com>
> 
> This is to fix cpu-abort with 'qemu: fatal: unknown mfs reg d'
> (in the default case) when microblaze guest issues 'MFS Rd,EDR'
> instruction.
> 
> Since embeddedsw release 2019.2, XPlm_ExceptionHandler() issues
> the instruction on exception, and microblaze model aborts when
> PLM firmware guest encounters an exception.
> 
> Signed-off-by: Tong Ho <tong.ho@xilinx.com>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Reviewed-by: Luc Michel <luc.michel@greensocs.com>

> ---
>  target/microblaze/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 20b7427811..92b3630804 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -581,6 +581,7 @@ static void dec_msr(DisasContext *dc)
>              case SR_ESR:
>              case SR_FSR:
>              case SR_BTR:
> +            case SR_EDR:
>                  tcg_gen_extrl_i64_i32(cpu_R[dc->rd], cpu_SR[sr]);
>                  break;
>              case 0x800:
>