From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DDDC54E8D for ; Tue, 12 May 2020 15:32:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 643B2206B8 for ; Tue, 12 May 2020 15:32:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 643B2206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CCBEE6E122; Tue, 12 May 2020 15:32:43 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8582F6E926 for ; Tue, 12 May 2020 15:32:42 +0000 (UTC) IronPort-SDR: UJ2fIgxDQxWOWuGozz7ut19ESXeOTeQPmSPzL3DhKxAJuc4XbAqH22HTTa4dS4oFfZp1dqM/Ue YmbiEsqU3BuQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 08:32:42 -0700 IronPort-SDR: FTR7SQmaQyb+jmPOSpNsZ6qEc9c7UiVznWWU7ppZkPYY9c92sw7V0qsCrDHtZx2aC0KuxT/6H4 P7x9dP8hUKug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,384,1583222400"; d="scan'208";a="250931843" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 12 May 2020 08:32:39 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 12 May 2020 18:32:38 +0300 Date: Tue, 12 May 2020 18:32:38 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Lisovskiy, Stanislav" Message-ID: <20200512153238.GW6112@intel.com> References: <20200507144503.15506-1-stanislav.lisovskiy@intel.com> <20200507144503.15506-4-stanislav.lisovskiy@intel.com> <20200512113925.GM6112@intel.com> <20200512124406.GA19632@intel.com> <20200512131433.GR6112@intel.com> <20200512132644.GA19773@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200512132644.GA19773@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v28 3/6] drm/i915: Make active_pipes check skl specific X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, May 12, 2020 at 04:26:53PM +0300, Lisovskiy, Stanislav wrote: > On Tue, May 12, 2020 at 04:14:33PM +0300, Ville Syrj=E4l=E4 wrote: > > On Tue, May 12, 2020 at 03:44:06PM +0300, Lisovskiy, Stanislav wrote: > > > On Tue, May 12, 2020 at 02:39:25PM +0300, Ville Syrj=E4l=E4 wrote: > > > > On Thu, May 07, 2020 at 05:45:00PM +0300, Stanislav Lisovskiy wrote: > > > > > Seems that only skl needs to have SAGV turned off > > > > > for multipipe scenarios, so lets do it this way. > > > > = > > > > It doesn't afaics. It's just someone added the check for some random > > > > reason. So this should be reworded a bit. Also this isn't just about > > > > skl/derivatives but all pre-icl so the is a bit misleadin= g too. > > > = > > > This is in BSpec anyway. And it was in the code before, so I really = > > > don't get what do you mean here. > > > = > > > > = > > > > > = > > > > > If anything blows up - we can always revert this patch. > > > > > = > > > > > Signed-off-by: Stanislav Lisovskiy > > > > > --- > > > > > drivers/gpu/drm/i915/intel_pm.c | 15 +++++++++------ > > > > > drivers/gpu/drm/i915/intel_pm.h | 3 ++- > > > > > 2 files changed, 11 insertions(+), 7 deletions(-) > > > > > = > > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i9= 15/intel_pm.c > > > > > index 3dc1ad66beb3..db188efee21e 100644 > > > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > > > @@ -3777,7 +3777,7 @@ void intel_sagv_pre_plane_update(struct int= el_atomic_state *state) > > > > > if (!new_bw_state) > > > > > return; > > > > > = > > > > > - if (!intel_can_enable_sagv(new_bw_state)) > > > > > + if (!intel_can_enable_sagv(dev_priv, new_bw_state)) > > > > > intel_disable_sagv(dev_priv); > > > > > } > > > > > = > > > > > @@ -3800,7 +3800,7 @@ void intel_sagv_post_plane_update(struct in= tel_atomic_state *state) > > > > > if (!new_bw_state) > > > > > return; > > > > > = > > > > > - if (intel_can_enable_sagv(new_bw_state)) > > > > > + if (intel_can_enable_sagv(dev_priv, new_bw_state)) > > > > > intel_enable_sagv(dev_priv); > > > > > } > > > > > = > > > > > @@ -3853,16 +3853,19 @@ static bool skl_crtc_can_enable_sagv(cons= t struct intel_crtc_state *crtc_state) > > > > > return true; > > > > > } > > > > > = > > > > > -bool intel_can_enable_sagv(const struct intel_bw_state *bw_state) > > > > > +bool intel_can_enable_sagv(struct drm_i915_private *dev_priv, > > > > > + const struct intel_bw_state *bw_state) > > > > > { > > > > > - if (bw_state->active_pipes && !is_power_of_2(bw_state->active_p= ipes)) > > > > > - return false; > > > > > + if (INTEL_GEN(dev_priv) < 11) > > > > > + if (bw_state->active_pipes && !is_power_of_2(bw_state->active_= pipes)) > > > > = > > > > If (a && b && c) > > > > return false; > > > = > > > Then the line would get too long, and it does exactly same thing. > > > I really don't understand such comments. > > = > > if (a && b && > > c) > > = > > if (a && > > b && c) > > = > > if (a && > > b && > > c) > > = > > there are plenty of options. The point is nested ifs like this > > only serve to indent code needlessly deep. > = > and ifs like if (long condition1 && long condition2 && ...) make = > unnecessary "wide". = > = > I would understand of course if I would do something like > 3-4 nested ifs sure, however that one seems to be completely similar. > = > I don't even get why = > = > if (a && > b && c) "if a and b and c then do stuff" > = > reads better than > = > if (a) > if(b && c) "if a then if b and c then do stuff" The first one definitely sounds better to my ears. Not sure the second one can even be called English. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx