From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6658FC2D0F9 for ; Tue, 12 May 2020 21:26:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43E0720784 for ; Tue, 12 May 2020 21:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731310AbgELV0z (ORCPT ); Tue, 12 May 2020 17:26:55 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:55108 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728313AbgELV0y (ORCPT ); Tue, 12 May 2020 17:26:54 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 2AEE9803080B; Tue, 12 May 2020 21:26:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 91xGUihf2XO6; Wed, 13 May 2020 00:26:51 +0300 (MSK) Date: Wed, 13 May 2020 00:26:50 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Mark Brown , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , , , Thomas Gleixner , , Subject: Re: [PATCH 04/17] spi: dw: Cleanup generic DW DMA code namings Message-ID: <20200512212650.bmq5i3mrl5mydcvz@mobilestation> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200508132943.9826-5-Sergey.Semin@baikalelectronics.ru> <20200508194324.GA185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200508194324.GA185537@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 10:43:24PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 04:29:29PM +0300, Serge Semin wrote: > > Since from now the former Intel MID platform layer will be used > > as a generic DW SPI DMA module, lets alter the internal methods > > naming to be DMA-related instead of having the "mid_" prefix. In > > addition the DW PCI-DMA specific methods and structures should > > be named with pci-suffexes, since we'll implement the DW MMIO DMA > > specific functions and objects soon. > > I think we rather leave Intel Medfield things alone. And I think I did this already in spi/for-next in less invasive way. The naming is horrible in that module. Since it's going to be a generic DMA driver the prefixes should be correspondingly fixed. Currently they are a bit random. -Sergey > > -- > With Best Regards, > Andy Shevchenko > >