All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, Johannes.Thumshirn@wdc.com
Subject: Re: Bug 5.7-rc: root leak, eb leak
Date: Wed, 13 May 2020 01:03:33 +0200	[thread overview]
Message-ID: <20200512230333.GH18421@twin.jikos.cz> (raw)
In-Reply-To: <a1b2a3320c72e9bcd355caf93cc72fc093807c67e63be0fd59a5fbc1a3a6587f.dsterba@suse.com>

On Tue, May 12, 2020 at 04:14:23PM +0200, David Sterba wrote:
> Root an eb leak.
> 
> Johannes bisected the problem, the first bad commit is one of
> 
> 0e996e7fcf2e3a "btrfs: move ino_cache_inode dropping out of btrfs_free_fs_root"

Unlikely as inode_cache mount option is not used neither by the tests
nor by my testing setup.

> 3fd6372758d91d "btrfs: make the extent buffer leak check per fs info"

Unlikely as it's just moving extent buffer leak detector around.

> 8c38938c7bb096 "btrfs: move the root freeing stuff into btrfs_put_root"

That's most likely the cause.

> Reproduced on btrfs/028,

Johannes, do you have logs from the test?

> [failed, exit status 1][ 7084.791281] BTRFS info (device vdb): at unmount delalloc count 1994752

delalloc leak at umount

> [ 7085.109816] BTRFS error (device vdb): leaked root 18446744073709551607-0 refcount 1

18446744073709551607 == -9, which is BTRFS_DATA_RELOC_TREE_OBJECTID

So some post-reloc cleanup is maybe missing, the test btrfs/028 does
relocation and btrfs/125 as well.

  reply	other threads:[~2020-05-12 23:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 14:12 Pending bugs for 5.7 David Sterba
2020-05-12 14:14 ` Bug 5.7-rc: root leak, eb leak David Sterba
2020-05-12 23:03   ` David Sterba [this message]
2020-05-13 11:54     ` Johannes Thumshirn
2020-05-13 11:57       ` Qu Wenruo
2020-05-13 12:06         ` Johannes Thumshirn
2020-05-13 12:11           ` Qu Wenruo
2020-05-13 12:17             ` Johannes Thumshirn
2020-05-13 12:29               ` Johannes Thumshirn
2020-05-12 14:15 ` Bug 5.7-rc: write-time leaf corruption detected David Sterba
2020-05-12 14:26   ` Filipe Manana
2020-05-13  3:10   ` Qu Wenruo
2020-05-13  3:17     ` Qu Wenruo
2020-05-13  9:25     ` Filipe Manana
2020-05-19 14:26   ` Bug 5.7-rc: write-time leaf corruption detected (fixed) David Sterba
2020-05-12 14:15 ` Bug 5.7-rc: lockdep warning, chunk_mutex/device_list_mutex David Sterba
2020-05-12 23:28   ` David Sterba
2020-05-12 19:25     ` Anand Jain
2020-05-13 19:46   ` [PATCH] btrfs: fix lockdep warning chunk_mutex vs device_list_mutex Anand Jain
2020-05-15 17:40     ` David Sterba
2020-05-16  3:43       ` Anand Jain
2020-05-18 11:07         ` Anand Jain
2020-05-18 15:28           ` David Sterba
2020-05-12 14:15 ` Bug 5.7-rc: lockdep warning, fs_reclaim David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512230333.GH18421@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.