From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13DEC433E0 for ; Wed, 13 May 2020 19:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F2E7205ED for ; Wed, 13 May 2020 19:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403818AbgEMTw5 (ORCPT ); Wed, 13 May 2020 15:52:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390158AbgEMTw5 (ORCPT ); Wed, 13 May 2020 15:52:57 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30C64C061A0C; Wed, 13 May 2020 12:52:57 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E89C7127F6DAE; Wed, 13 May 2020 12:52:55 -0700 (PDT) Date: Wed, 13 May 2020 12:52:55 -0700 (PDT) Message-Id: <20200513.125255.2269307540440959207.davem@davemloft.net> To: michael@walle.cc Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk Subject: Re: [PATCH net-next 0/4] net: phy: broadcom: cable tester support From: David Miller In-Reply-To: <20200513163524.31256-1-michael@walle.cc> References: <20200513163524.31256-1-michael@walle.cc> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 May 2020 12:52:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Walle Date: Wed, 13 May 2020 18:35:20 +0200 > Add cable tester support for the Broadcom PHYs. Support for it was > developed on a BCM54140 Quad PHY which RDB register access. > > If there is a link partner the results are not as good as with an open > cable. I guess we could retry if the measurement until all pairs had at > least one valid result. > > changes since v1: > - added Reviewed-by: tags > - removed "div by 2" for cross shorts, just mention it in the commit > message. The results are inconclusive if the tests are repeated. So > just report the length as is for now. > - fixed typo in commit message Series applied, thanks.