From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C57C433DF for ; Wed, 13 May 2020 22:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D64E2054F for ; Wed, 13 May 2020 22:23:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731271AbgEMWXM (ORCPT ); Wed, 13 May 2020 18:23:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1731135AbgEMWXL (ORCPT ); Wed, 13 May 2020 18:23:11 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F459C061A0C for ; Wed, 13 May 2020 15:23:11 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BEECF12118550; Wed, 13 May 2020 15:23:10 -0700 (PDT) Date: Wed, 13 May 2020 15:23:10 -0700 (PDT) Message-Id: <20200513.152310.1761379266532416158.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH net] net: phy: fix aneg restart in phy_ethtool_set_eee From: David Miller In-Reply-To: <2a8c3ca7-4ef3-3dd7-6276-759f66ab8b5e@gmail.com> References: <2a8c3ca7-4ef3-3dd7-6276-759f66ab8b5e@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 May 2020 15:23:11 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Tue, 12 May 2020 21:45:53 +0200 > phy_restart_aneg() enables aneg in the PHY. That's not what we want > if phydev->autoneg is disabled. In this case still update EEE > advertisement register, but don't enable aneg and don't trigger an > aneg restart. > > Fixes: f75abeb8338e ("net: phy: restart phy autonegotiation after EEE advertisment change") > Signed-off-by: Heiner Kallweit Applied and queued up for -stable, thanks.