From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3168C2D0FC for ; Wed, 13 May 2020 00:38:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D531E20753 for ; Wed, 13 May 2020 00:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589330314; bh=cOjm/7GwqsA2ILplEdz4M1jv9gxyYn4Rl5iu9+dYr7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B4iLXYG1xrWihZsm0PLSvAq1KcorhuGY3AnFE7c+0gsOtm/uXkkJPo4ufJza/LfWc 0D/N62KTF2PhGG8KvfQE0auOKYlMbZ1/l56dCI0Xpn8eEaS9jGuIKcnlcNKCMwLhRA vfYMQjHPnV3M/lFJVo4gLEDnhdOuOsmznDOc9db8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729646AbgEMAie (ORCPT ); Tue, 12 May 2020 20:38:34 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33816 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728131AbgEMAie (ORCPT ); Tue, 12 May 2020 20:38:34 -0400 Received: by mail-pl1-f196.google.com with SMTP id g11so2895193plp.1; Tue, 12 May 2020 17:38:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CwfbmlNBUU40Zjz8zlAOmtB3ueHeKYzt7ce5wGYgKFA=; b=aqH3pLaspKAfdvXZwLL+58pl/C0iJGFYNZL9atbYNikaxnaboV71owlw3D92JfvO52 9Sw7zuGnvVs3qsa0ApEweFJZjUZyrqNDe4obTWdgwjzpWrdfOV1AEAuu1Gb0eiql5upu 9LVVb1XJGntMunkvt9nun+ezBsbvd49ziTxGlXL3MsMZw81wPFh0LKzifFYt1cV6ioLL EwCj8D2NbAIvS8afGYccqfmo2wzaT+gzJQ7ZO06v36zTfe84tUOCJLqnY4UQbUyGTi5R OQx89I+OnxW6MV3WNoxvMZIDC3mBvful16jnzhkwCQ4RLPVDxTqLTO+jr1ocBfZLa7Kb 6Faw== X-Gm-Message-State: AGi0Puaq/9hTNvkY2An66cyZMbS8frs00te00VhubT+nvAq4qVCuIFHl omaUKZsGlJK1LxOqrl1SICQ= X-Google-Smtp-Source: APiQypJrCgiM6NaHCnvonCFy7Yn3t2eJw+MEKj198/6OsHFmSqfNPQsM3ObIs9iYeLONwztqCuqQlw== X-Received: by 2002:a17:902:bd81:: with SMTP id q1mr22856141pls.46.1589330312971; Tue, 12 May 2020 17:38:32 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id j26sm13098929pfr.215.2020.05.12.17.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 17:38:31 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 60B934063E; Wed, 13 May 2020 00:38:30 +0000 (UTC) Date: Wed, 13 May 2020 00:38:30 +0000 From: Luis Chamberlain To: Scott Branden Cc: Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , Desmond Yan , James Hu Subject: Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver Message-ID: <20200513003830.GJ11244@42.do-not-panic.com> References: <20200508002739.19360-1-scott.branden@broadcom.com> <20200508002739.19360-7-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508002739.19360-7-scott.branden@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: > +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) > + > +#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ > +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf_priv > +int request_firmware_into_buf_priv(const struct firmware **firmware_p, > + const char *name, struct device *device, > + void *buf, size_t size, > + size_t offset, unsigned int pread_flags); > + > +#else > + > +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf > + > +#endif > + > +#endif Please clean this up, the code must reflect only the code upstream. No config stuff like this should be used on the driver. I had to stop my review here. Luis