All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
	drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-nvme@lists.infradead.org, target-devel@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-nfs@vger.kernel.org
Subject: [PATCH 10/33] tcp: add tcp_sock_set_cork
Date: Wed, 13 May 2020 08:26:25 +0200	[thread overview]
Message-ID: <20200513062649.2100053-11-hch@lst.de> (raw)
In-Reply-To: <20200513062649.2100053-1-hch@lst.de>

Add a helper to directly set the TCP_CORK sockopt from kernel space
without going through a fake uaccess.  Cleanup the callers to avoid
pointless wrappers now that this is a simple function call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_int.h      | 14 --------
 drivers/block/drbd/drbd_receiver.c |  4 +--
 drivers/block/drbd/drbd_worker.c   |  6 ++--
 fs/cifs/transport.c                |  8 ++---
 include/linux/tcp.h                |  2 ++
 net/ipv4/tcp.c                     | 51 +++++++++++++++++++-----------
 net/rds/tcp_send.c                 |  9 ++----
 7 files changed, 43 insertions(+), 51 deletions(-)

diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index aae99a2d7bd40..3550adc93c68b 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1570,20 +1570,6 @@ extern void drbd_set_recv_tcq(struct drbd_device *device, int tcq_enabled);
 extern void _drbd_clear_done_ee(struct drbd_device *device, struct list_head *to_be_freed);
 extern int drbd_connected(struct drbd_peer_device *);
 
-static inline void drbd_tcp_cork(struct socket *sock)
-{
-	int val = 1;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
-static inline void drbd_tcp_uncork(struct socket *sock)
-{
-	int val = 0;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
 static inline void drbd_tcp_nodelay(struct socket *sock)
 {
 	int val = 1;
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index c15e7083b13a6..55ea907ad33cb 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -6162,7 +6162,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	rcu_read_unlock();
 
 	if (tcp_cork)
-		drbd_tcp_cork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, true);
 
 	err = drbd_finish_peer_reqs(device);
 	kref_put(&device->kref, drbd_destroy_device);
@@ -6175,7 +6175,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	}
 
 	if (tcp_cork)
-		drbd_tcp_uncork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, false);
 
 	return;
 }
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 0dc019da1f8d0..2b89c9f2ca707 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -2098,7 +2098,7 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	if (uncork) {
 		mutex_lock(&connection->data.mutex);
 		if (connection->data.socket)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 		mutex_unlock(&connection->data.mutex);
 	}
 
@@ -2153,9 +2153,9 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	mutex_lock(&connection->data.mutex);
 	if (connection->data.socket) {
 		if (cork)
-			drbd_tcp_cork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, true);
 		else if (!uncork)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 	}
 	mutex_unlock(&connection->data.mutex);
 }
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index c97570eb2c180..99760063e0006 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -325,7 +325,6 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	size_t total_len = 0, sent, size;
 	struct socket *ssocket = server->ssocket;
 	struct msghdr smb_msg;
-	int val = 1;
 	__be32 rfc1002_marker;
 
 	if (cifs_rdma_enabled(server)) {
@@ -345,8 +344,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* cork the socket */
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, true);
 
 	for (j = 0; j < num_rqst; j++)
 		send_length += smb_rqst_len(server, &rqst[j]);
@@ -435,9 +433,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* uncork it */
-	val = 0;
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, false);
 
 	if ((total_len > 0) && (total_len != send_length)) {
 		cifs_dbg(FYI, "partial send (wanted=%u sent=%zu): terminating session\n",
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index e60db06ec28d7..7ef0f975a7658 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -494,4 +494,6 @@ static inline u16 tcp_mss_clamp(const struct tcp_sock *tp, u16 mss)
 int tcp_skb_shift(struct sk_buff *to, struct sk_buff *from, int pcount,
 		  int shiftlen);
 
+void tcp_sock_set_cork(struct sock *sk, bool on);
+
 #endif	/* _LINUX_TCP_H */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 8c1250103959a..e11ba10b90d4c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2790,6 +2790,37 @@ static void tcp_enable_tx_delay(void)
 	}
 }
 
+/* When set indicates to always queue non-full frames.  Later the user clears
+ * this option and we transmit any pending partial frames in the queue.  This is
+ * meant to be used alongside sendfile() to get properly filled frames when the
+ * user (for example) must write out headers with a write() call first and then
+ * use sendfile to send out the data parts.
+ *
+ * TCP_CORK can be set together with TCP_NODELAY and it is stronger than
+ * TCP_NODELAY.
+ */
+static void __tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	struct tcp_sock *tp = tcp_sk(sk);
+
+	if (on) {
+		tp->nonagle |= TCP_NAGLE_CORK;
+	} else {
+		tp->nonagle &= ~TCP_NAGLE_CORK;
+		if (tp->nonagle & TCP_NAGLE_OFF)
+			tp->nonagle |= TCP_NAGLE_PUSH;
+		tcp_push_pending_frames(sk);
+	}
+}
+
+void tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	lock_sock(sk);
+	__tcp_sock_set_cork(sk, on);
+	release_sock(sk);
+}
+EXPORT_SYMBOL(tcp_sock_set_cork);
+
 /*
  *	Socket option code for TCP.
  */
@@ -2968,25 +2999,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 		break;
 
 	case TCP_CORK:
-		/* When set indicates to always queue non-full frames.
-		 * Later the user clears this option and we transmit
-		 * any pending partial frames in the queue.  This is
-		 * meant to be used alongside sendfile() to get properly
-		 * filled frames when the user (for example) must write
-		 * out headers with a write() call first and then use
-		 * sendfile to send out the data parts.
-		 *
-		 * TCP_CORK can be set together with TCP_NODELAY and it is
-		 * stronger than TCP_NODELAY.
-		 */
-		if (val) {
-			tp->nonagle |= TCP_NAGLE_CORK;
-		} else {
-			tp->nonagle &= ~TCP_NAGLE_CORK;
-			if (tp->nonagle&TCP_NAGLE_OFF)
-				tp->nonagle |= TCP_NAGLE_PUSH;
-			tcp_push_pending_frames(sk);
-		}
+		__tcp_sock_set_cork(sk, val);
 		break;
 
 	case TCP_KEEPIDLE:
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c
index 78a2554a44979..8c4d1d6e9249d 100644
--- a/net/rds/tcp_send.c
+++ b/net/rds/tcp_send.c
@@ -38,23 +38,18 @@
 #include "rds.h"
 #include "tcp.h"
 
-static void rds_tcp_cork(struct socket *sock, int val)
-{
-	kernel_setsockopt(sock, SOL_TCP, TCP_CORK, (void *)&val, sizeof(val));
-}
-
 void rds_tcp_xmit_path_prepare(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 1);
+	tcp_sock_set_cork(tc->t_sock->sk, true);
 }
 
 void rds_tcp_xmit_path_complete(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 0);
+	tcp_sock_set_cork(tc->t_sock->sk, false);
 }
 
 /* the core send_sem serializes this with other xmit and shutdown */
-- 
2.26.2


WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
	drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-nvme@lists.infradead.org, target-devel@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-nfs@vger.kernel.org
Subject: [PATCH 10/33] tcp: add tcp_sock_set_cork
Date: Wed, 13 May 2020 06:26:25 +0000	[thread overview]
Message-ID: <20200513062649.2100053-11-hch@lst.de> (raw)
In-Reply-To: <20200513062649.2100053-1-hch@lst.de>

Add a helper to directly set the TCP_CORK sockopt from kernel space
without going through a fake uaccess.  Cleanup the callers to avoid
pointless wrappers now that this is a simple function call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_int.h      | 14 --------
 drivers/block/drbd/drbd_receiver.c |  4 +--
 drivers/block/drbd/drbd_worker.c   |  6 ++--
 fs/cifs/transport.c                |  8 ++---
 include/linux/tcp.h                |  2 ++
 net/ipv4/tcp.c                     | 51 +++++++++++++++++++-----------
 net/rds/tcp_send.c                 |  9 ++----
 7 files changed, 43 insertions(+), 51 deletions(-)

diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index aae99a2d7bd40..3550adc93c68b 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1570,20 +1570,6 @@ extern void drbd_set_recv_tcq(struct drbd_device *device, int tcq_enabled);
 extern void _drbd_clear_done_ee(struct drbd_device *device, struct list_head *to_be_freed);
 extern int drbd_connected(struct drbd_peer_device *);
 
-static inline void drbd_tcp_cork(struct socket *sock)
-{
-	int val = 1;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
-static inline void drbd_tcp_uncork(struct socket *sock)
-{
-	int val = 0;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
 static inline void drbd_tcp_nodelay(struct socket *sock)
 {
 	int val = 1;
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index c15e7083b13a6..55ea907ad33cb 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -6162,7 +6162,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	rcu_read_unlock();
 
 	if (tcp_cork)
-		drbd_tcp_cork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, true);
 
 	err = drbd_finish_peer_reqs(device);
 	kref_put(&device->kref, drbd_destroy_device);
@@ -6175,7 +6175,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	}
 
 	if (tcp_cork)
-		drbd_tcp_uncork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, false);
 
 	return;
 }
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 0dc019da1f8d0..2b89c9f2ca707 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -2098,7 +2098,7 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	if (uncork) {
 		mutex_lock(&connection->data.mutex);
 		if (connection->data.socket)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 		mutex_unlock(&connection->data.mutex);
 	}
 
@@ -2153,9 +2153,9 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	mutex_lock(&connection->data.mutex);
 	if (connection->data.socket) {
 		if (cork)
-			drbd_tcp_cork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, true);
 		else if (!uncork)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 	}
 	mutex_unlock(&connection->data.mutex);
 }
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index c97570eb2c180..99760063e0006 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -325,7 +325,6 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	size_t total_len = 0, sent, size;
 	struct socket *ssocket = server->ssocket;
 	struct msghdr smb_msg;
-	int val = 1;
 	__be32 rfc1002_marker;
 
 	if (cifs_rdma_enabled(server)) {
@@ -345,8 +344,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* cork the socket */
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, true);
 
 	for (j = 0; j < num_rqst; j++)
 		send_length += smb_rqst_len(server, &rqst[j]);
@@ -435,9 +433,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* uncork it */
-	val = 0;
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, false);
 
 	if ((total_len > 0) && (total_len != send_length)) {
 		cifs_dbg(FYI, "partial send (wanted=%u sent=%zu): terminating session\n",
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index e60db06ec28d7..7ef0f975a7658 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -494,4 +494,6 @@ static inline u16 tcp_mss_clamp(const struct tcp_sock *tp, u16 mss)
 int tcp_skb_shift(struct sk_buff *to, struct sk_buff *from, int pcount,
 		  int shiftlen);
 
+void tcp_sock_set_cork(struct sock *sk, bool on);
+
 #endif	/* _LINUX_TCP_H */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 8c1250103959a..e11ba10b90d4c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2790,6 +2790,37 @@ static void tcp_enable_tx_delay(void)
 	}
 }
 
+/* When set indicates to always queue non-full frames.  Later the user clears
+ * this option and we transmit any pending partial frames in the queue.  This is
+ * meant to be used alongside sendfile() to get properly filled frames when the
+ * user (for example) must write out headers with a write() call first and then
+ * use sendfile to send out the data parts.
+ *
+ * TCP_CORK can be set together with TCP_NODELAY and it is stronger than
+ * TCP_NODELAY.
+ */
+static void __tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	struct tcp_sock *tp = tcp_sk(sk);
+
+	if (on) {
+		tp->nonagle |= TCP_NAGLE_CORK;
+	} else {
+		tp->nonagle &= ~TCP_NAGLE_CORK;
+		if (tp->nonagle & TCP_NAGLE_OFF)
+			tp->nonagle |= TCP_NAGLE_PUSH;
+		tcp_push_pending_frames(sk);
+	}
+}
+
+void tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	lock_sock(sk);
+	__tcp_sock_set_cork(sk, on);
+	release_sock(sk);
+}
+EXPORT_SYMBOL(tcp_sock_set_cork);
+
 /*
  *	Socket option code for TCP.
  */
@@ -2968,25 +2999,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 		break;
 
 	case TCP_CORK:
-		/* When set indicates to always queue non-full frames.
-		 * Later the user clears this option and we transmit
-		 * any pending partial frames in the queue.  This is
-		 * meant to be used alongside sendfile() to get properly
-		 * filled frames when the user (for example) must write
-		 * out headers with a write() call first and then use
-		 * sendfile to send out the data parts.
-		 *
-		 * TCP_CORK can be set together with TCP_NODELAY and it is
-		 * stronger than TCP_NODELAY.
-		 */
-		if (val) {
-			tp->nonagle |= TCP_NAGLE_CORK;
-		} else {
-			tp->nonagle &= ~TCP_NAGLE_CORK;
-			if (tp->nonagle&TCP_NAGLE_OFF)
-				tp->nonagle |= TCP_NAGLE_PUSH;
-			tcp_push_pending_frames(sk);
-		}
+		__tcp_sock_set_cork(sk, val);
 		break;
 
 	case TCP_KEEPIDLE:
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c
index 78a2554a44979..8c4d1d6e9249d 100644
--- a/net/rds/tcp_send.c
+++ b/net/rds/tcp_send.c
@@ -38,23 +38,18 @@
 #include "rds.h"
 #include "tcp.h"
 
-static void rds_tcp_cork(struct socket *sock, int val)
-{
-	kernel_setsockopt(sock, SOL_TCP, TCP_CORK, (void *)&val, sizeof(val));
-}
-
 void rds_tcp_xmit_path_prepare(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 1);
+	tcp_sock_set_cork(tc->t_sock->sk, true);
 }
 
 void rds_tcp_xmit_path_complete(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 0);
+	tcp_sock_set_cork(tc->t_sock->sk, false);
 }
 
 /* the core send_sem serializes this with other xmit and shutdown */
-- 
2.26.2

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org,
	target-devel@vger.kernel.org, linux-afs@lists.infradead.org,
	drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org,
	rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
	cluster-devel@redhat.com, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
	linux-nfs@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	netdev@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
	linux-kernel@vger.kernel.org, Jon Maloy <jmaloy@redhat.com>,
	Ying Xue <ying.xue@windriver.com>,
	ocfs2-devel@oss.oracle.com
Subject: [PATCH 10/33] tcp: add tcp_sock_set_cork
Date: Wed, 13 May 2020 08:26:25 +0200	[thread overview]
Message-ID: <20200513062649.2100053-11-hch@lst.de> (raw)
In-Reply-To: <20200513062649.2100053-1-hch@lst.de>

Add a helper to directly set the TCP_CORK sockopt from kernel space
without going through a fake uaccess.  Cleanup the callers to avoid
pointless wrappers now that this is a simple function call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_int.h      | 14 --------
 drivers/block/drbd/drbd_receiver.c |  4 +--
 drivers/block/drbd/drbd_worker.c   |  6 ++--
 fs/cifs/transport.c                |  8 ++---
 include/linux/tcp.h                |  2 ++
 net/ipv4/tcp.c                     | 51 +++++++++++++++++++-----------
 net/rds/tcp_send.c                 |  9 ++----
 7 files changed, 43 insertions(+), 51 deletions(-)

diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index aae99a2d7bd40..3550adc93c68b 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1570,20 +1570,6 @@ extern void drbd_set_recv_tcq(struct drbd_device *device, int tcq_enabled);
 extern void _drbd_clear_done_ee(struct drbd_device *device, struct list_head *to_be_freed);
 extern int drbd_connected(struct drbd_peer_device *);
 
-static inline void drbd_tcp_cork(struct socket *sock)
-{
-	int val = 1;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
-static inline void drbd_tcp_uncork(struct socket *sock)
-{
-	int val = 0;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
 static inline void drbd_tcp_nodelay(struct socket *sock)
 {
 	int val = 1;
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index c15e7083b13a6..55ea907ad33cb 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -6162,7 +6162,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	rcu_read_unlock();
 
 	if (tcp_cork)
-		drbd_tcp_cork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, true);
 
 	err = drbd_finish_peer_reqs(device);
 	kref_put(&device->kref, drbd_destroy_device);
@@ -6175,7 +6175,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	}
 
 	if (tcp_cork)
-		drbd_tcp_uncork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, false);
 
 	return;
 }
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 0dc019da1f8d0..2b89c9f2ca707 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -2098,7 +2098,7 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	if (uncork) {
 		mutex_lock(&connection->data.mutex);
 		if (connection->data.socket)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 		mutex_unlock(&connection->data.mutex);
 	}
 
@@ -2153,9 +2153,9 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	mutex_lock(&connection->data.mutex);
 	if (connection->data.socket) {
 		if (cork)
-			drbd_tcp_cork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, true);
 		else if (!uncork)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 	}
 	mutex_unlock(&connection->data.mutex);
 }
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index c97570eb2c180..99760063e0006 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -325,7 +325,6 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	size_t total_len = 0, sent, size;
 	struct socket *ssocket = server->ssocket;
 	struct msghdr smb_msg;
-	int val = 1;
 	__be32 rfc1002_marker;
 
 	if (cifs_rdma_enabled(server)) {
@@ -345,8 +344,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* cork the socket */
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, true);
 
 	for (j = 0; j < num_rqst; j++)
 		send_length += smb_rqst_len(server, &rqst[j]);
@@ -435,9 +433,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* uncork it */
-	val = 0;
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, false);
 
 	if ((total_len > 0) && (total_len != send_length)) {
 		cifs_dbg(FYI, "partial send (wanted=%u sent=%zu): terminating session\n",
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index e60db06ec28d7..7ef0f975a7658 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -494,4 +494,6 @@ static inline u16 tcp_mss_clamp(const struct tcp_sock *tp, u16 mss)
 int tcp_skb_shift(struct sk_buff *to, struct sk_buff *from, int pcount,
 		  int shiftlen);
 
+void tcp_sock_set_cork(struct sock *sk, bool on);
+
 #endif	/* _LINUX_TCP_H */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 8c1250103959a..e11ba10b90d4c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2790,6 +2790,37 @@ static void tcp_enable_tx_delay(void)
 	}
 }
 
+/* When set indicates to always queue non-full frames.  Later the user clears
+ * this option and we transmit any pending partial frames in the queue.  This is
+ * meant to be used alongside sendfile() to get properly filled frames when the
+ * user (for example) must write out headers with a write() call first and then
+ * use sendfile to send out the data parts.
+ *
+ * TCP_CORK can be set together with TCP_NODELAY and it is stronger than
+ * TCP_NODELAY.
+ */
+static void __tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	struct tcp_sock *tp = tcp_sk(sk);
+
+	if (on) {
+		tp->nonagle |= TCP_NAGLE_CORK;
+	} else {
+		tp->nonagle &= ~TCP_NAGLE_CORK;
+		if (tp->nonagle & TCP_NAGLE_OFF)
+			tp->nonagle |= TCP_NAGLE_PUSH;
+		tcp_push_pending_frames(sk);
+	}
+}
+
+void tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	lock_sock(sk);
+	__tcp_sock_set_cork(sk, on);
+	release_sock(sk);
+}
+EXPORT_SYMBOL(tcp_sock_set_cork);
+
 /*
  *	Socket option code for TCP.
  */
@@ -2968,25 +2999,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 		break;
 
 	case TCP_CORK:
-		/* When set indicates to always queue non-full frames.
-		 * Later the user clears this option and we transmit
-		 * any pending partial frames in the queue.  This is
-		 * meant to be used alongside sendfile() to get properly
-		 * filled frames when the user (for example) must write
-		 * out headers with a write() call first and then use
-		 * sendfile to send out the data parts.
-		 *
-		 * TCP_CORK can be set together with TCP_NODELAY and it is
-		 * stronger than TCP_NODELAY.
-		 */
-		if (val) {
-			tp->nonagle |= TCP_NAGLE_CORK;
-		} else {
-			tp->nonagle &= ~TCP_NAGLE_CORK;
-			if (tp->nonagle&TCP_NAGLE_OFF)
-				tp->nonagle |= TCP_NAGLE_PUSH;
-			tcp_push_pending_frames(sk);
-		}
+		__tcp_sock_set_cork(sk, val);
 		break;
 
 	case TCP_KEEPIDLE:
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c
index 78a2554a44979..8c4d1d6e9249d 100644
--- a/net/rds/tcp_send.c
+++ b/net/rds/tcp_send.c
@@ -38,23 +38,18 @@
 #include "rds.h"
 #include "tcp.h"
 
-static void rds_tcp_cork(struct socket *sock, int val)
-{
-	kernel_setsockopt(sock, SOL_TCP, TCP_CORK, (void *)&val, sizeof(val));
-}
-
 void rds_tcp_xmit_path_prepare(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 1);
+	tcp_sock_set_cork(tc->t_sock->sk, true);
 }
 
 void rds_tcp_xmit_path_complete(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 0);
+	tcp_sock_set_cork(tc->t_sock->sk, false);
 }
 
 /* the core send_sem serializes this with other xmit and shutdown */
-- 
2.26.2


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
	drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-nvme@lists.infradead.org, target-devel@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-nfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 10/33] tcp: add tcp_sock_set_cork
Date: Wed, 13 May 2020 08:26:25 +0200	[thread overview]
Message-ID: <20200513062649.2100053-11-hch@lst.de> (raw)
In-Reply-To: <20200513062649.2100053-1-hch@lst.de>

Add a helper to directly set the TCP_CORK sockopt from kernel space
without going through a fake uaccess.  Cleanup the callers to avoid
pointless wrappers now that this is a simple function call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/drbd/drbd_int.h      | 14 --------
 drivers/block/drbd/drbd_receiver.c |  4 +--
 drivers/block/drbd/drbd_worker.c   |  6 ++--
 fs/cifs/transport.c                |  8 ++---
 include/linux/tcp.h                |  2 ++
 net/ipv4/tcp.c                     | 51 +++++++++++++++++++-----------
 net/rds/tcp_send.c                 |  9 ++----
 7 files changed, 43 insertions(+), 51 deletions(-)

diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index aae99a2d7bd40..3550adc93c68b 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1570,20 +1570,6 @@ extern void drbd_set_recv_tcq(struct drbd_device *device, int tcq_enabled);
 extern void _drbd_clear_done_ee(struct drbd_device *device, struct list_head *to_be_freed);
 extern int drbd_connected(struct drbd_peer_device *);
 
-static inline void drbd_tcp_cork(struct socket *sock)
-{
-	int val = 1;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
-static inline void drbd_tcp_uncork(struct socket *sock)
-{
-	int val = 0;
-	(void) kernel_setsockopt(sock, SOL_TCP, TCP_CORK,
-			(char*)&val, sizeof(val));
-}
-
 static inline void drbd_tcp_nodelay(struct socket *sock)
 {
 	int val = 1;
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index c15e7083b13a6..55ea907ad33cb 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -6162,7 +6162,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	rcu_read_unlock();
 
 	if (tcp_cork)
-		drbd_tcp_cork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, true);
 
 	err = drbd_finish_peer_reqs(device);
 	kref_put(&device->kref, drbd_destroy_device);
@@ -6175,7 +6175,7 @@ void drbd_send_acks_wf(struct work_struct *ws)
 	}
 
 	if (tcp_cork)
-		drbd_tcp_uncork(connection->meta.socket);
+		tcp_sock_set_cork(connection->meta.socket->sk, false);
 
 	return;
 }
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 0dc019da1f8d0..2b89c9f2ca707 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -2098,7 +2098,7 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	if (uncork) {
 		mutex_lock(&connection->data.mutex);
 		if (connection->data.socket)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 		mutex_unlock(&connection->data.mutex);
 	}
 
@@ -2153,9 +2153,9 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
 	mutex_lock(&connection->data.mutex);
 	if (connection->data.socket) {
 		if (cork)
-			drbd_tcp_cork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, true);
 		else if (!uncork)
-			drbd_tcp_uncork(connection->data.socket);
+			tcp_sock_set_cork(connection->data.socket->sk, false);
 	}
 	mutex_unlock(&connection->data.mutex);
 }
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index c97570eb2c180..99760063e0006 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -325,7 +325,6 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	size_t total_len = 0, sent, size;
 	struct socket *ssocket = server->ssocket;
 	struct msghdr smb_msg;
-	int val = 1;
 	__be32 rfc1002_marker;
 
 	if (cifs_rdma_enabled(server)) {
@@ -345,8 +344,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* cork the socket */
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, true);
 
 	for (j = 0; j < num_rqst; j++)
 		send_length += smb_rqst_len(server, &rqst[j]);
@@ -435,9 +433,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
 	}
 
 	/* uncork it */
-	val = 0;
-	kernel_setsockopt(ssocket, SOL_TCP, TCP_CORK,
-				(char *)&val, sizeof(val));
+	tcp_sock_set_cork(ssocket->sk, false);
 
 	if ((total_len > 0) && (total_len != send_length)) {
 		cifs_dbg(FYI, "partial send (wanted=%u sent=%zu): terminating session\n",
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index e60db06ec28d7..7ef0f975a7658 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -494,4 +494,6 @@ static inline u16 tcp_mss_clamp(const struct tcp_sock *tp, u16 mss)
 int tcp_skb_shift(struct sk_buff *to, struct sk_buff *from, int pcount,
 		  int shiftlen);
 
+void tcp_sock_set_cork(struct sock *sk, bool on);
+
 #endif	/* _LINUX_TCP_H */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 8c1250103959a..e11ba10b90d4c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2790,6 +2790,37 @@ static void tcp_enable_tx_delay(void)
 	}
 }
 
+/* When set indicates to always queue non-full frames.  Later the user clears
+ * this option and we transmit any pending partial frames in the queue.  This is
+ * meant to be used alongside sendfile() to get properly filled frames when the
+ * user (for example) must write out headers with a write() call first and then
+ * use sendfile to send out the data parts.
+ *
+ * TCP_CORK can be set together with TCP_NODELAY and it is stronger than
+ * TCP_NODELAY.
+ */
+static void __tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	struct tcp_sock *tp = tcp_sk(sk);
+
+	if (on) {
+		tp->nonagle |= TCP_NAGLE_CORK;
+	} else {
+		tp->nonagle &= ~TCP_NAGLE_CORK;
+		if (tp->nonagle & TCP_NAGLE_OFF)
+			tp->nonagle |= TCP_NAGLE_PUSH;
+		tcp_push_pending_frames(sk);
+	}
+}
+
+void tcp_sock_set_cork(struct sock *sk, bool on)
+{
+	lock_sock(sk);
+	__tcp_sock_set_cork(sk, on);
+	release_sock(sk);
+}
+EXPORT_SYMBOL(tcp_sock_set_cork);
+
 /*
  *	Socket option code for TCP.
  */
@@ -2968,25 +2999,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
 		break;
 
 	case TCP_CORK:
-		/* When set indicates to always queue non-full frames.
-		 * Later the user clears this option and we transmit
-		 * any pending partial frames in the queue.  This is
-		 * meant to be used alongside sendfile() to get properly
-		 * filled frames when the user (for example) must write
-		 * out headers with a write() call first and then use
-		 * sendfile to send out the data parts.
-		 *
-		 * TCP_CORK can be set together with TCP_NODELAY and it is
-		 * stronger than TCP_NODELAY.
-		 */
-		if (val) {
-			tp->nonagle |= TCP_NAGLE_CORK;
-		} else {
-			tp->nonagle &= ~TCP_NAGLE_CORK;
-			if (tp->nonagle&TCP_NAGLE_OFF)
-				tp->nonagle |= TCP_NAGLE_PUSH;
-			tcp_push_pending_frames(sk);
-		}
+		__tcp_sock_set_cork(sk, val);
 		break;
 
 	case TCP_KEEPIDLE:
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c
index 78a2554a44979..8c4d1d6e9249d 100644
--- a/net/rds/tcp_send.c
+++ b/net/rds/tcp_send.c
@@ -38,23 +38,18 @@
 #include "rds.h"
 #include "tcp.h"
 
-static void rds_tcp_cork(struct socket *sock, int val)
-{
-	kernel_setsockopt(sock, SOL_TCP, TCP_CORK, (void *)&val, sizeof(val));
-}
-
 void rds_tcp_xmit_path_prepare(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 1);
+	tcp_sock_set_cork(tc->t_sock->sk, true);
 }
 
 void rds_tcp_xmit_path_complete(struct rds_conn_path *cp)
 {
 	struct rds_tcp_connection *tc = cp->cp_transport_data;
 
-	rds_tcp_cork(tc->t_sock, 0);
+	tcp_sock_set_cork(tc->t_sock->sk, false);
 }
 
 /* the core send_sem serializes this with other xmit and shutdown */
-- 
2.26.2

  parent reply	other threads:[~2020-05-13  6:31 UTC|newest]

Thread overview: 578+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13  6:26 remove kernel_setsockopt and kernel_getsockopt Christoph Hellwig
2020-05-13  6:26 ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26 ` Christoph Hellwig
2020-05-13  6:26 ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 01/33] net: add sock_set_reuseaddr Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 02/33] net: add sock_set_linger Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 03/33] net: add sock_set_priority Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 04/33] net: add sock_set_sndtimeo Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 05/33] net: add sock_bindtoindex Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 06/33] net: add sock_set_timestamps Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 07/33] net: add sock_set_keepalive Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 08/33] net: add sock_set_rcvbuf Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 09/33] net: add sock_set_reuseport Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` Christoph Hellwig [this message]
2020-05-13  6:26   ` [Ocfs2-devel] [PATCH 10/33] tcp: add tcp_sock_set_cork Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 11/33] tcp: tcp_sock_set_nodelay Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13 12:51   ` Jason Gunthorpe
2020-05-13 12:51     ` [Ocfs2-devel] " Jason Gunthorpe
2020-05-13 12:51     ` Jason Gunthorpe
2020-05-13 12:51     ` Jason Gunthorpe
2020-05-13 12:51     ` Jason Gunthorpe
2020-05-13  6:26 ` [PATCH 12/33] tcp: add tcp_sock_set_quickack Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 13/33] tcp: add tcp_sock_set_syncnt Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 14/33] tcp: add tcp_sock_set_user_timeout Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 15/33] tcp: add tcp_sock_set_keepidle Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 16/33] tcp: add tcp_sock_set_keepintvl Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 17/33] tcp: add tcp_sock_set_keepcnt Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 18/33] ipv4: add ip_sock_set_tos Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 19/33] ipv4: add ip_sock_set_freebind Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 20/33] ipv4: add ip_sock_set_recverr Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13 21:00   ` Joe Perches
2020-05-13 21:00     ` [Ocfs2-devel] " Joe Perches
2020-05-13 21:00     ` Joe Perches
2020-05-13 21:00     ` Joe Perches
2020-05-14 10:30     ` Christoph Hellwig
2020-05-14 10:30       ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14 10:30       ` Christoph Hellwig
2020-05-14 10:30       ` Christoph Hellwig
2020-05-14 10:30       ` Christoph Hellwig
2020-05-14 11:51       ` Joe Perches
2020-05-14 11:51         ` [Ocfs2-devel] " Joe Perches
2020-05-14 11:51         ` Joe Perches
2020-05-14 11:51         ` Joe Perches
2020-05-14 11:51         ` Joe Perches
2020-05-20 14:18         ` Christoph Hellwig
2020-05-20 14:18           ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 14:18           ` Christoph Hellwig
2020-05-20 14:18           ` Christoph Hellwig
2020-05-20 14:18           ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 22/33] ipv6: add ip6_sock_set_v6only Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 23/33] ipv6: add ip6_sock_set_recverr Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 24/33] ipv6: add ip6_sock_set_addr_preferences Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 25/33] ipv6: add ip6_sock_set_recvpktinfo Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 26/33] sctp: lift copying in addrs into sctp_setsockopt Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 27/33] sctp: export sctp_setsockopt_bindx Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13 18:00   ` Marcelo Ricardo Leitner
2020-05-13 18:00     ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-13 18:00     ` Marcelo Ricardo Leitner
2020-05-13 18:00     ` Marcelo Ricardo Leitner
2020-05-14  6:28     ` Christoph Hellwig
2020-05-14  6:28       ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14  6:28       ` Christoph Hellwig
2020-05-14  6:28       ` Christoph Hellwig
2020-05-14  6:28       ` Christoph Hellwig
2020-05-14  8:23     ` David Laight
2020-05-14  8:23       ` [Ocfs2-devel] " David Laight
2020-05-14  8:23       ` David Laight
2020-05-14  8:23       ` David Laight
2020-05-14 10:40     ` is it ok to always pull in sctp for dlm, was: " Christoph Hellwig
2020-05-14 10:40       ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14 10:40       ` Christoph Hellwig
2020-05-14 10:40       ` Christoph Hellwig
2020-05-14 10:40       ` Christoph Hellwig
2020-05-14 14:24       ` David Teigland
2020-05-14 14:24         ` [Ocfs2-devel] " David Teigland
2020-05-14 14:24         ` David Teigland
2020-05-14 14:24         ` David Teigland
2020-05-14 14:24         ` is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bin David Teigland
2020-05-15 15:20     ` [PATCH 27/33] sctp: export sctp_setsockopt_bindx David Howells
2020-05-15 15:20       ` [Ocfs2-devel] " David Howells
2020-05-15 15:20       ` David Howells
2020-05-15 15:20       ` David Howells
2020-05-15 15:20       ` David Howells
2020-05-15 15:24       ` Christoph Hellwig
2020-05-15 15:24         ` [Ocfs2-devel] " Christoph Hellwig
2020-05-15 15:24         ` Christoph Hellwig
2020-05-15 15:24         ` Christoph Hellwig
2020-05-15 15:24         ` Christoph Hellwig
2020-05-16 15:21         ` David Laight
2020-05-16 15:21           ` [Ocfs2-devel] " David Laight
2020-05-16 15:21           ` David Laight
2020-05-16 15:21           ` David Laight
2020-05-16 15:11       ` David Laight
2020-05-16 15:11         ` [Ocfs2-devel] " David Laight
2020-05-16 15:11         ` David Laight
2020-05-16 15:11         ` David Laight
2020-05-16 15:11         ` David Laight
2020-05-16 15:36         ` [Ocfs2-devel] " Matthew Wilcox
2020-05-16 15:36           ` Matthew Wilcox
2020-05-16 15:36           ` Matthew Wilcox
2020-05-16 15:36           ` Matthew Wilcox
2020-05-16 15:36           ` Matthew Wilcox
2020-05-17  8:48           ` David Laight
2020-05-17  8:48             ` David Laight
2020-05-17  8:48             ` David Laight
2020-05-17  8:48             ` David Laight
2020-05-13  6:26 ` [PATCH 28/33] sctp: add sctp_sock_set_nodelay Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 29/33] rxrpc_sock_set_min_security_level Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 30/33] tipc: call tsk_set_importance from tipc_topsrv_create_listener Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 31/33] net: remove kernel_setsockopt Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26 ` [PATCH 32/33] sctp: add sctp_sock_get_primary_addr Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13 18:03   ` Marcelo Ricardo Leitner
2020-05-13 18:03     ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-13 18:03     ` Marcelo Ricardo Leitner
2020-05-13 18:03     ` Marcelo Ricardo Leitner
2020-05-14  9:51     ` David Laight
2020-05-14  9:51       ` [Ocfs2-devel] " David Laight
2020-05-14  9:51       ` David Laight
2020-05-14  9:51       ` David Laight
2020-05-14 12:30       ` David Laight
2020-05-14 12:30         ` [Ocfs2-devel] " David Laight
2020-05-14 12:30         ` David Laight
2020-05-14 12:30         ` David Laight
2020-05-14 13:27         ` David Laight
2020-05-14 13:27           ` [Ocfs2-devel] " David Laight
2020-05-14 13:27           ` David Laight
2020-05-14 13:27           ` David Laight
2020-05-13  6:26 ` [PATCH 33/33] net: remove kernel_getsockopt Christoph Hellwig
2020-05-13  6:26   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13  6:26   ` Christoph Hellwig
2020-05-13 13:13 ` [PATCH 29/33] rxrpc_sock_set_min_security_level David Howells
2020-05-13 13:13   ` [Ocfs2-devel] " David Howells
2020-05-13 13:13   ` David Howells
2020-05-13 13:13   ` David Howells
2020-05-13 13:13   ` David Howells
2020-05-14 10:29   ` Christoph Hellwig
2020-05-14 10:29     ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14 10:29     ` Christoph Hellwig
2020-05-14 10:29     ` Christoph Hellwig
2020-05-14 10:29     ` Christoph Hellwig
2020-05-15 15:13   ` David Howells
2020-05-15 15:13     ` [Ocfs2-devel] " David Howells
2020-05-15 15:13     ` David Howells
2020-05-15 15:13     ` David Howells
2020-05-15 15:13     ` David Howells
2020-05-13 13:17 ` [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover David Howells
2020-05-13 13:17   ` [Ocfs2-devel] " David Howells
2020-05-13 13:17   ` David Howells
2020-05-13 13:17   ` David Howells
2020-05-13 13:17   ` David Howells
2020-05-14  6:26   ` Christoph Hellwig
2020-05-14  6:26     ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14  6:26     ` Christoph Hellwig
2020-05-14  6:26     ` Christoph Hellwig
2020-05-14  6:26     ` Christoph Hellwig
2020-05-15 15:15   ` David Howells
2020-05-15 15:15     ` [Ocfs2-devel] " David Howells
2020-05-15 15:15     ` David Howells
2020-05-15 15:15     ` David Howells
2020-05-15 15:15     ` David Howells
2020-05-13 13:24 ` [PATCH 20/33] ipv4: add ip_sock_set_recverr David Howells
2020-05-13 13:24   ` [Ocfs2-devel] " David Howells
2020-05-13 13:24   ` David Howells
2020-05-13 13:24   ` David Howells
2020-05-13 13:24   ` David Howells
2020-05-13 13:25 ` [PATCH 23/33] ipv6: add ip6_sock_set_recverr David Howells
2020-05-13 13:25   ` [Ocfs2-devel] " David Howells
2020-05-13 13:25   ` David Howells
2020-05-13 13:25   ` David Howells
2020-05-13 13:25   ` David Howells
2020-05-13 13:27 ` [PATCH 06/33] net: add sock_set_timestamps David Howells
2020-05-13 13:27   ` [Ocfs2-devel] " David Howells
2020-05-13 13:27   ` David Howells
2020-05-13 13:27   ` David Howells
2020-05-13 13:27   ` David Howells
2020-05-13 17:38 ` remove kernel_setsockopt and kernel_getsockopt Joe Perches
2020-05-13 17:38   ` [Ocfs2-devel] " Joe Perches
2020-05-13 17:38   ` Joe Perches
2020-05-13 17:38   ` Joe Perches
2020-05-14  6:27   ` Christoph Hellwig
2020-05-14  6:27     ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14  6:27     ` Christoph Hellwig
2020-05-14  6:27     ` Christoph Hellwig
2020-05-14  6:27     ` Christoph Hellwig
2020-05-14  8:29   ` David Laight
2020-05-14  8:29     ` [Ocfs2-devel] " David Laight
2020-05-14  8:29     ` David Laight
2020-05-14  8:29     ` David Laight
2020-05-14 10:18     ` Christoph Hellwig
2020-05-14 10:18       ` [Ocfs2-devel] " Christoph Hellwig
2020-05-14 10:18       ` Christoph Hellwig
2020-05-14 10:18       ` Christoph Hellwig
2020-05-14 10:18       ` Christoph Hellwig
2020-05-14 10:26       ` David Laight
2020-05-14 10:26         ` [Ocfs2-devel] " David Laight
2020-05-14 10:26         ` David Laight
2020-05-14 10:26         ` David Laight
2020-05-14 10:26         ` David Laight
2020-05-14 10:34         ` 'Christoph Hellwig'
2020-05-14 10:34           ` [Ocfs2-devel] " 'Christoph Hellwig'
2020-05-14 10:34           ` 'Christoph Hellwig'
2020-05-14 10:34           ` 'Christoph Hellwig'
2020-05-14 10:34           ` 'Christoph Hellwig'
2020-05-14 11:11           ` David Laight
2020-05-14 11:11             ` [Ocfs2-devel] " David Laight
2020-05-14 11:11             ` David Laight
2020-05-14 11:11             ` David Laight
2020-05-14 19:35             ` [Ocfs2-devel] " Matthew Wilcox
2020-05-14 19:35               ` Matthew Wilcox
2020-05-14 19:35               ` Matthew Wilcox
2020-05-14 19:35               ` Matthew Wilcox
2020-05-14 19:35               ` Matthew Wilcox
2020-05-14 20:03         ` David Miller
2020-05-14 20:03           ` [Ocfs2-devel] " David Miller
2020-05-14 20:03           ` David Miller
2020-05-14 20:03           ` David Miller
2020-05-14 20:03           ` David Miller
2020-05-15  8:14           ` David Laight
2020-05-15  8:14             ` [Ocfs2-devel] " David Laight
2020-05-15  8:14             ` David Laight
2020-05-15  8:14             ` David Laight
2020-05-15  8:14             ` David Laight
2020-05-14 19:57     ` David Miller
2020-05-14 19:57       ` [Ocfs2-devel] " David Miller
2020-05-14 19:57       ` David Miller
2020-05-14 19:57       ` David Miller
2020-05-14 19:57       ` David Miller
2020-05-13 18:45 ` Sagi Grimberg
2020-05-13 18:45   ` [Ocfs2-devel] " Sagi Grimberg
2020-05-13 18:45   ` Sagi Grimberg
2020-05-13 18:45   ` Sagi Grimberg
2020-05-13 19:12 ` David Miller
2020-05-13 19:12   ` [Ocfs2-devel] " David Miller
2020-05-13 19:12   ` David Miller
2020-05-13 19:12   ` David Miller
2020-05-20 19:54 remove kernel_setsockopt and kernel_getsockopt v2 Christoph Hellwig
2020-05-20 19:54 ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54 ` Christoph Hellwig
2020-05-20 19:54 ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 01/33] dlm: use the tcp version of accept_from_sock for sctp as well Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 02/33] net: remove kernel_getsockopt Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 03/33] net: add sock_set_reuseaddr Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 04/33] net: add sock_no_linger Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 05/33] net: add sock_set_priority Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 06/33] net: add sock_set_sndtimeo Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 07/33] net: add sock_bindtoindex Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 08/33] net: add sock_enable_timestamps Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 09/33] net: add sock_set_keepalive Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 10/33] net: add sock_set_rcvbuf Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 11/33] net: add sock_set_reuseport Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 12/33] tcp: add tcp_sock_set_cork Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 13/33] tcp: add tcp_sock_set_nodelay Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 14/33] tcp: add tcp_sock_set_quickack Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 15/33] tcp: add tcp_sock_set_syncnt Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 16/33] tcp: add tcp_sock_set_user_timeout Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 17/33] tcp: add tcp_sock_set_keepidle Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 18/33] tcp: add tcp_sock_set_keepintvl Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 19/33] tcp: add tcp_sock_set_keepcnt Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 20/33] ipv4: add ip_sock_set_tos Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 21/33] ipv4: add ip_sock_set_freebind Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 22/33] ipv4: add ip_sock_set_recverr Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54 ` [PATCH 23/33] ipv4: add ip_sock_set_mtu_discover Christoph Hellwig
2020-05-20 19:54   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:54   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 24/33] ipv4: add ip_sock_set_pktinfo Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 25/33] ipv6: add ip6_sock_set_v6only Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 26/33] ipv6: add ip6_sock_set_recverr Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 27/33] ipv6: add ip6_sock_set_addr_preferences Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 28/33] ipv6: add ip6_sock_set_recvpktinfo Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 29/33] rxrpc: add rxrpc_sock_set_min_security_level Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 30/33] tipc: call tsk_set_importance from tipc_topsrv_create_listener Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 31/33] sctp: add sctp_sock_set_nodelay Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 23:10   ` Marcelo Ricardo Leitner
2020-05-20 23:10     ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-20 23:10     ` Marcelo Ricardo Leitner
2020-05-20 23:10     ` Marcelo Ricardo Leitner
2020-05-20 23:10     ` Marcelo Ricardo Leitner
2020-05-20 23:23     ` David Miller
2020-05-20 23:23       ` [Ocfs2-devel] " David Miller
2020-05-20 23:23       ` David Miller
2020-05-20 23:23       ` David Miller
2020-05-20 23:39       ` Marcelo Ricardo Leitner
2020-05-20 23:39         ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-20 23:39         ` Marcelo Ricardo Leitner
2020-05-20 23:39         ` Marcelo Ricardo Leitner
2020-05-20 23:39         ` Marcelo Ricardo Leitner
2020-05-21  8:34         ` Christoph Hellwig
2020-05-21  8:34           ` [Ocfs2-devel] " Christoph Hellwig
2020-05-21  8:34           ` Christoph Hellwig
2020-05-21  8:34           ` Christoph Hellwig
2020-05-21  8:34           ` Christoph Hellwig
2020-05-21  9:06           ` David Laight
2020-05-21  9:06             ` [Ocfs2-devel] " David Laight
2020-05-21  9:06             ` David Laight
2020-05-21  9:06             ` David Laight
2020-05-21  9:06             ` David Laight
2020-05-21  9:08             ` 'Christoph Hellwig'
2020-05-21  9:08               ` [Ocfs2-devel] " 'Christoph Hellwig'
2020-05-21  9:08               ` 'Christoph Hellwig'
2020-05-21  9:08               ` 'Christoph Hellwig'
2020-05-21  9:08               ` 'Christoph Hellwig'
2020-05-21  9:08               ` 'Christoph Hellwig'
2020-05-21 13:33           ` Marcelo Ricardo Leitner
2020-05-21 13:33             ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-21 13:33             ` Marcelo Ricardo Leitner
2020-05-21 13:33             ` Marcelo Ricardo Leitner
2020-05-21 13:33             ` Marcelo Ricardo Leitner
2020-05-21 13:57             ` Christoph Hellwig
2020-05-21 13:57               ` [Ocfs2-devel] " Christoph Hellwig
2020-05-21 13:57               ` Christoph Hellwig
2020-05-21 13:57               ` Christoph Hellwig
2020-05-21 13:57               ` Christoph Hellwig
2020-05-20 19:55 ` [PATCH 32/33] net: add a new bind_add method Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 23:00   ` Marcelo Ricardo Leitner
2020-05-20 23:00     ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-20 23:00     ` Marcelo Ricardo Leitner
2020-05-20 23:00     ` Marcelo Ricardo Leitner
2020-05-21  8:42     ` Christoph Hellwig
2020-05-21  8:42       ` [Ocfs2-devel] " Christoph Hellwig
2020-05-21  8:42       ` Christoph Hellwig
2020-05-21  8:42       ` Christoph Hellwig
2020-05-21  8:42       ` Christoph Hellwig
2020-05-21 13:54       ` Marcelo Ricardo Leitner
2020-05-21 13:54         ` [Ocfs2-devel] " Marcelo Ricardo Leitner
2020-05-21 13:54         ` Marcelo Ricardo Leitner
2020-05-21 13:54         ` Marcelo Ricardo Leitner
2020-05-20 19:55 ` [PATCH 33/33] net: remove kernel_setsockopt Christoph Hellwig
2020-05-20 19:55   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-20 19:55   ` Christoph Hellwig
2020-05-21  7:44 ` [PATCH 29/33] rxrpc: add rxrpc_sock_set_min_security_level David Howells
2020-05-21  7:44   ` [Ocfs2-devel] " David Howells
2020-05-21  7:44   ` David Howells
2020-05-21  7:44   ` David Howells
2020-05-21  7:44   ` David Howells
2020-05-21  8:01 ` remove kernel_setsockopt and kernel_getsockopt v2 David Laight
2020-05-21  8:01   ` [Ocfs2-devel] " David Laight
2020-05-21  8:01   ` David Laight
2020-05-21  8:01   ` David Laight
2020-05-21  9:11   ` 'Christoph Hellwig'
2020-05-21  9:11     ` [Ocfs2-devel] " 'Christoph Hellwig'
2020-05-21  9:11     ` 'Christoph Hellwig'
2020-05-21  9:11     ` 'Christoph Hellwig'
2020-05-21  9:11     ` 'Christoph Hellwig'
2020-05-21 10:46     ` David Laight
2020-05-21 10:46       ` [Ocfs2-devel] " David Laight
2020-05-21 10:46       ` David Laight
2020-05-21 10:46       ` David Laight
2020-05-21 10:46       ` David Laight
2020-05-23  7:23 ` Christoph Hellwig
2020-05-23  7:23   ` [Ocfs2-devel] " Christoph Hellwig
2020-05-23  7:23   ` Christoph Hellwig
2020-05-23  7:23   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513062649.2100053-11-hch@lst.de \
    --to=hch@lst.de \
    --cc=ceph-devel@vger.kernel.org \
    --cc=cluster-devel@redhat.com \
    --cc=davem@davemloft.net \
    --cc=drbd-dev@lists.linbit.com \
    --cc=edumazet@google.com \
    --cc=jmaloy@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=target-devel@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    --cc=ying.xue@windriver.com \
    --cc=yoshfuji@linux-ipv6.org \
    --subject='Re: [PATCH 10/33] tcp: add tcp_sock_set_cork' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.