All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wfx: typo fix
@ 2020-05-13  7:24 ` Mohamed Dawod
  0 siblings, 0 replies; 4+ messages in thread
From: Mohamed Dawod @ 2020-05-13  7:24 UTC (permalink / raw)
  To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel

fixing some typo errors in traces.h file

Signed-off-by: Mohamed Dawod <mhm.dawod@gmail.com>
---
 drivers/staging/wfx/traces.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h
index bb9f7e9..80e131c 100644
--- a/drivers/staging/wfx/traces.h
+++ b/drivers/staging/wfx/traces.h
@@ -32,16 +32,16 @@
  *             xxx_name(XXX)       \
  *             ...
  *
- *   3. Instanciate that list_names:
+ *   3. Instantiate that list_names:
  *
  *          list_names
  *
- *   4. Redefine xxx_name() as a entry of array for __print_symbolic()
+ *   4. Redefine xxx_name() as an entry of array for __print_symbolic()
  *
  *          #undef xxx_name
  *          #define xxx_name(msg) { msg, #msg },
  *
- *   5. list_name can now nearlu be used with __print_symbolic() but,
+ *   5. list_name can now nearly be used with __print_symbolic() but,
  *      __print_symbolic() dislike last comma of list. So we define a new list
  *      with a dummy element:
  *
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] wfx: typo fix
@ 2020-05-13  7:24 ` Mohamed Dawod
  0 siblings, 0 replies; 4+ messages in thread
From: Mohamed Dawod @ 2020-05-13  7:24 UTC (permalink / raw)
  To: Jérôme Pouiller, Greg Kroah-Hartman, devel, linux-kernel

fixing some typo errors in traces.h file

Signed-off-by: Mohamed Dawod <mhm.dawod@gmail.com>
---
 drivers/staging/wfx/traces.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h
index bb9f7e9..80e131c 100644
--- a/drivers/staging/wfx/traces.h
+++ b/drivers/staging/wfx/traces.h
@@ -32,16 +32,16 @@
  *             xxx_name(XXX)       \
  *             ...
  *
- *   3. Instanciate that list_names:
+ *   3. Instantiate that list_names:
  *
  *          list_names
  *
- *   4. Redefine xxx_name() as a entry of array for __print_symbolic()
+ *   4. Redefine xxx_name() as an entry of array for __print_symbolic()
  *
  *          #undef xxx_name
  *          #define xxx_name(msg) { msg, #msg },
  *
- *   5. list_name can now nearlu be used with __print_symbolic() but,
+ *   5. list_name can now nearly be used with __print_symbolic() but,
  *      __print_symbolic() dislike last comma of list. So we define a new list
  *      with a dummy element:
  *
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] wfx: typo fix
  2020-05-13  7:24 ` Mohamed Dawod
@ 2020-05-13 18:02   ` Jérôme Pouiller
  -1 siblings, 0 replies; 4+ messages in thread
From: Jérôme Pouiller @ 2020-05-13 18:02 UTC (permalink / raw)
  To: Mohamed Dawod; +Cc: Greg Kroah-Hartman, devel, linux-kernel

Hello,

On Wednesday 13 May 2020 09:24:33 CEST Mohamed Dawod wrote:
> 
> fixing some typo errors in traces.h file
> 
> Signed-off-by: Mohamed Dawod <mhm.dawod@gmail.com>
> ---
>  drivers/staging/wfx/traces.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

It would be great if the subject started with "staging: wfx: " (as
the other patches of this directory).

Else, I like when commit messages start with a capital letter, but it is not big
deal.


> diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h
> index bb9f7e9..80e131c 100644
> --- a/drivers/staging/wfx/traces.h
> +++ b/drivers/staging/wfx/traces.h
> @@ -32,16 +32,16 @@
>   *             xxx_name(XXX)       \
>   *             ...
>   *
> - *   3. Instanciate that list_names:
> + *   3. Instantiate that list_names:
>   *
>   *          list_names
>   *
> - *   4. Redefine xxx_name() as a entry of array for __print_symbolic()
> + *   4. Redefine xxx_name() as an entry of array for __print_symbolic()
>   *
>   *          #undef xxx_name
>   *          #define xxx_name(msg) { msg, #msg },
>   *
> - *   5. list_name can now nearlu be used with __print_symbolic() but,
> + *   5. list_name can now nearly be used with __print_symbolic() but,
>   *      __print_symbolic() dislike last comma of list. So we define a new list
>   *      with a dummy element:

Ok.


Thank you for your contribution.

-- 
Jérôme Pouiller



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] wfx: typo fix
@ 2020-05-13 18:02   ` Jérôme Pouiller
  0 siblings, 0 replies; 4+ messages in thread
From: Jérôme Pouiller @ 2020-05-13 18:02 UTC (permalink / raw)
  To: Mohamed Dawod; +Cc: devel, Greg Kroah-Hartman, linux-kernel

Hello,

On Wednesday 13 May 2020 09:24:33 CEST Mohamed Dawod wrote:
> 
> fixing some typo errors in traces.h file
> 
> Signed-off-by: Mohamed Dawod <mhm.dawod@gmail.com>
> ---
>  drivers/staging/wfx/traces.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

It would be great if the subject started with "staging: wfx: " (as
the other patches of this directory).

Else, I like when commit messages start with a capital letter, but it is not big
deal.


> diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h
> index bb9f7e9..80e131c 100644
> --- a/drivers/staging/wfx/traces.h
> +++ b/drivers/staging/wfx/traces.h
> @@ -32,16 +32,16 @@
>   *             xxx_name(XXX)       \
>   *             ...
>   *
> - *   3. Instanciate that list_names:
> + *   3. Instantiate that list_names:
>   *
>   *          list_names
>   *
> - *   4. Redefine xxx_name() as a entry of array for __print_symbolic()
> + *   4. Redefine xxx_name() as an entry of array for __print_symbolic()
>   *
>   *          #undef xxx_name
>   *          #define xxx_name(msg) { msg, #msg },
>   *
> - *   5. list_name can now nearlu be used with __print_symbolic() but,
> + *   5. list_name can now nearly be used with __print_symbolic() but,
>   *      __print_symbolic() dislike last comma of list. So we define a new list
>   *      with a dummy element:

Ok.


Thank you for your contribution.

-- 
Jérôme Pouiller


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-13 18:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13  7:24 [PATCH] wfx: typo fix Mohamed Dawod
2020-05-13  7:24 ` Mohamed Dawod
2020-05-13 18:02 ` Jérôme Pouiller
2020-05-13 18:02   ` Jérôme Pouiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.