From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B99CA90AF for ; Wed, 13 May 2020 08:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8171D20740 for ; Wed, 13 May 2020 08:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730781AbgEMI5z (ORCPT ); Wed, 13 May 2020 04:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730237AbgEMI5z (ORCPT ); Wed, 13 May 2020 04:57:55 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA100C061A0C for ; Wed, 13 May 2020 01:57:54 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id A439D379; Wed, 13 May 2020 10:57:53 +0200 (CEST) Date: Wed, 13 May 2020 10:57:52 +0200 From: Joerg Roedel To: YueHaibing Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' Message-ID: <20200513085752.GF9820@8bytes.org> References: <20200508134036.116569-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508134036.116569-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 01:40:36PM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device': > drivers/iommu/amd_iommu.c:422:20: warning: > variable 'iommu' set but not used [-Wunused-but-set-variable] > > commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs") > involved this, remove it. > > Signed-off-by: YueHaibing > --- > drivers/iommu/amd_iommu.c | 3 --- > 1 file changed, 3 deletions(-) Thanks for the patch, but I already applied https://lore.kernel.org/r/20200509015645.3236-1-cai@lca.pw Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Wed, 13 May 2020 08:57:52 +0000 Subject: Re: [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' Message-Id: <20200513085752.GF9820@8bytes.org> List-Id: References: <20200508134036.116569-1-yuehaibing@huawei.com> In-Reply-To: <20200508134036.116569-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 01:40:36PM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device': > drivers/iommu/amd_iommu.c:422:20: warning: > variable 'iommu' set but not used [-Wunused-but-set-variable] > > commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs") > involved this, remove it. > > Signed-off-by: YueHaibing > --- > drivers/iommu/amd_iommu.c | 3 --- > 1 file changed, 3 deletions(-) Thanks for the patch, but I already applied https://lore.kernel.org/r/20200509015645.3236-1-cai@lca.pw Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E40CA90AF for ; Wed, 13 May 2020 08:58:00 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8182C206F5 for ; Wed, 13 May 2020 08:57:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8182C206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 424EC88158; Wed, 13 May 2020 08:57:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fk9pq+7Kacw0; Wed, 13 May 2020 08:57:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 149F888600; Wed, 13 May 2020 08:57:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id ED7B8C088B; Wed, 13 May 2020 08:57:56 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id CE9B3C016F for ; Wed, 13 May 2020 08:57:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id CAE6688600 for ; Wed, 13 May 2020 08:57:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nTgy3QvR8n5U for ; Wed, 13 May 2020 08:57:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by hemlock.osuosl.org (Postfix) with ESMTPS id 4575F88158 for ; Wed, 13 May 2020 08:57:55 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id A439D379; Wed, 13 May 2020 10:57:53 +0200 (CEST) Date: Wed, 13 May 2020 10:57:52 +0200 From: Joerg Roedel To: YueHaibing Subject: Re: [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' Message-ID: <20200513085752.GF9820@8bytes.org> References: <20200508134036.116569-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200508134036.116569-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, May 08, 2020 at 01:40:36PM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device': > drivers/iommu/amd_iommu.c:422:20: warning: > variable 'iommu' set but not used [-Wunused-but-set-variable] > > commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs") > involved this, remove it. > > Signed-off-by: YueHaibing > --- > drivers/iommu/amd_iommu.c | 3 --- > 1 file changed, 3 deletions(-) Thanks for the patch, but I already applied https://lore.kernel.org/r/20200509015645.3236-1-cai@lca.pw Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu