All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Samuel Zou <zou_wei@huawei.com>, Arnd Bergmann <arnd@arndb.de>
Cc: jun.nie@linaro.org, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static
Date: Wed, 13 May 2020 17:02:14 +0800	[thread overview]
Message-ID: <20200513090213.GH26997@dragon> (raw)
In-Reply-To: <1589250561-106088-1-git-send-email-zou_wei@huawei.com>

On Tue, May 12, 2020 at 10:29:21AM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
> 
> arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared.
> 
> The zx_smp_prepare_cpus has only call site within platsmp.c
> It should be static
> 
> Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

Hi Arnd,

Can you please apply it to arm-soc tree?

Shawn

> ---
>  arch/arm/mach-zx/platsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
> index d4e1d37..43a33ea 100644
> --- a/arch/arm/mach-zx/platsmp.c
> +++ b/arch/arm/mach-zx/platsmp.c
> @@ -38,7 +38,7 @@ static void __iomem *pcu_base;
>  static void __iomem *matrix_base;
>  static void __iomem *scu_base;
>  
> -void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> +static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
>  {
>  	struct device_node *np;
>  	unsigned long base = 0;
> -- 
> 2.6.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Samuel Zou <zou_wei@huawei.com>, Arnd Bergmann <arnd@arndb.de>
Cc: jun.nie@linaro.org, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static
Date: Wed, 13 May 2020 17:02:14 +0800	[thread overview]
Message-ID: <20200513090213.GH26997@dragon> (raw)
In-Reply-To: <1589250561-106088-1-git-send-email-zou_wei@huawei.com>

On Tue, May 12, 2020 at 10:29:21AM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
> 
> arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared.
> 
> The zx_smp_prepare_cpus has only call site within platsmp.c
> It should be static
> 
> Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

Hi Arnd,

Can you please apply it to arm-soc tree?

Shawn

> ---
>  arch/arm/mach-zx/platsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
> index d4e1d37..43a33ea 100644
> --- a/arch/arm/mach-zx/platsmp.c
> +++ b/arch/arm/mach-zx/platsmp.c
> @@ -38,7 +38,7 @@ static void __iomem *pcu_base;
>  static void __iomem *matrix_base;
>  static void __iomem *scu_base;
>  
> -void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> +static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
>  {
>  	struct device_node *np;
>  	unsigned long base = 0;
> -- 
> 2.6.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-13  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  2:29 [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static Samuel Zou
2020-05-12  2:29 ` Samuel Zou
2020-05-13  9:02 ` Shawn Guo [this message]
2020-05-13  9:02   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513090213.GH26997@dragon \
    --to=shawnguo@kernel.org \
    --cc=arnd@arndb.de \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.