From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83DBCA90AF for ; Wed, 13 May 2020 09:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C503206F5 for ; Wed, 13 May 2020 09:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363251; bh=it4MXvD7wsUapLucndD0KmgfZPzzRfttDw+0MIB6A7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JIu2aT7gUVRKBXMIxWFev1iIN4/IqYPggopwEZT7VBtw+SLWgE6HYJrNvxCyxRQj1 Yj+VD9Tw6yOCD+EdOGgN/TtE78vQ2+ZHjArEe2e6HXlPgiYPFZGTnlJUuGcaZHbeY3 HQgzfHiezkWewLI2z4fClH/Bst9cvRnFmHLeO+BE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732870AbgEMJra (ORCPT ); Wed, 13 May 2020 05:47:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732832AbgEMJrU (ORCPT ); Wed, 13 May 2020 05:47:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73733206F5; Wed, 13 May 2020 09:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363239; bh=it4MXvD7wsUapLucndD0KmgfZPzzRfttDw+0MIB6A7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uN0fQsUxe0o9X6BLH52ow12MKUFpAaNW88smvh1divmdnqft05Z/sTFA0puNuQ2t5 qNY3l5Hv9i3vU01Pv7LY1LfSEX99r58X+Is4+tjT+9OMOuzcnVafu4nHkS6g0Q2B4n 6SFmLaDtHhRZrCc4bis+d34d1OWULA8Y8Ar0BVS4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miroslav Benes , Josh Poimboeuf , Ingo Molnar , Andy Lutomirski , Dave Jones , Jann Horn , Peter Zijlstra , Thomas Gleixner , Vince Weaver Subject: [PATCH 4.19 42/48] x86/unwind/orc: Fix error path for bad ORC entry type Date: Wed, 13 May 2020 11:45:08 +0200 Message-Id: <20200513094403.163887114@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513094351.100352960@linuxfoundation.org> References: <20200513094351.100352960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Poimboeuf commit a0f81bf26888048100bf017fadf438a5bdffa8d8 upstream. If the ORC entry type is unknown, nothing else can be done other than reporting an error. Exit the function instead of breaking out of the switch statement. Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder") Reviewed-by: Miroslav Benes Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Andy Lutomirski Cc: Dave Jones Cc: Jann Horn Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Vince Weaver Link: https://lore.kernel.org/r/a7fa668ca6eabbe81ab18b2424f15adbbfdc810a.1587808742.git.jpoimboe@redhat.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/unwind_orc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kernel/unwind_orc.c +++ b/arch/x86/kernel/unwind_orc.c @@ -509,7 +509,7 @@ bool unwind_next_frame(struct unwind_sta default: orc_warn("unknown .orc_unwind entry type %d for ip %pB\n", orc->type, (void *)orig_ip); - break; + goto err; } /* Find BP: */