From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB07ECA90AF for ; Wed, 13 May 2020 10:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD509206D6 for ; Wed, 13 May 2020 10:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UJ9815NK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387878AbgEMKFA (ORCPT ); Wed, 13 May 2020 06:05:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732876AbgEMKE7 (ORCPT ); Wed, 13 May 2020 06:04:59 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61156C061A0C for ; Wed, 13 May 2020 03:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P+GDGr63i/GryzyacVzElgV97xC2KafWFYRcNg053vk=; b=UJ9815NK5Yy1i4frFJwhd9a+FY JR5xp84mw8k8pNE8FfcsDW1OMVf1VkIlTv48oHAa4wiJaYXVI14+sZbdRe1WwUJj+3PPwVjyHK8qp dxkzxG2jNmI8c7FDnXUbUId1Q4g1Z25mIoKe9Umrrh7H1b6V5LPqfqWD1Tw4DhuljJ6VCJu1Sti3y oHCMjoCZP2XhrzBFNaa8lmN3VRt4C4A9+ZZibXdhAn04QNG0rZpYAP9D8yXm7F//z9gcu3kzP+zoQ WwYWRnItDLRIoR1vD71AsyWUWweBSt7yZz3uQeSH8tRl9DTFW6Fxr8NHB7Rrn1TlPgJYJ8xckfg/x 4LUX21aA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYoG1-00037G-VU; Wed, 13 May 2020 10:04:57 +0000 Date: Wed, 13 May 2020 03:04:57 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: Al Viro , linux-fsdevel@vger.kernel.org, David Howells Subject: Re: [PATCH 07/12] statx: don't clear STATX_ATIME on SB_RDONLY Message-ID: <20200513100457.GE7720@infradead.org> References: <20200505095915.11275-1-mszeredi@redhat.com> <20200505095915.11275-8-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505095915.11275-8-mszeredi@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 05, 2020 at 11:59:10AM +0200, Miklos Szeredi wrote: > IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so > generic_fillattr() will clear STATX_ATIME from the result_mask if the super > block is marked read only. > > This was probably not the intention, so fix to only clear STATX_ATIME if > the fs doesn't support atime at all. > > Signed-off-by: Miklos Szeredi > Acked-by: David Howells Looks good, Reviewed-by: Christoph Hellwig