From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EA3CA90AF for ; Wed, 13 May 2020 10:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44246206D6 for ; Wed, 13 May 2020 10:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cPbHACTN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732723AbgEMKHE (ORCPT ); Wed, 13 May 2020 06:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730822AbgEMKHE (ORCPT ); Wed, 13 May 2020 06:07:04 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7112CC061A0C for ; Wed, 13 May 2020 03:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fN1EnHGWA4UlJEscV/scLIoLJvsXQCDXyBN2NQ9jNno=; b=cPbHACTN/NoaT2Rxnzm/z362zx rO9UN+CT4XI4e61RFoO0jyzVTjT32nz1ToA8B/o2ji3Xn5bUAyE1Bq3MrBC77qCk6Y2cnZDPhZtJD oLGSNHgLkM8X+5a+yQInhksLh1yxCA08gBubmTvETEnJYDIRWUZlUXOgh73OO5Dl3PNTERqrrpiX2 dpFqtH1YlwAXwcwxn/SZyXWWIB0NAaazqnrZ3APnsj6MBqDZqi0JaeLQZv+oKMq9rlhj6iFNdM0Iy Kor2RbE5CEQtpsNCTAfsbifxupbaJg5Kv8/qhFZNZscryDpxPOy+UQQz1ouSwTUUsQO+++OLss2Hb uiEmhznQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYoI2-0005hG-Mz; Wed, 13 May 2020 10:07:02 +0000 Date: Wed, 13 May 2020 03:07:02 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: Al Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 11/12] vfs: don't parse "posixacl" option Message-ID: <20200513100702.GI7720@infradead.org> References: <20200505095915.11275-1-mszeredi@redhat.com> <20200505095915.11275-12-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505095915.11275-12-mszeredi@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 05, 2020 at 11:59:14AM +0200, Miklos Szeredi wrote: > Unlike the others, this is _not_ a standard option accepted by mount(8). > > In fact SB_POSIXACL is an internal flag, and accepting MS_POSIXACL on the > mount(2) interface is possibly a bug. > > The only filesystem that apparently wants to handle the "posixacl" option > is 9p, but it has special handling of that option besides setting > SB_POSIXACL. Looks good: Reviewed-by: Christoph Hellwig