From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=mPjQ=63=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 501D4CA90AF
	for <linux-fsdevel@archiver.kernel.org>; Wed, 13 May 2020 10:09:53 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2D2E0206B8
	for <linux-fsdevel@archiver.kernel.org>; Wed, 13 May 2020 10:09:53 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qASbPmyE"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732545AbgEMKJw (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Wed, 13 May 2020 06:09:52 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52388 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729917AbgEMKJw (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 13 May 2020 06:09:52 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7881BC061A0C
        for <linux-fsdevel@vger.kernel.org>; Wed, 13 May 2020 03:09:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=v2SXhXVatlB7a+b3FDUeckFCgAFekDkvjA6oOG3RO+c=; b=qASbPmyEp7Nq1BJ9mUmLifN/tb
        jeCQSaGh2hXE5zEDa3gyFHBBaaIFjmpMS8wl6314ah0AOdviyIr5pHyDCy2j/hb748CAFf09wMdXu
        Mpr1oMQ9ubBvOMNN5YjoQnQNoyScUIdL/3MnhHVMNcRWcAEKSo6J3YrKIm1w3r0XaxTbXol5N+0or
        il/KUI621X4K1eXla6Pxv4f2x55QOn+rWm3DOhQcahiPdhr8Zd31haPPoTrLNJLpgPtxmFniEXkOZ
        3W5PPDrrwIQChWhSpWD+bwMSz/ka8anmURuqYVFwMUgRxM13lEylullREddRxTeFxqDQ7BW8GkzP0
        LWJeJKCQ==;
Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jYoKk-000644-Oj; Wed, 13 May 2020 10:09:50 +0000
Date:   Wed, 13 May 2020 03:09:50 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Miklos Szeredi <mszeredi@redhat.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Subject: Re: [13/12 PATCH] vfs: add faccessat2 syscall
Message-ID: <20200513100950.GK7720@infradead.org>
References: <20200505095915.11275-1-mszeredi@redhat.com>
 <20200513074537.1617-1-mszeredi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200513074537.1617-1-mszeredi@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

Needs a Cc to linux-api and linux-man.

Can you split the access_override_creds refactor into a separate prep
patch?  Also please drop the pointless externs for functions prototypes
in headers while you're at it.

Otherwise this looks sane to me.