From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674B2CA90AF for ; Wed, 13 May 2020 10:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4556B206CC for ; Wed, 13 May 2020 10:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732416AbgEMKaa (ORCPT ); Wed, 13 May 2020 06:30:30 -0400 Received: from foss.arm.com ([217.140.110.172]:42566 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729731AbgEMKaa (ORCPT ); Wed, 13 May 2020 06:30:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFAF41FB; Wed, 13 May 2020 03:30:29 -0700 (PDT) Received: from donnerap.arm.com (donnerap.cambridge.arm.com [10.1.197.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A5BE3F305; Wed, 13 May 2020 03:30:28 -0700 (PDT) From: Andre Przywara To: Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier Subject: [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Wed, 13 May 2020 11:29:56 +0100 Message-Id: <20200513103016.130417-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.17.1 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org A few updates compared to v2. The most important is to fix the interrupt-maps, triggered by changing the number of address-cells in the GIC node. For this I split the former patch 07/17 into two (09/20 and 10/20), one for the foundation model, the other for Juno. Also I fixed a dtc complaint about device nodes without reg properties being inside simple-bus nodes, those are the new patches 04-06/20. Will took patch 01/17 from v2 already, so I removed this from this series. The rest of the patches stayed the same. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first and the last two patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check and dtc itself reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v2 ... v3: - drop patch v2 01/17, Will took that already - also move fixed devices for vexpress, foundation and Juno (04-06/20) - use "arm,gic-400" in addition to the "Cortex GIC" for the models - adjust all interrupt-map properties to reflect GIC #address-cells changes Changelog v1 ... v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (20): dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: fvp: Move fixed devices out of bus node arm64: dts: arm: vexpress: Move fixed devices out of bus node arm64: dts: arm: foundation: Move fixed clocks out of bus node arm64: dts: arm: juno: Move fixed devices out of bus node arm64: dts: juno: Fix mem-timer arm64: dts: arm: model: Fix GIC compatible names arm64: dts: arm: juno: Fix GIC child nodes arm64: dts: arm: foundation: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 328 +++++++++--------- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 11 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 142 ++++---- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 82 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 166 ++++----- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 ++++---- 14 files changed, 465 insertions(+), 450 deletions(-) -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780AAC2D0FA for ; Wed, 13 May 2020 10:30:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44CD6206E5 for ; Wed, 13 May 2020 10:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Kv/+8J1m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44CD6206E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=GXkrPjLeVIRuHEGhhAnh54YzsjwFXbhWY8X4wHsv+mc=; b=Kv/ +8J1mjas/RyxI/uehLLuPY1QvnyNQDZi4i+O0dHbE4dsmtkGef2nFQwRW5DUI0C65HqW9Lac4uYUG xAUSGG3atG9zNKR1LBZwJvYnB+hqvKOZHGJc31BC5R71xBO8GQTxxNRh7FRwNatw+eJ6pCFtESH+g wQSLxeomnqGZZXsqTqxeot5rq0uk/9prT2OfqP+IRDpYpk6RZmIdndtWCYOsvPOIDRYmV0792fDhl PqqGFOr7/etFxfEGJgQLwOEla8t9u0zAj07DDhDtK7mHg7Jm75CflNGznAEt61iTH1EHwFO4P92Nl qABdmL7gX+E8q3GVExuuC4HjUayPhUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYoep-0005H8-KL; Wed, 13 May 2020 10:30:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYoel-0005Fa-TF for linux-arm-kernel@lists.infradead.org; Wed, 13 May 2020 10:30:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFAF41FB; Wed, 13 May 2020 03:30:29 -0700 (PDT) Received: from donnerap.arm.com (donnerap.cambridge.arm.com [10.1.197.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A5BE3F305; Wed, 13 May 2020 03:30:28 -0700 (PDT) From: Andre Przywara To: Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Subject: [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Wed, 13 May 2020 11:29:56 +0100 Message-Id: <20200513103016.130417-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_033032_036184_49B57451 X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org A few updates compared to v2. The most important is to fix the interrupt-maps, triggered by changing the number of address-cells in the GIC node. For this I split the former patch 07/17 into two (09/20 and 10/20), one for the foundation model, the other for Juno. Also I fixed a dtc complaint about device nodes without reg properties being inside simple-bus nodes, those are the new patches 04-06/20. Will took patch 01/17 from v2 already, so I removed this from this series. The rest of the patches stayed the same. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first and the last two patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check and dtc itself reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v2 ... v3: - drop patch v2 01/17, Will took that already - also move fixed devices for vexpress, foundation and Juno (04-06/20) - use "arm,gic-400" in addition to the "Cortex GIC" for the models - adjust all interrupt-map properties to reflect GIC #address-cells changes Changelog v1 ... v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (20): dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: fvp: Move fixed devices out of bus node arm64: dts: arm: vexpress: Move fixed devices out of bus node arm64: dts: arm: foundation: Move fixed clocks out of bus node arm64: dts: arm: juno: Move fixed devices out of bus node arm64: dts: juno: Fix mem-timer arm64: dts: arm: model: Fix GIC compatible names arm64: dts: arm: juno: Fix GIC child nodes arm64: dts: arm: foundation: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 328 +++++++++--------- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 11 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 142 ++++---- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 82 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 166 ++++----- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 ++++---- 14 files changed, 465 insertions(+), 450 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel