From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73250CA90AF for ; Wed, 13 May 2020 11:10:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4680620753 for ; Wed, 13 May 2020 11:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgEMLKB (ORCPT ); Wed, 13 May 2020 07:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbgEMLKB (ORCPT ); Wed, 13 May 2020 07:10:01 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73930C061A0C for ; Wed, 13 May 2020 04:10:01 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id 1B6D92A0521 Date: Wed, 13 May 2020 13:09:57 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Laurent Pinchart Cc: Tomi Valkeinen , robh+dt@kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml Message-ID: <20200513110957.dgb3axle24pmqp3a@rcn-XPS-13-9360> Mail-Followup-To: Laurent Pinchart , Tomi Valkeinen , robh+dt@kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net References: <20200428092048.14939-1-ricardo.canuelo@collabora.com> <3e377c73-25a3-a7b3-0604-41c54d70039e@ti.com> <20200506155320.GC15206@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200506155320.GC15206@pendragon.ideasonboard.com> User-Agent: NeoMutt/20171215 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On mié 06-05-2020 18:53:20, Laurent Pinchart wrote: > I didn't if I remember correctly, I just mapped it to the hardware > features. The hardware register indeed takes a value between 0 and 7, > and that is mapped to [-4,3] x t(STEP). I don't mind either option. I was taking a look at the ti-tfp410.c driver to see if it needs any changes to support the updated deskew property ranges [0-7], but I don't fully understand what this does (line 276): /* Get the setup and hold time from vendor-specific properties. */ of_property_read_u32(dvi->dev->of_node, "ti,deskew", (u32 *)&deskew); if (deskew < -4 || deskew > 3) return -EINVAL; timings->setup_time_ps = min(0, 1200 - 350 * deskew); timings->hold_time_ps = min(0, 1300 + 350 * deskew); It looks like that the driver doesn't really apply the deskew settings to the device and that this has not been really tested, so it's probably not a big deal. I guess what you wanted to do was to adjust the setup and hold times around 1200 and 1300 ps respectively in increments/decrements of 350 ps depending on the deskew value, as the datasheet describes. But this code would set timings->setup_time_ps to 0 regardless of the deskew value, and timings->hold_time_ps would be either 0 or a very big integer value if deskew is -4 (both setup_time_ps and hold_time_ps are u32). Am I missing something? Was this intentional? Thanks, Ricardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD597CA90AF for ; Wed, 13 May 2020 11:10:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E3E720740 for ; Wed, 13 May 2020 11:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N7aM2Rdp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E3E720740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Y602L8BO7w9Dn70klqcC1dSK+62ebt88wqjboImj/w=; b=N7aM2RdpbFbAfb 2OyM/Dz6/chhntffp78ppb8v6WQNGHLVeotMTqQfKW076djl+Rl+pDMhO9SbDLDWMZ6MtoTyrQxh5 VbBo55MnhLtL+z5LG5HYtp4EAyUZkS4haD95ehUIssLIEW7/1xlZwrd7PJoeJraipuYXBlxIp0Zdt VLl8pv7Pdmq7XZ8i8gv0gGeUfdfO9X87Is1o23DFSrjn1f0cwmw5q6tjMPEaFFcKfxbjBikIe/td8 TEDQ805kbi9kyhHj+aRpgrcaX6O4o7aSCaL0pEOQ6kx0RwldoekrT56nLIqwjx7A6Im5KFsnOtm62 LyaoHs3mxqbXR+OF4GVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYpH6-00034L-G7; Wed, 13 May 2020 11:10:08 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYpH2-0001m0-9D for linux-arm-kernel@lists.infradead.org; Wed, 13 May 2020 11:10:06 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id 1B6D92A0521 Date: Wed, 13 May 2020 13:09:57 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Laurent Pinchart Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml Message-ID: <20200513110957.dgb3axle24pmqp3a@rcn-XPS-13-9360> Mail-Followup-To: Laurent Pinchart , Tomi Valkeinen , robh+dt@kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net References: <20200428092048.14939-1-ricardo.canuelo@collabora.com> <3e377c73-25a3-a7b3-0604-41c54d70039e@ti.com> <20200506155320.GC15206@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506155320.GC15206@pendragon.ideasonboard.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_041004_462521_10859B90 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, Tomi Valkeinen , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGF1cmVudCwKCk9uIG1pw6kgMDYtMDUtMjAyMCAxODo1MzoyMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBJIGRpZG4ndCBpZiBJIHJlbWVtYmVyIGNvcnJlY3RseSwgSSBqdXN0IG1hcHBl ZCBpdCB0byB0aGUgaGFyZHdhcmUKPiBmZWF0dXJlcy4gVGhlIGhhcmR3YXJlIHJlZ2lzdGVyIGlu ZGVlZCB0YWtlcyBhIHZhbHVlIGJldHdlZW4gMCBhbmQgNywKPiBhbmQgdGhhdCBpcyBtYXBwZWQg dG8gWy00LDNdIHggdChTVEVQKS4gSSBkb24ndCBtaW5kIGVpdGhlciBvcHRpb24uCgpJIHdhcyB0 YWtpbmcgYSBsb29rIGF0IHRoZSB0aS10ZnA0MTAuYyBkcml2ZXIgdG8gc2VlIGlmIGl0IG5lZWRz IGFueQpjaGFuZ2VzIHRvIHN1cHBvcnQgdGhlIHVwZGF0ZWQgZGVza2V3IHByb3BlcnR5IHJhbmdl cyBbMC03XSwgYnV0IEkgZG9uJ3QKZnVsbHkgdW5kZXJzdGFuZCB3aGF0IHRoaXMgZG9lcyAobGlu ZSAyNzYpOgoKCS8qIEdldCB0aGUgc2V0dXAgYW5kIGhvbGQgdGltZSBmcm9tIHZlbmRvci1zcGVj aWZpYyBwcm9wZXJ0aWVzLiAqLwoJb2ZfcHJvcGVydHlfcmVhZF91MzIoZHZpLT5kZXYtPm9mX25v ZGUsICJ0aSxkZXNrZXciLCAodTMyICopJmRlc2tldyk7CglpZiAoZGVza2V3IDwgLTQgfHwgZGVz a2V3ID4gMykKCQlyZXR1cm4gLUVJTlZBTDsKCgl0aW1pbmdzLT5zZXR1cF90aW1lX3BzID0gbWlu KDAsIDEyMDAgLSAzNTAgKiBkZXNrZXcpOwoJdGltaW5ncy0+aG9sZF90aW1lX3BzID0gbWluKDAs IDEzMDAgKyAzNTAgKiBkZXNrZXcpOwoKSXQgbG9va3MgbGlrZSB0aGF0IHRoZSBkcml2ZXIgZG9l c24ndCByZWFsbHkgYXBwbHkgdGhlIGRlc2tldyBzZXR0aW5ncwp0byB0aGUgZGV2aWNlIGFuZCB0 aGF0IHRoaXMgaGFzIG5vdCBiZWVuIHJlYWxseSB0ZXN0ZWQsIHNvIGl0J3MgcHJvYmFibHkKbm90 IGEgYmlnIGRlYWwuCgpJIGd1ZXNzIHdoYXQgeW91IHdhbnRlZCB0byBkbyB3YXMgdG8gYWRqdXN0 IHRoZSBzZXR1cCBhbmQgaG9sZCB0aW1lcwphcm91bmQgMTIwMCBhbmQgMTMwMCBwcyByZXNwZWN0 aXZlbHkgaW4gaW5jcmVtZW50cy9kZWNyZW1lbnRzIG9mIDM1MCBwcwpkZXBlbmRpbmcgb24gdGhl IGRlc2tldyB2YWx1ZSwgYXMgdGhlIGRhdGFzaGVldCBkZXNjcmliZXMuIEJ1dCB0aGlzIGNvZGUK d291bGQgc2V0IHRpbWluZ3MtPnNldHVwX3RpbWVfcHMgdG8gMCByZWdhcmRsZXNzIG9mIHRoZSBk ZXNrZXcgdmFsdWUsCmFuZCB0aW1pbmdzLT5ob2xkX3RpbWVfcHMgd291bGQgYmUgZWl0aGVyIDAg b3IgYSB2ZXJ5IGJpZyBpbnRlZ2VyIHZhbHVlCmlmIGRlc2tldyBpcyAtNCAoYm90aCBzZXR1cF90 aW1lX3BzIGFuZCBob2xkX3RpbWVfcHMgYXJlIHUzMikuCgpBbSBJIG1pc3Npbmcgc29tZXRoaW5n PyBXYXMgdGhpcyBpbnRlbnRpb25hbD8KClRoYW5rcywKUmljYXJkbwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6FC5C2D0FC for ; Wed, 13 May 2020 11:10:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 982AE2078C for ; Wed, 13 May 2020 11:10:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 982AE2078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05BEA6E9FC; Wed, 13 May 2020 11:10:03 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BD686E9FC for ; Wed, 13 May 2020 11:10:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id 1B6D92A0521 Date: Wed, 13 May 2020 13:09:57 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Laurent Pinchart Subject: Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml Message-ID: <20200513110957.dgb3axle24pmqp3a@rcn-XPS-13-9360> Mail-Followup-To: Laurent Pinchart , Tomi Valkeinen , robh+dt@kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net References: <20200428092048.14939-1-ricardo.canuelo@collabora.com> <3e377c73-25a3-a7b3-0604-41c54d70039e@ti.com> <20200506155320.GC15206@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506155320.GC15206@pendragon.ideasonboard.com> User-Agent: NeoMutt/20171215 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, Tomi Valkeinen , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGF1cmVudCwKCk9uIG1pw6kgMDYtMDUtMjAyMCAxODo1MzoyMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBJIGRpZG4ndCBpZiBJIHJlbWVtYmVyIGNvcnJlY3RseSwgSSBqdXN0IG1hcHBl ZCBpdCB0byB0aGUgaGFyZHdhcmUKPiBmZWF0dXJlcy4gVGhlIGhhcmR3YXJlIHJlZ2lzdGVyIGlu ZGVlZCB0YWtlcyBhIHZhbHVlIGJldHdlZW4gMCBhbmQgNywKPiBhbmQgdGhhdCBpcyBtYXBwZWQg dG8gWy00LDNdIHggdChTVEVQKS4gSSBkb24ndCBtaW5kIGVpdGhlciBvcHRpb24uCgpJIHdhcyB0 YWtpbmcgYSBsb29rIGF0IHRoZSB0aS10ZnA0MTAuYyBkcml2ZXIgdG8gc2VlIGlmIGl0IG5lZWRz IGFueQpjaGFuZ2VzIHRvIHN1cHBvcnQgdGhlIHVwZGF0ZWQgZGVza2V3IHByb3BlcnR5IHJhbmdl cyBbMC03XSwgYnV0IEkgZG9uJ3QKZnVsbHkgdW5kZXJzdGFuZCB3aGF0IHRoaXMgZG9lcyAobGlu ZSAyNzYpOgoKCS8qIEdldCB0aGUgc2V0dXAgYW5kIGhvbGQgdGltZSBmcm9tIHZlbmRvci1zcGVj aWZpYyBwcm9wZXJ0aWVzLiAqLwoJb2ZfcHJvcGVydHlfcmVhZF91MzIoZHZpLT5kZXYtPm9mX25v ZGUsICJ0aSxkZXNrZXciLCAodTMyICopJmRlc2tldyk7CglpZiAoZGVza2V3IDwgLTQgfHwgZGVz a2V3ID4gMykKCQlyZXR1cm4gLUVJTlZBTDsKCgl0aW1pbmdzLT5zZXR1cF90aW1lX3BzID0gbWlu KDAsIDEyMDAgLSAzNTAgKiBkZXNrZXcpOwoJdGltaW5ncy0+aG9sZF90aW1lX3BzID0gbWluKDAs IDEzMDAgKyAzNTAgKiBkZXNrZXcpOwoKSXQgbG9va3MgbGlrZSB0aGF0IHRoZSBkcml2ZXIgZG9l c24ndCByZWFsbHkgYXBwbHkgdGhlIGRlc2tldyBzZXR0aW5ncwp0byB0aGUgZGV2aWNlIGFuZCB0 aGF0IHRoaXMgaGFzIG5vdCBiZWVuIHJlYWxseSB0ZXN0ZWQsIHNvIGl0J3MgcHJvYmFibHkKbm90 IGEgYmlnIGRlYWwuCgpJIGd1ZXNzIHdoYXQgeW91IHdhbnRlZCB0byBkbyB3YXMgdG8gYWRqdXN0 IHRoZSBzZXR1cCBhbmQgaG9sZCB0aW1lcwphcm91bmQgMTIwMCBhbmQgMTMwMCBwcyByZXNwZWN0 aXZlbHkgaW4gaW5jcmVtZW50cy9kZWNyZW1lbnRzIG9mIDM1MCBwcwpkZXBlbmRpbmcgb24gdGhl IGRlc2tldyB2YWx1ZSwgYXMgdGhlIGRhdGFzaGVldCBkZXNjcmliZXMuIEJ1dCB0aGlzIGNvZGUK d291bGQgc2V0IHRpbWluZ3MtPnNldHVwX3RpbWVfcHMgdG8gMCByZWdhcmRsZXNzIG9mIHRoZSBk ZXNrZXcgdmFsdWUsCmFuZCB0aW1pbmdzLT5ob2xkX3RpbWVfcHMgd291bGQgYmUgZWl0aGVyIDAg b3IgYSB2ZXJ5IGJpZyBpbnRlZ2VyIHZhbHVlCmlmIGRlc2tldyBpcyAtNCAoYm90aCBzZXR1cF90 aW1lX3BzIGFuZCBob2xkX3RpbWVfcHMgYXJlIHUzMikuCgpBbSBJIG1pc3Npbmcgc29tZXRoaW5n PyBXYXMgdGhpcyBpbnRlbnRpb25hbD8KClRoYW5rcywKUmljYXJkbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK