From: Jakub Kicinski <kuba@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Tariq Toukan <tariqt@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx4: Replace zero-length array with flexible-array
Date: Wed, 13 May 2020 11:49:34 -0700 [thread overview]
Message-ID: <20200513114934.22415a35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200513184316.GA2217@ziepe.ca>
On Wed, 13 May 2020 15:43:16 -0300 Jason Gunthorpe wrote:
> On Sat, May 09, 2020 at 08:51:50PM -0700, Jakub Kicinski wrote:
> > On Thu, 7 May 2020 13:59:21 -0500 Gustavo A. R. Silva wrote:
> > > The current codebase makes use of the zero-length array language
> > > extension to the C90 standard, but the preferred mechanism to declare
> > > variable-length types such as these ones is a flexible array member[1][2],
> > > introduced in C99:
> > >
> > > struct foo {
> > > int stuff;
> > > struct boo array[];
> > > };
> > >
> > > ...
> >
> > Applied, thank you!
>
> Jakub,
>
> Please don't take RDMA patches in netdev unless it is a special
> case. There is alot of cross posting and they often get into both
> patchworks.
Sorry about that, I only looked at the subject after applying.
next prev parent reply other threads:[~2020-05-13 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:59 [PATCH] IB/mlx4: Replace zero-length array with flexible-array Gustavo A. R. Silva
2020-05-10 3:51 ` Jakub Kicinski
2020-05-13 18:43 ` Jason Gunthorpe
2020-05-13 18:49 ` Jakub Kicinski [this message]
2020-05-13 18:33 ` Jason Gunthorpe
2020-05-13 18:37 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513114934.22415a35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=gustavoars@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.