From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB27CA90AF for ; Wed, 13 May 2020 12:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A10D4206B7 for ; Wed, 13 May 2020 12:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731875AbgEMMak (ORCPT ); Wed, 13 May 2020 08:30:40 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:57894 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbgEMMai (ORCPT ); Wed, 13 May 2020 08:30:38 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 83C56803088B; Wed, 13 May 2020 12:30:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_-9KXxNQ0-u; Wed, 13 May 2020 15:30:35 +0300 (MSK) Date: Wed, 13 May 2020 15:30:33 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Mark Brown , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , , , Stephen Boyd , Thomas Gleixner , YueHaibing , Jarkko Nikula , , Subject: Re: [PATCH 13/17] spi: dw: Initialize paddr in DW SPI MMIO private data Message-ID: <20200513123033.in3uksakteze3y5t@mobilestation> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200508132943.9826-14-Sergey.Semin@baikalelectronics.ru> <20200508192144.GT185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200508192144.GT185537@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 10:21:44PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 04:29:38PM +0300, Serge Semin wrote: > > This field is used only for the DW SPI DMA code initialization, that's > > why there were no problems with it being uninitialized in Dw SPI MMIO > > driver. Since in a further patch we are going to introduce the DW SPI DMA > > support in the MMIO version of the driver, lets set the field with the > > physical address of the DW SPI controller registers region. > > ... > > > - dws->regs = devm_platform_ioremap_resource(pdev, 0); > > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + dws->regs = devm_ioremap_resource(&pdev->dev, mem); > > There is a helper > dws->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem); Oh, good point. It has been just added, in kernel v5.7. v5.6 didn't provide such a convenient helper. Thanks for the suggestion. -Sergey > > > > if (IS_ERR(dws->regs)) { > > dev_err(&pdev->dev, "SPI region map failed\n"); > > return PTR_ERR(dws->regs); > > } > > + dws->paddr = mem->start; > > > > dws->irq = platform_get_irq(pdev, 0); > > if (dws->irq < 0) > > -- > > 2.25.1 > > > > -- > With Best Regards, > Andy Shevchenko > >