All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] tpm: Remove redundant function grub_tpm_measure
Date: Wed, 13 May 2020 14:45:17 +0200	[thread overview]
Message-ID: <20200513124517.s57l36ajsn3iplua@tomti.i.net-space.pl> (raw)
In-Reply-To: <20200513085353.50251-1-tianjia.zhang@linux.alibaba.com>

On Wed, May 13, 2020 at 04:53:53PM +0800, Tianjia Zhang wrote:
> The grub_tpm_measure() is only used by tpm.c, and this function
> is the simple wrapper of grub_tpm_event_log(). So remove it and
> keep the code cleaner.
>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

I would prefer if you drop existing grub_tpm_measure() and rename
grub_tpm_log_event() to grub_tpm_measure().

Daniel


  reply	other threads:[~2020-05-13 12:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13  8:53 [PATCH] tpm: Remove redundant function grub_tpm_measure Tianjia Zhang
2020-05-13 12:45 ` Daniel Kiper [this message]
2020-05-13 13:08   ` Tianjia Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513124517.s57l36ajsn3iplua@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=tianjia.zhang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.