From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0195BCA90AF for ; Wed, 13 May 2020 12:52:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3DD5206E5 for ; Wed, 13 May 2020 12:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589374356; bh=KhY6ZdXVcxVKLE9siNpeBsbz8Gjyn/kBnBzDWDqAbzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1eabgx2WkkdBi6f8n5IRnsx243zIT+fmwcbn9rbETTskE2AT8nrnw3WDPcZYeYkba CHFM/DtsjtuuNdxRGZjhSTV8t7wWimhh+KcEYoTgBd8I4mZygyTqGeJAk3MFP4TInZ J5mUCmp8GJtpY3hq9XJh60YbzuJTF6DKljr/fCEA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732925AbgEMMwg (ORCPT ); Wed, 13 May 2020 08:52:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:48428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728379AbgEMMwf (ORCPT ); Wed, 13 May 2020 08:52:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF0F2206B7; Wed, 13 May 2020 12:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589374354; bh=KhY6ZdXVcxVKLE9siNpeBsbz8Gjyn/kBnBzDWDqAbzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h+mFzUpNMnrJx5gGtWKAs9ixD8lxMV4pAvocCs8viJoule/q42vwLejwsKeplElWN zOG0YaagiZocGUu8hfg7r1Uitf7j/mSlHl9VeZxaCfCQh6KMQeFxnd+M0P7RnIQyVQ FyyUhONakMPYqsSDri7ZrU/7mwP9Wt3vB0k+znDA= Date: Wed, 13 May 2020 14:52:31 +0200 From: Greg Kroah-Hartman To: Mathias Nyman Cc: Vinod Koul , Mathias Nyman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 0/5] usb: xhci: Add support for Renesas USB controllers Message-ID: <20200513125231.GA1084414@kroah.com> References: <20200506060025.1535960-1-vkoul@kernel.org> <20200513124007.GA1082134@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 13, 2020 at 03:51:28PM +0300, Mathias Nyman wrote: > On 13.5.2020 15.40, Greg Kroah-Hartman wrote: > > On Wed, May 13, 2020 at 03:19:29PM +0300, Mathias Nyman wrote: > >> On 6.5.2020 9.00, Vinod Koul wrote: > >>> This series add support for Renesas USB controllers uPD720201 and uPD720202. > >>> These require firmware to be loaded and in case devices have ROM those can > >>> also be programmed if empty. If ROM is programmed, it runs from ROM as well. > >>> > >>> This includes patches from Christian which supported these controllers w/o > >>> ROM and later my patches for ROM support and debugfs hook for rom erase and > >>> export of xhci-pci functions. > >>> > >> > >> First four patches look ok to me, but 5/5 that adds rom erase debugfs support > >> still needs some work. > >> > >> If you prefer I can take the first four, maybe we can get them to 5.8, and then > >> later add that debugs rom erase support. > >> > >> Let me know what you prefer > > > > Oops, I just added all of these to my testing tree :) > > > > What's wrong with the debugfs patch? I can drop it, but it seemed > > simple enough to me. > > Added "usb_renesas" directory under debugfs root when we have easily accessible > debugfs/usb/xhci directory to use as parent. I've responded to the patch now, sorry I missed that. > Also not checking if adding directory failed (if debufs not supported) That's fine and encouraged to do :) thanks, greg k-h