From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AF3C47076 for ; Wed, 13 May 2020 12:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E30923126 for ; Wed, 13 May 2020 12:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589374685; bh=z8ktgUv0RqO7zvZCUaDL+1/C1Qami3n63M3XsUU5y0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=u3xnHALg0g+9a7525blZNkyuIcaY/Tcn3eebL+rQZfK9GZbjnywZZSKxkwAL0+1gT 4W6F0u4K9U7iSt0lJLV/K7/+t6lSS7o4/EXW4DC3yjZ8rkvjyW17pWT712k/KmpCN1 MzUr+M+40enm1Y8ll6TiyNFPmAI9CHHaqz39d+3c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731862AbgEMM6E (ORCPT ); Wed, 13 May 2020 08:58:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729345AbgEMM6E (ORCPT ); Wed, 13 May 2020 08:58:04 -0400 Received: from localhost (unknown [106.200.233.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09A2F20753; Wed, 13 May 2020 12:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589374683; bh=z8ktgUv0RqO7zvZCUaDL+1/C1Qami3n63M3XsUU5y0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KU0Kz0GUcvuniZJeT5XqGvbln7iZQmRyoVX2qel6IiXd1LwLWp8cHmounYzweHPe6 DUAiwWPMlCGbDm4yeWath3SACqH1XJ8Cp5gHUsH16g53JIimP/t99xmEQlxo9jAnt/ eWsol2Lh2cI9pdEgM15dtngtE0ozxI6Kj4Z87HFs= Date: Wed, 13 May 2020 18:27:59 +0530 From: Vinod Koul To: Greg Kroah-Hartman Cc: Mathias Nyman , Mathias Nyman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 0/5] usb: xhci: Add support for Renesas USB controllers Message-ID: <20200513125759.GI14092@vkoul-mobl> References: <20200506060025.1535960-1-vkoul@kernel.org> <20200513124007.GA1082134@kroah.com> <20200513125231.GA1084414@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513125231.GA1084414@kroah.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13-05-20, 14:52, Greg Kroah-Hartman wrote: > On Wed, May 13, 2020 at 03:51:28PM +0300, Mathias Nyman wrote: > > On 13.5.2020 15.40, Greg Kroah-Hartman wrote: > > > On Wed, May 13, 2020 at 03:19:29PM +0300, Mathias Nyman wrote: > > >> On 6.5.2020 9.00, Vinod Koul wrote: > > >>> This series add support for Renesas USB controllers uPD720201 and uPD720202. > > >>> These require firmware to be loaded and in case devices have ROM those can > > >>> also be programmed if empty. If ROM is programmed, it runs from ROM as well. > > >>> > > >>> This includes patches from Christian which supported these controllers w/o > > >>> ROM and later my patches for ROM support and debugfs hook for rom erase and > > >>> export of xhci-pci functions. > > >>> > > >> > > >> First four patches look ok to me, but 5/5 that adds rom erase debugfs support > > >> still needs some work. > > >> > > >> If you prefer I can take the first four, maybe we can get them to 5.8, and then > > >> later add that debugs rom erase support. > > >> > > >> Let me know what you prefer > > > > > > Oops, I just added all of these to my testing tree :) > > > > > > What's wrong with the debugfs patch? I can drop it, but it seemed > > > simple enough to me. > > > > Added "usb_renesas" directory under debugfs root when we have easily accessible > > debugfs/usb/xhci directory to use as parent. > > I've responded to the patch now, sorry I missed that. I can send an update on top of this to use xhci root, or respin this patch, either ways is fine by me. > > Also not checking if adding directory failed (if debufs not supported) > > That's fine and encouraged to do :) Yes, I have known you 'encouraging' folks for that, hence coded it :) Thanks -- ~Vinod