From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D051FCA90AF for ; Wed, 13 May 2020 13:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08B9C2054F for ; Wed, 13 May 2020 13:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ewcl5ODp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388752AbgEMNtb (ORCPT ); Wed, 13 May 2020 09:49:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57966 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbgEMNta (ORCPT ); Wed, 13 May 2020 09:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vE3N/bgCOSuBsuoedjezPDBuOaPIgi01RG5Bucwqlu8=; b=ewcl5ODpAGeimIVHP1ORPWJEFl QIJBqbAhMG7S4Plui+l8Ele2Wr4GEWqKdI8dth1eWMUbgvCcd22tHLWy8Hlnc2F/LD7MVRhdm+j6e aAW5YRVXbg20bp05k8hUBL3e3VHZdFBbnaUCF0IUE3+DBg4hUtS6Wrg9YgysqUc8j+Fo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jYrlF-002ARp-BL; Wed, 13 May 2020 15:49:25 +0200 Date: Wed, 13 May 2020 15:49:25 +0200 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Doug Berger , "David S. Miller" , Florian Fainelli , Heiner Kallweit , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Message-ID: <20200513134925.GE499265@lunn.ch> References: <1589243050-18217-1-git-send-email-opendmb@gmail.com> <1589243050-18217-2-git-send-email-opendmb@gmail.com> <20200512004714.GD409897@lunn.ch> <20200512185503.GD1551@shell.armlinux.org.uk> <0cf740ed-bd13-89d5-0f36-1e5305210e97@gmail.com> <20200513053405.GE1551@shell.armlinux.org.uk> <20200513092050.GB1605@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513092050.GB1605@shell.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So, I think consistency of implementation is more important than fixing > this; the current behaviour has been established for many years now. Hi Russell, Doug With netlink ethtool we have the possibility of adding a new API to control this. And we can leave the IOCTL API alone, and the current ethtool commands. We can add a new command to ethtool which uses the new API. Question is, do we want to do this? Would we be introducing yet more confusion, rather than making the situation better? Andrew