From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Nikolay Borisov <nborisov@suse.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: Don't set SHAREABLE flag for data reloc tree
Date: Wed, 13 May 2020 15:51:52 +0200 [thread overview]
Message-ID: <20200513135152.GJ18421@twin.jikos.cz> (raw)
In-Reply-To: <2dc7bd7b-dc68-613e-f668-0462829f380f@gmx.com>
On Wed, May 13, 2020 at 02:49:11PM +0800, Qu Wenruo wrote:
> >> {
> >> struct inode *inode = NULL;
> >> struct btrfs_trans_handle *trans;
> >> - struct btrfs_root *root;
> >> + struct btrfs_root *root = fs_info->dreloc_root;
> >
> > So why haven't you added code in btrfs_get_fs_root to quickly return a
> > refcounted root and instead reference it without incrementing the refcount?
>
> This is exactly the same as how we handle fs_root.
> And since the lifespan of data reloc root will be the same as the fs, I
> don't think there is any need for it to be grabbed each time we need it.
I'd vote for some consistency in the refcounting, ie. even if it's for
the same life span as the filesystem, set the reference.
next prev parent reply other threads:[~2020-05-13 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:16 [PATCH 0/2] btrfs: REF_COWS bit rework Qu Wenruo
2020-05-13 6:16 ` [PATCH 1/2] btrfs: Rename BTRFS_ROOT_REF_COWS to BTRFS_ROOT_SHAREABLE Qu Wenruo
2020-05-13 14:18 ` David Sterba
2020-05-13 6:16 ` [PATCH 2/2] btrfs: Don't set SHAREABLE flag for data reloc tree Qu Wenruo
2020-05-13 6:44 ` Nikolay Borisov
2020-05-13 6:49 ` Qu Wenruo
2020-05-13 13:51 ` David Sterba [this message]
2020-05-14 0:01 ` Qu Wenruo
2020-05-13 14:01 ` David Sterba
2020-05-14 0:06 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513135152.GJ18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.