* Re: [v1,1/1] hwmon: (nct7904) Fix the incorrect rang of temperature limitation registers.
@ 2020-05-13 15:21 Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-05-13 15:21 UTC (permalink / raw)
To: Amy.Shih
Cc: she90122, Jean Delvare, linux-hwmon, linux-kernel, oakley.ding,
jia.sui, yuechao.zhao, Hy.Lee
On Tue, May 12, 2020 at 09:38:06AM +0000, Amy.Shih@advantech.com.tw wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
>
> The format of temperature limitation registers are 8-bit 2's complement
> and the range is -128~127.
> Converts the reading value to signed char to fix the incorrect range
> of temperature limitation registers.
>
> Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/nct7904.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 6fb06f7..04f2a8e 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -390,6 +390,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
> struct nct7904_data *data = dev_get_drvdata(dev);
> int ret, temp;
> unsigned int reg1, reg2, reg3;
> + s8 temps;
>
> switch (attr) {
> case hwmon_temp_input:
> @@ -495,7 +496,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
>
> if (ret < 0)
> return ret;
> - *val = ret * 1000;
> + temps = ret;
> + *val = temps * 1000;
> return 0;
> }
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [v1,1/1] hwmon: (nct7904) Fix the incorrect rang of temperature limitation registers.
@ 2020-05-12 9:38 Amy.Shih
0 siblings, 0 replies; 2+ messages in thread
From: Amy.Shih @ 2020-05-12 9:38 UTC (permalink / raw)
To: she90122
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel, amy.shih,
oakley.ding, jia.sui, yuechao.zhao, Hy.Lee
From: Amy Shih <amy.shih@advantech.com.tw>
The format of temperature limitation registers are 8-bit 2's complement
and the range is -128~127.
Converts the reading value to signed char to fix the incorrect range
of temperature limitation registers.
Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
---
drivers/hwmon/nct7904.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 6fb06f7..04f2a8e 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -390,6 +390,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
struct nct7904_data *data = dev_get_drvdata(dev);
int ret, temp;
unsigned int reg1, reg2, reg3;
+ s8 temps;
switch (attr) {
case hwmon_temp_input:
@@ -495,7 +496,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
if (ret < 0)
return ret;
- *val = ret * 1000;
+ temps = ret;
+ *val = temps * 1000;
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 15:21 [v1,1/1] hwmon: (nct7904) Fix the incorrect rang of temperature limitation registers Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2020-05-12 9:38 Amy.Shih
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.