All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, armbru@redhat.com,
	qemu-devel@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com,
	marcandre.lureau@redhat.com
Subject: Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support
Date: Wed, 13 May 2020 16:52:12 +0100	[thread overview]
Message-ID: <20200513155212.GK1253949@redhat.com> (raw)
In-Reply-To: <20200510061422.24841-2-zxq_yx_007@163.com>

On Sun, May 10, 2020 at 02:14:20PM +0800, xiaoqiang zhao wrote:
> unix_listen/connect_saddr now support abstract address types
> 
> two aditional BOOL switches are introduced:
> tight: whether to set @addrlen to the minimal string length,
>        or the maximum sun_path length. default is TRUE
> abstract: whether we use abstract address. default is FALSE
> 
> cli example:
> -monitor unix:/tmp/unix.socket,abstract,tight=off
> OR
> -chardev socket,path=/tmp/unix.socket,id=unix1,abstract,tight=on
> 
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  chardev/char-socket.c |  4 ++++
>  chardev/char.c        |  7 +++++++
>  qapi/sockets.json     |  9 ++++++++-
>  util/qemu-sockets.c   | 39 ++++++++++++++++++++++++++++++++-------
>  4 files changed, 51 insertions(+), 8 deletions(-)

With the changes Eric suggests, then

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2020-05-13 15:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10  6:14 [PATCH v3 0/3] " xiaoqiang zhao
2020-05-10  6:14 ` [PATCH v3 1/3] " xiaoqiang zhao
2020-05-11 18:01   ` Eric Blake
2020-05-12  6:52     ` xiaoqiang.zhao
2020-05-13 15:52   ` Daniel P. Berrangé [this message]
2020-05-10  6:14 ` [PATCH v3 2/3] tests/util-sockets: add abstract unix socket cases xiaoqiang zhao
2020-05-13 15:49   ` Daniel P. Berrangé
2020-05-14  0:26     ` xiaoqiang zhao
2020-05-10  6:14 ` [PATCH v3 3/3] qemu-options: updates for abstract unix sockets xiaoqiang zhao
2020-05-13 15:50   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513155212.GK1253949@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zxq_yx_007@163.com \
    --subject='Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.