From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10330C433DF for ; Wed, 13 May 2020 18:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D9322065C for ; Wed, 13 May 2020 18:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589393821; bh=7OdZ4IZArUi+L4mY8bHUPOZTuTiNZ3U2f/N6r1sYvNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1KCAbFhnUvlWW4BXCfdFn3Qb+7mjoJp9SG+SuksPg8DbtjfRAg0wNgBeSTYFxS/tm /MdWqZMXJrh05tB6olc7f5WpM01ezfqusLEJXP99fHJzncZLGIsw3ep6pGYagiXWYU f+k+DC1iNnxik82iNyOL/5h3hRMMIeMT0XnociPg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390060AbgEMSRA (ORCPT ); Wed, 13 May 2020 14:17:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:60734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733175AbgEMSRA (ORCPT ); Wed, 13 May 2020 14:17:00 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7312820659; Wed, 13 May 2020 18:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589393820; bh=7OdZ4IZArUi+L4mY8bHUPOZTuTiNZ3U2f/N6r1sYvNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tksfnANLVmlXEvwcksk10I0WQqNWoydzaZczzHwya8RjqTwR39GMXOEVvQV4MIX04 35pvgssetPaGXSG5fZwqJf9km87mgDBWNsN3BLyEF2BGTjgo3GA1B5IhhFkpr9wl3K a7yYuAlxQnWqha8R1PhibTiiwD1Xy5rYh4/0/Evc= Date: Wed, 13 May 2020 11:16:58 -0700 From: Eric Biggers To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Barani Muthukumaran , Kuohong Wang , Kim Boojin Subject: Re: [PATCH v12 07/12] scsi: ufs: UFS crypto API Message-ID: <20200513181658.GG1243@sol.localdomain> References: <20200430115959.238073-1-satyat@google.com> <20200430115959.238073-8-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430115959.238073-8-satyat@google.com> Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Thu, Apr 30, 2020 at 11:59:54AM +0000, Satya Tangirala wrote: > Introduce functions to manipulate UFS inline encryption hardware > in line with the JEDEC UFSHCI v2.1 specification and to work with the > block keyslot manager. > > The UFS crypto API will assume by default that a vendor driver doesn't > support UFS crypto, even if the hardware advertises the capability, because > a lot of hardware requires some special handling that's not specified in > the aforementioned JEDEC spec. Each vendor driver must explicity set > hba->caps |= UFSHCD_CAP_CRYPTO before ufshcd_hba_init_crypto is called to > opt-in to UFS crypto support. > > Signed-off-by: Satya Tangirala Looks good, you can add: Reviewed-by: Eric Biggers - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85458C433E0 for ; Wed, 13 May 2020 18:17:16 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A7E20659; Wed, 13 May 2020 18:17:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="QfdFtSD4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="SXre2jTz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tksfnANL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11A7E20659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jYvwR-00045k-SR; Wed, 13 May 2020 18:17:15 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYvwQ-00045V-J3 for linux-f2fs-devel@lists.sourceforge.net; Wed, 13 May 2020 18:17:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F9o68Uxu9D8jMvM7fsMCc03ytJoSDNBYlEYa0yTo4XQ=; b=QfdFtSD4OrI/ts11k+Cw31i0XN KadY3uZ/VnQHfbSigVkT1HufTqqZG/l/cbYbqCbnDsPzQzm6xODBmm467g3rQ5Cn3T1a89Tre2m++ dq5GU6CTZvqC8C3TdFQnPO6HNXgjrUEH1JiDjVjUK2x1+5vMZpgh8ZTSuhoW8GiD3QeA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=F9o68Uxu9D8jMvM7fsMCc03ytJoSDNBYlEYa0yTo4XQ=; b=SXre2jTzS0Qu3bY5byXMqv+j2+ 6rmlnaT7eCqrhQdW25NYqv637a2ZZXaI6qC5uc/+xCJR+7j0XR/RED+uY+zZivkusryPsSGggtbrz 5VmTBrAoraFHYrUH5gxbFXSO/jd9kDwhR0Oq7FL017RKm9cROE0llaXDgTZg18jHVJuM=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jYvwO-008tqu-Hw for linux-f2fs-devel@lists.sourceforge.net; Wed, 13 May 2020 18:17:14 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7312820659; Wed, 13 May 2020 18:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589393820; bh=7OdZ4IZArUi+L4mY8bHUPOZTuTiNZ3U2f/N6r1sYvNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tksfnANLVmlXEvwcksk10I0WQqNWoydzaZczzHwya8RjqTwR39GMXOEVvQV4MIX04 35pvgssetPaGXSG5fZwqJf9km87mgDBWNsN3BLyEF2BGTjgo3GA1B5IhhFkpr9wl3K a7yYuAlxQnWqha8R1PhibTiiwD1Xy5rYh4/0/Evc= Date: Wed, 13 May 2020 11:16:58 -0700 From: Eric Biggers To: Satya Tangirala Message-ID: <20200513181658.GG1243@sol.localdomain> References: <20200430115959.238073-1-satyat@google.com> <20200430115959.238073-8-satyat@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200430115959.238073-8-satyat@google.com> X-Headers-End: 1jYvwO-008tqu-Hw Subject: Re: [f2fs-dev] [PATCH v12 07/12] scsi: ufs: UFS crypto API X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, Kim Boojin , Kuohong Wang , Barani Muthukumaran , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Apr 30, 2020 at 11:59:54AM +0000, Satya Tangirala wrote: > Introduce functions to manipulate UFS inline encryption hardware > in line with the JEDEC UFSHCI v2.1 specification and to work with the > block keyslot manager. > > The UFS crypto API will assume by default that a vendor driver doesn't > support UFS crypto, even if the hardware advertises the capability, because > a lot of hardware requires some special handling that's not specified in > the aforementioned JEDEC spec. Each vendor driver must explicity set > hba->caps |= UFSHCD_CAP_CRYPTO before ufshcd_hba_init_crypto is called to > opt-in to UFS crypto support. > > Signed-off-by: Satya Tangirala Looks good, you can add: Reviewed-by: Eric Biggers - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel