From: Alexander Bulekov <alxndr@bu.edu>
To: P J P <ppandit@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Ding Ren" <rding@gatech.edu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference
Date: Wed, 13 May 2020 16:20:35 -0400 [thread overview]
Message-ID: <20200513202035.7gax7nnobhnfsynp@mozz.bu.edu> (raw)
In-Reply-To: <20200513192540.1583887-3-ppandit@redhat.com>
On 200514 0055, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While in megasas_handle_frame(), megasas_enqueue_frame() may
> set a NULL frame into MegasasCmd object for a given 'frame_addr'
> address. Add check to avoid a NULL pointer dereference issue.
>
> Reported-by: Alexander Bulekov <alxndr@bu.edu>
> Fixes: https://bugs.launchpad.net/qemu/+bug/1878259
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Acked-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> hw/scsi/megasas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index 6ce598cd69..b531d88a9b 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -504,7 +504,7 @@ static MegasasCmd *megasas_enqueue_frame(MegasasState *s,
> cmd->pa = frame;
> /* Map all possible frames */
> cmd->frame = pci_dma_map(pcid, frame, &frame_size_p, 0);
> - if (frame_size_p != frame_size) {
> + if (!cmd->frame || frame_size_p != frame_size) {
> trace_megasas_qf_map_failed(cmd->index, (unsigned long)frame);
> if (cmd->frame) {
> megasas_unmap_frame(s, cmd);
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-05-13 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 19:25 [PATCH v2 0/3] Megasas: fix OOB access and NULL dereference issues P J P
2020-05-13 19:25 ` [PATCH v2 1/3] megasas: use unsigned type for reply_queue_head and check index P J P
2020-05-13 20:31 ` Alexander Bulekov
2020-05-14 13:19 ` Darren Kenny
2020-05-14 16:10 ` P J P
2020-05-13 19:25 ` [PATCH v2 2/3] megasas: avoid NULL pointer dereference P J P
2020-05-13 20:20 ` Alexander Bulekov [this message]
2020-05-14 13:19 ` Darren Kenny
2020-05-21 15:34 ` Paolo Bonzini
2020-05-26 7:18 ` P J P
2020-05-26 7:49 ` Paolo Bonzini
2020-05-13 19:25 ` [PATCH v2 3/3] megasas: use unsigned type for positive numeric fields P J P
2020-05-14 13:28 ` Darren Kenny
2020-05-21 15:35 ` [PATCH v2 0/3] Megasas: fix OOB access and NULL dereference issues Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513202035.7gax7nnobhnfsynp@mozz.bu.edu \
--to=alxndr@bu.edu \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rding@gatech.edu \
--subject='Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.