From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arun Kumar Neelakantam <aneela@codeaurora.org> Cc: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org, sricharan@codeaurora.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>, "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states Date: Wed, 13 May 2020 14:59:15 -0600 [thread overview] Message-ID: <20200513205915.GA8328@xps15> (raw) In-Reply-To: <1589346606-15046-2-git-send-email-aneela@codeaurora.org> Hi Arun, On Wed, May 13, 2020 at 10:40:02AM +0530, Arun Kumar Neelakantam wrote: > From: Chris Lew <clew@codeaurora.org> > > The open_req and open_ack completion variables are the state variables > to represet a remote channel as open. Use complete_all so there are no s/represet/represent > races with waiters and using completion_done. > > Signed-off-by: Chris Lew <clew@codeaurora.org> > Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org> > --- > drivers/rpmsg/qcom_glink_native.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 1995f5b..604f11f 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) > return -EINVAL; > } > > - complete(&channel->open_ack); > + complete_all(&channel->open_ack); If you do this and as per the note in the comment section above completion_done(), there shouldn't be a need to call completion_done() in qcom_glink_announce_create(). Thanks, Mathieu > > return 0; > } > @@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, > channel->rcid = ret; > spin_unlock_irqrestore(&glink->idr_lock, flags); > > - complete(&channel->open_req); > + complete_all(&channel->open_req); > > if (create_device) { > rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL); > -- > 2.7.4
next prev parent reply other threads:[~2020-05-13 20:59 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 5:10 [PATCH V5 0/5] Add chrdev and name query support for GLINK Arun Kumar Neelakantam 2020-05-13 5:10 ` [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states Arun Kumar Neelakantam 2020-05-13 20:59 ` Mathieu Poirier [this message] 2020-05-20 9:28 ` Arun Kumar Neelakantam 2020-05-13 5:10 ` [PATCH V5 2/5] rpmsg: Guard against null endpoint ops in destroy Arun Kumar Neelakantam 2020-05-13 5:10 ` [PATCH V5 3/5] rpmsg: glink: Add support for rpmsg glink chrdev Arun Kumar Neelakantam 2020-05-13 21:56 ` Mathieu Poirier 2020-05-13 5:10 ` [PATCH V5 4/5] rpmsg: glink: Expose rpmsg name attr for glink Arun Kumar Neelakantam 2020-05-13 5:10 ` [PATCH V5 5/5] rpmsg: glink: unregister rpmsg device during endpoint destroy Arun Kumar Neelakantam 2020-05-13 22:13 ` Mathieu Poirier 2020-05-20 9:32 ` Arun Kumar Neelakantam [not found] <1574417087-27594-1-git-send-email-aneela@codeaurora.org> 2019-11-22 10:05 ` [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states Arun Kumar Neelakantam 2019-11-22 10:05 ` Arun Kumar Neelakantam 2019-11-22 10:05 ` Arun Kumar Neelakantam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200513205915.GA8328@xps15 \ --to=mathieu.poirier@linaro.org \ --cc=agross@kernel.org \ --cc=aneela@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=clew@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=sricharan@codeaurora.org \ --subject='Re: [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.