From: Emil Velikov <emil.l.velikov@gmail.com> To: dri-devel@lists.freedesktop.org Cc: emil.l.velikov@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, linux-kernel@vger.kernel.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH 08/11] drm: constify sysrq_key_op Date: Wed, 13 May 2020 22:43:48 +0100 [thread overview] Message-ID: <20200513214351.2138580-8-emil.l.velikov@gmail.com> (raw) In-Reply-To: <20200513214351.2138580-1-emil.l.velikov@gmail.com> With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better if this gets merged this via the tty tree. --- drivers/gpu/drm/drm_fb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index a9771de4d17e..533767100efe 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -307,13 +307,13 @@ static void drm_fb_helper_sysrq(int dummy1) schedule_work(&drm_fb_helper_restore_work); } -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { .handler = drm_fb_helper_sysrq, .help_msg = "force-fb(V)", .action_msg = "Restore framebuffer console", }; #else -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { }; +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { }; #endif static void drm_fb_helper_dpms(struct fb_info *info, int dpms_mode) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com> To: dri-devel@lists.freedesktop.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, emil.l.velikov@gmail.com, Thomas Zimmermann <tzimmermann@suse.de>, Jiri Slaby <jslaby@suse.com> Subject: [PATCH 08/11] drm: constify sysrq_key_op Date: Wed, 13 May 2020 22:43:48 +0100 [thread overview] Message-ID: <20200513214351.2138580-8-emil.l.velikov@gmail.com> (raw) In-Reply-To: <20200513214351.2138580-1-emil.l.velikov@gmail.com> With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better if this gets merged this via the tty tree. --- drivers/gpu/drm/drm_fb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index a9771de4d17e..533767100efe 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -307,13 +307,13 @@ static void drm_fb_helper_sysrq(int dummy1) schedule_work(&drm_fb_helper_restore_work); } -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { .handler = drm_fb_helper_sysrq, .help_msg = "force-fb(V)", .action_msg = "Restore framebuffer console", }; #else -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { }; +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { }; #endif static void drm_fb_helper_dpms(struct fb_info *info, int dpms_mode) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-13 21:46 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 21:43 [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 02/11] tty/sysrq: constify the sysrq API Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 03/11] tty/sysrq: constify the the sysrq_key_op(s) Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 04/11] alpha: constify sysrq_key_op Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` [PATCH 05/11] MIPS: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 7:49 ` Thomas Bogendoerfer 2020-05-14 7:49 ` Thomas Bogendoerfer 2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 3:44 ` Michael Ellerman 2020-05-14 3:44 ` Michael Ellerman 2020-05-14 3:44 ` Michael Ellerman 2020-05-13 21:43 ` [PATCH 07/11] sparc64: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 21:58 ` David Miller 2020-05-13 21:58 ` David Miller 2020-05-13 21:58 ` David Miller 2020-05-13 21:43 ` Emil Velikov [this message] 2020-05-13 21:43 ` [PATCH 08/11] drm: " Emil Velikov 2020-05-14 12:36 ` Daniel Vetter 2020-05-14 12:36 ` Daniel Vetter 2020-05-13 21:43 ` [PATCH 09/11] kdb: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 16:46 ` Daniel Thompson 2020-05-14 16:46 ` Daniel Thompson 2020-05-13 21:43 ` [PATCH 10/11] kernel/power: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-14 11:20 ` Rafael J. Wysocki 2020-05-14 11:20 ` Rafael J. Wysocki 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:11 ` Emil Velikov 2020-05-15 10:39 ` Greg Kroah-Hartman 2020-05-15 10:39 ` Greg Kroah-Hartman 2020-05-13 21:43 ` [PATCH 11/11] rcu: " Emil Velikov 2020-05-13 21:43 ` Emil Velikov 2020-05-13 22:41 ` Paul E. McKenney 2020-05-13 22:41 ` Paul E. McKenney 2020-05-15 12:54 ` [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Greg Kroah-Hartman 2020-05-15 12:54 ` Greg Kroah-Hartman 2020-06-08 14:38 ` Guenter Roeck 2020-06-08 14:38 ` Guenter Roeck 2020-06-10 20:51 ` Guenter Roeck 2020-06-10 20:51 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200513214351.2138580-8-emil.l.velikov@gmail.com \ --to=emil.l.velikov@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.