* r8169: remove not needed checks in rtl8169_set_eee
@ 2020-05-14 21:39 Heiner Kallweit
2020-05-15 1:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2020-05-14 21:39 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller, Jakub Kicinski; +Cc: netdev
After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee")
we don't need the check for aneg being enabled any longer, and as
discussed with Russell configuring the EEE advertisement should be
supported even if we're in a half-duplex mode currently.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index b030993a7..6c9a50958 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1919,12 +1919,6 @@ static int rtl8169_set_eee(struct net_device *dev, struct ethtool_eee *data)
goto out;
}
- if (dev->phydev->autoneg == AUTONEG_DISABLE ||
- dev->phydev->duplex != DUPLEX_FULL) {
- ret = -EPROTONOSUPPORT;
- goto out;
- }
-
ret = phy_ethtool_set_eee(tp->phydev, data);
if (!ret)
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: r8169: remove not needed checks in rtl8169_set_eee
2020-05-14 21:39 r8169: remove not needed checks in rtl8169_set_eee Heiner Kallweit
@ 2020-05-15 1:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-15 1:03 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, kuba, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 14 May 2020 23:39:34 +0200
> After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee")
> we don't need the check for aneg being enabled any longer, and as
> discussed with Russell configuring the EEE advertisement should be
> supported even if we're in a half-duplex mode currently.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 1:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 21:39 r8169: remove not needed checks in rtl8169_set_eee Heiner Kallweit
2020-05-15 1:03 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.