From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D4EC433E0 for ; Thu, 14 May 2020 01:36:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA2272054F for ; Thu, 14 May 2020 01:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u35Xn5TG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725952AbgENBgb (ORCPT ); Wed, 13 May 2020 21:36:31 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:51450 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbgENBga (ORCPT ); Wed, 13 May 2020 21:36:30 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9DD251F; Thu, 14 May 2020 03:36:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1589420189; bh=ruaosMjEGymTCOyQ3kMWp7Sns7XqR9lnoEYcbipeJeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u35Xn5TGdM8H5ZnWIfLPOWIBuH609Awkt4Zzl1wmTSCiqC/NMGAEWnBXBpblzs+Le vlwPz2r36WRo57GEkOY/RhL0dwQaXrOnMeTPW1140LI+bgo20MygWPei4pze0cITY5 r1Sosg7m+/EivbShg5490woKvsroh1LxKH2RXq4k= Date: Thu, 14 May 2020 04:36:22 +0300 From: Laurent Pinchart To: Michal Simek Cc: Ezequiel Garcia , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, geert+renesas@glider.be, robh+dt@kernel.org, xuwei5@hisilicon.com, Ricardo =?utf-8?Q?Ca=C3=B1uelo?= Subject: Re: [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Message-ID: <20200514013622.GC7425@pendragon.ideasonboard.com> References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-4-ricardo.canuelo@collabora.com> <28fa96d51523448656c71656dc80177d08c481ed.camel@collabora.com> <9d3a0eea-578d-3138-f386-a3f47fed4233@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d3a0eea-578d-3138-f386-a3f47fed4233@xilinx.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, On Mon, May 11, 2020 at 02:52:50PM +0200, Michal Simek wrote: > On 11. 05. 20 14:24, Ezequiel Garcia wrote: > > (Adding Michal) > > > > On Mon, 2020-05-11 at 13:06 +0200, Ricardo Cañuelo wrote: > >> Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with > >> the adi,adv7511 DT binding. > >> > >> This fills the minimum requirements to meet the binding requirements, > >> remote endpoints are not defined. > >> > >> Signed-off-by: Ricardo Cañuelo > >> --- > >> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++ > >> arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++ > >> 2 files changed, 20 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts > >> index 27cd6cb52f1b..79fd236edded 100644 > >> --- a/arch/arm/boot/dts/zynq-zc702.dts > >> +++ b/arch/arm/boot/dts/zynq-zc702.dts > >> @@ -135,6 +135,16 @@ > >> adi,input-clock = "1x"; > >> adi,input-style = <3>; > >> adi,input-justification = "right"; > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + port@0 { > >> + reg = <0>; > >> + }; > >> + port@1 { > >> + reg = <1>; > >> + }; > >> + }; > >> }; > >> }; > >> > >> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts > >> index 77943c16d33f..99fa51ba6e93 100644 > >> --- a/arch/arm/boot/dts/zynq-zc706.dts > >> +++ b/arch/arm/boot/dts/zynq-zc706.dts > >> @@ -93,6 +93,16 @@ > >> adi,input-clock = "1x"; > >> adi,input-style = <3>; > >> adi,input-justification = "evenly"; > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + port@0 { > >> + reg = <0>; > >> + }; > >> + port@1 { > >> + reg = <1>; > >> + }; > >> + }; > >> }; > >> }; > >> > > Just c&p Laurent's reply to Ricardo about it. > > "Completing the board definition is best I believe. Sometimes the > endpoint is related to an add-on board that isn't described as part of > the base DTS. The ports are required as they describe hardware > interfaces, but having no endpoint in a port shouldn't be a problem, it > just means the port is not connected." > > I am ok with it too that's why > > Acked-by: Michal Simek Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B14FC433E0 for ; Thu, 14 May 2020 01:36:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 023D92054F for ; Thu, 14 May 2020 01:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dIgpJ0k9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u35Xn5TG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 023D92054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKy68L1En5jpbT1whBpyovyIzABIIMzQAVNB6fip7cQ=; b=dIgpJ0k9JL4Wol LSedpkrrb/BhAoXF6h1c0KQ0G2Elz1sGfE1TAEqIFvR9iZfOgT0bDfrFggLV+9cAajM2Or7sPJIJz KYqFEphpCO/BdWX+1uVGpB1fM8EYJ11Q7g4rHvG+zblo1q5MjsnJ8mRRl9bTLSFXW46MHZnOsWMOx 6gVp7tGw9h5Gne5C6Olh48BhYWV5pNCnYYIxqRqvoP7xW8OhNX5G4VMeKlRXljlh9MfVR5fGNZ14A f4TeoMyAeRLh3y7WmT5q3eTYgE0AZaS6ah/AugwMCJUE8ay2ryDoprfA/TwkbkyO/L3h1IT1RGSo2 GHixSJNAmz1H13Ds08lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ2nZ-0007pO-Uv; Thu, 14 May 2020 01:36:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ2nW-0007on-Dd for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2020 01:36:32 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9DD251F; Thu, 14 May 2020 03:36:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1589420189; bh=ruaosMjEGymTCOyQ3kMWp7Sns7XqR9lnoEYcbipeJeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u35Xn5TGdM8H5ZnWIfLPOWIBuH609Awkt4Zzl1wmTSCiqC/NMGAEWnBXBpblzs+Le vlwPz2r36WRo57GEkOY/RhL0dwQaXrOnMeTPW1140LI+bgo20MygWPei4pze0cITY5 r1Sosg7m+/EivbShg5490woKvsroh1LxKH2RXq4k= Date: Thu, 14 May 2020 04:36:22 +0300 From: Laurent Pinchart To: Michal Simek Subject: Re: [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Message-ID: <20200514013622.GC7425@pendragon.ideasonboard.com> References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-4-ricardo.canuelo@collabora.com> <28fa96d51523448656c71656dc80177d08c481ed.camel@collabora.com> <9d3a0eea-578d-3138-f386-a3f47fed4233@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d3a0eea-578d-3138-f386-a3f47fed4233@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_183631_076211_9CB2E59C X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, geert+renesas@glider.be, Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , xuwei5@hisilicon.com, robh+dt@kernel.org, kernel@collabora.com, Ezequiel Garcia , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBNb24sIE1heSAxMSwgMjAyMCBhdCAwMjo1Mjo1MFBNICswMjAwLCBNaWNoYWwg U2ltZWsgd3JvdGU6Cj4gT24gMTEuIDA1LiAyMCAxNDoyNCwgRXplcXVpZWwgR2FyY2lhIHdyb3Rl Ogo+ID4gKEFkZGluZyBNaWNoYWwpCj4gPiAKPiA+IE9uIE1vbiwgMjAyMC0wNS0xMSBhdCAxMzow NiArMDIwMCwgUmljYXJkbyBDYcOxdWVsbyB3cm90ZToKPiA+PiBEZWZpbmUgYSAncG9ydHMnIG5v ZGUgZm9yICdhZHY3NTExOiBoZG1pLXR4QDM5JyB0byBtYWtlIGl0IGNvbXBsaWFudCB3aXRoCj4g Pj4gdGhlIGFkaSxhZHY3NTExIERUIGJpbmRpbmcuCj4gPj4KPiA+PiBUaGlzIGZpbGxzIHRoZSBt aW5pbXVtIHJlcXVpcmVtZW50cyB0byBtZWV0IHRoZSBiaW5kaW5nIHJlcXVpcmVtZW50cywKPiA+ PiByZW1vdGUgZW5kcG9pbnRzIGFyZSBub3QgZGVmaW5lZC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYt Ynk6IFJpY2FyZG8gQ2HDsXVlbG8gPHJpY2FyZG8uY2FudWVsb0Bjb2xsYWJvcmEuY29tPgo+ID4+ IC0tLQo+ID4+ICBhcmNoL2FybS9ib290L2R0cy96eW5xLXpjNzAyLmR0cyB8IDEwICsrKysrKysr KysKPiA+PiAgYXJjaC9hcm0vYm9vdC9kdHMvenlucS16YzcwNi5kdHMgfCAxMCArKysrKysrKysr Cj4gPj4gIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3p5bnEtemM3MDIuZHRzIGIvYXJjaC9hcm0vYm9vdC9k dHMvenlucS16YzcwMi5kdHMKPiA+PiBpbmRleCAyN2NkNmNiNTJmMWIuLjc5ZmQyMzZlZGRlZCAx MDA2NDQKPiA+PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy96eW5xLXpjNzAyLmR0cwo+ID4+ICsr KyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3p5bnEtemM3MDIuZHRzCj4gPj4gQEAgLTEzNSw2ICsxMzUs MTYgQEAKPiA+PiAgCQkJCWFkaSxpbnB1dC1jbG9jayA9ICIxeCI7Cj4gPj4gIAkJCQlhZGksaW5w dXQtc3R5bGUgPSA8Mz47Cj4gPj4gIAkJCQlhZGksaW5wdXQtanVzdGlmaWNhdGlvbiA9ICJyaWdo dCI7Cj4gPj4gKwkJCQlwb3J0cyB7Cj4gPj4gKwkJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4g Pj4gKwkJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gPj4gKwkJCQkJcG9ydEAwIHsKPiA+PiArCQkJ CQkJcmVnID0gPDA+Owo+ID4+ICsJCQkJCX07Cj4gPj4gKwkJCQkJcG9ydEAxIHsKPiA+PiArCQkJ CQkJcmVnID0gPDE+Owo+ID4+ICsJCQkJCX07Cj4gPj4gKwkJCQl9Owo+ID4+ICAJCQl9Owo+ID4+ ICAJCX07Cj4gPj4gIAo+ID4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy96eW5xLXpj NzA2LmR0cyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3p5bnEtemM3MDYuZHRzCj4gPj4gaW5kZXggNzc5 NDNjMTZkMzNmLi45OWZhNTFiYTZlOTMgMTAwNjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9k dHMvenlucS16YzcwNi5kdHMKPiA+PiArKysgYi9hcmNoL2FybS9ib290L2R0cy96eW5xLXpjNzA2 LmR0cwo+ID4+IEBAIC05Myw2ICs5MywxNiBAQAo+ID4+ICAJCQkJYWRpLGlucHV0LWNsb2NrID0g IjF4IjsKPiA+PiAgCQkJCWFkaSxpbnB1dC1zdHlsZSA9IDwzPjsKPiA+PiAgCQkJCWFkaSxpbnB1 dC1qdXN0aWZpY2F0aW9uID0gImV2ZW5seSI7Cj4gPj4gKwkJCQlwb3J0cyB7Cj4gPj4gKwkJCQkJ I2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPj4gKwkJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gPj4g KwkJCQkJcG9ydEAwIHsKPiA+PiArCQkJCQkJcmVnID0gPDA+Owo+ID4+ICsJCQkJCX07Cj4gPj4g KwkJCQkJcG9ydEAxIHsKPiA+PiArCQkJCQkJcmVnID0gPDE+Owo+ID4+ICsJCQkJCX07Cj4gPj4g KwkJCQl9Owo+ID4+ICAJCQl9Owo+ID4+ICAJCX07Cj4gPj4gIAo+IAo+IEp1c3QgYyZwIExhdXJl bnQncyByZXBseSB0byBSaWNhcmRvIGFib3V0IGl0Lgo+IAo+ICJDb21wbGV0aW5nIHRoZSBib2Fy ZCBkZWZpbml0aW9uIGlzIGJlc3QgSSBiZWxpZXZlLiBTb21ldGltZXMgdGhlCj4gZW5kcG9pbnQg aXMgcmVsYXRlZCB0byBhbiBhZGQtb24gYm9hcmQgdGhhdCBpc24ndCBkZXNjcmliZWQgYXMgcGFy dCBvZgo+IHRoZSBiYXNlIERUUy4gVGhlIHBvcnRzIGFyZSByZXF1aXJlZCBhcyB0aGV5IGRlc2Ny aWJlIGhhcmR3YXJlCj4gaW50ZXJmYWNlcywgYnV0IGhhdmluZyBubyBlbmRwb2ludCBpbiBhIHBv cnQgc2hvdWxkbid0IGJlIGEgcHJvYmxlbSwgaXQKPiBqdXN0IG1lYW5zIHRoZSBwb3J0IGlzIG5v dCBjb25uZWN0ZWQuIgo+IAo+IEkgYW0gb2sgd2l0aCBpdCB0b28gdGhhdCdzIHdoeQo+IAo+IEFj a2VkLWJ5OiBNaWNoYWwgU2ltZWsgPG1pY2hhbC5zaW1la0B4aWxpbnguY29tPgoKUmV2aWV3ZWQt Ynk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=