From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA38C433DF for ; Thu, 14 May 2020 12:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2933920722 for ; Thu, 14 May 2020 12:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YgWHkQTY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726073AbgENMcz (ORCPT ); Thu, 14 May 2020 08:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725925AbgENMcz (ORCPT ); Thu, 14 May 2020 08:32:55 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D8D5C061A0C for ; Thu, 14 May 2020 05:32:55 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id m24so20549156wml.2 for ; Thu, 14 May 2020 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=YgWHkQTYQPFppqYsLPN4O7w4lYivEAnsEzMA+LRaWDfv1qHjFZT7jJduso+EFh/hnh BmsjyF8UrLtntddw7ns7M8+fhWv+y4cDydxv3fKuQ73T16tDKeVw7qrfp+ced3x5ZpsD AkPmYBhTTcBPvfKZDxpbZ0iFajRNhq0rxkirk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=Plh8nWFCX6eEae+oeNh/92Ug2xAdXSiiF3CiiH6k9OJcMnDOV6vKzT/hoQIQpaj1Lb t/DfZCh8uFZ29o/wF/69w2UpCahmUY/u+/hI823/bo6cUaSVdu/SU3vzWYyXa+EZ0w4m 5DXVB6I27ZyFpPBa1c1VO96B3Y+TrK5o37niSbHxLimnQWo0gR8m1lvZ0X1CDRDxET58 9sUS8I84CcB809yr+cDnhqDN3sglaIqBWQHl+SV7pajDN6M0C1C8OqDSQxj6Lvpt8FcY /8jebpeAFmnnfCORIKu4LFIdG2N89z06gyad6s7110xV1njdAtM4Amd+rnmY2CCT2Zio rb7A== X-Gm-Message-State: AGi0Pua7juiAmDey1+huMC7Nqsfn5htCxMXp+OoPEhgOVZ/iKccvbb+U nie9c7wEtWBCeQ1QpIdGpSdj17ySHoo= X-Google-Smtp-Source: APiQypLwlYFf18uBo+jfC26cvoH7AqKeY4MEhPzSMIyKaNwga5O97X2GrG0P30+6HD8/aszlGaAbDg== X-Received: by 2002:a1c:bbc5:: with SMTP id l188mr27784086wmf.163.1589459573864; Thu, 14 May 2020 05:32:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x23sm38645260wmj.6.2020.05.14.05.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 05:32:53 -0700 (PDT) Date: Thu, 14 May 2020 14:32:51 +0200 From: Daniel Vetter To: Daniel Stone Cc: Daniel Vetter , DRI Development , Intel Graphics Development , Pekka Paalanen , stable , Daniel Stone , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter Subject: Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets Message-ID: <20200514123251.GR206103@phenom.ffwll.local> References: <20200408162403.3616785-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, May 14, 2020 at 08:40:21AM +0100, Daniel Stone wrote: > On Thu, 14 May 2020 at 08:25, Daniel Vetter wrote: > > On Thu, May 14, 2020 at 9:18 AM Daniel Stone wrote: > > > On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > > I'd be very much in favour of putting the blocking down in the kernel > > > at least until the kernel can give us a clear indication to tell us > > > what's going on, and ideally which other resources need to be dragged > > > in, in a way which is distinguishable from your compositor having > > > broken synchronisation. > > > > We know, the patch already computes that ... So would be a matter of > > exporting that to userspace. We have a mask of all additional crtc > > that will get an event and will -EBUSY until that's done. > > Yep, but unless and until that happens, could we please get this in? > Given it would require uAPI changes, we'd need to modify all the > compositors to work with the old path (random EBUSY) and the new path > (predictable and obvious), so at least preserving the promise that > per-CRTC updates are really independent would be good. I haven't found the time to look at the intel-gfx-ci fail in igt nor really think about that. Nor care enough to just hammer this ignoring ci, since I didn't even get around to understand why the igt now fails If someone else takes this over, happy to see it land. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03015C433DF for ; Thu, 14 May 2020 12:32:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC685206DA for ; Thu, 14 May 2020 12:32:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YgWHkQTY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC685206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 046256EB2C; Thu, 14 May 2020 12:32:57 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B6886EB29 for ; Thu, 14 May 2020 12:32:55 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id f13so1755571wmc.5 for ; Thu, 14 May 2020 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=YgWHkQTYQPFppqYsLPN4O7w4lYivEAnsEzMA+LRaWDfv1qHjFZT7jJduso+EFh/hnh BmsjyF8UrLtntddw7ns7M8+fhWv+y4cDydxv3fKuQ73T16tDKeVw7qrfp+ced3x5ZpsD AkPmYBhTTcBPvfKZDxpbZ0iFajRNhq0rxkirk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=I8/hxI1Dk0myvuc9UVfm8V6ivzN8EwIH4FPo3tBM2vhGYNCpEIyOYX+k4Ws5eMIWoz THdBkADnN8SvqMBjSpugJMB1SJkfLWYG6rjvSB8Aqi0PYUFjgt6lwE6JHAu2fHBo/wWf Geb5z105tq9xWRvDOSMvDkeYCpkAoZJm0lC/j17piINIq/2Ob6G6mNBaeAK5yxHvdL9l WEPvwpUAnVXPHx8yHmv0DTZDv2yq4QNEF65789FLWf0v3F9ZkU9uvIUohp0sR5W1Gd9N D732C3dbMmwyl7+hH/i6jK3wNZ9TaDWCgsA7UJVCDSnaNJuWti4llqpfSeXq8UmyWmLh 6IHw== X-Gm-Message-State: AGi0PuZirQakHVkWsNjix8d28MTmAfitpLtLaPRw0n4Zhekd5brnr2ry 86b+9gNe+xY+up5VkspTj7ykPg== X-Google-Smtp-Source: APiQypLwlYFf18uBo+jfC26cvoH7AqKeY4MEhPzSMIyKaNwga5O97X2GrG0P30+6HD8/aszlGaAbDg== X-Received: by 2002:a1c:bbc5:: with SMTP id l188mr27784086wmf.163.1589459573864; Thu, 14 May 2020 05:32:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x23sm38645260wmj.6.2020.05.14.05.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 05:32:53 -0700 (PDT) Date: Thu, 14 May 2020 14:32:51 +0200 From: Daniel Vetter To: Daniel Stone Subject: Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets Message-ID: <20200514123251.GR206103@phenom.ffwll.local> References: <20200408162403.3616785-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Stone , Daniel Vetter , Intel Graphics Development , stable , DRI Development , Daniel Vetter , Pekka Paalanen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 14, 2020 at 08:40:21AM +0100, Daniel Stone wrote: > On Thu, 14 May 2020 at 08:25, Daniel Vetter wrote: > > On Thu, May 14, 2020 at 9:18 AM Daniel Stone wrote: > > > On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > > I'd be very much in favour of putting the blocking down in the kernel > > > at least until the kernel can give us a clear indication to tell us > > > what's going on, and ideally which other resources need to be dragged > > > in, in a way which is distinguishable from your compositor having > > > broken synchronisation. > > > > We know, the patch already computes that ... So would be a matter of > > exporting that to userspace. We have a mask of all additional crtc > > that will get an event and will -EBUSY until that's done. > > Yep, but unless and until that happens, could we please get this in? > Given it would require uAPI changes, we'd need to modify all the > compositors to work with the old path (random EBUSY) and the new path > (predictable and obvious), so at least preserving the promise that > per-CRTC updates are really independent would be good. I haven't found the time to look at the intel-gfx-ci fail in igt nor really think about that. Nor care enough to just hammer this ignoring ci, since I didn't even get around to understand why the igt now fails If someone else takes this over, happy to see it land. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2CEC433E1 for ; Thu, 14 May 2020 12:32:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA34D206DA for ; Thu, 14 May 2020 12:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YgWHkQTY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA34D206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B9D66EB29; Thu, 14 May 2020 12:32:56 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 412A66EB2B for ; Thu, 14 May 2020 12:32:55 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id h4so30162439wmb.4 for ; Thu, 14 May 2020 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=YgWHkQTYQPFppqYsLPN4O7w4lYivEAnsEzMA+LRaWDfv1qHjFZT7jJduso+EFh/hnh BmsjyF8UrLtntddw7ns7M8+fhWv+y4cDydxv3fKuQ73T16tDKeVw7qrfp+ced3x5ZpsD AkPmYBhTTcBPvfKZDxpbZ0iFajRNhq0rxkirk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hs0b6CimQtwFi7aqQ0x2t0EfYjjIMEZ9m/N7F6YQDAY=; b=IQLg4zcOzfRIgA4XpMW0G0RqcqJYx/Wb8FakAazpeLqlZVLPLRhs0qZqP1F7oGc2WY 1CoYGbuU8CnPkDydD505UtWVA+fWVkc8cX+We5E0Pdzf9vRDeWFSmiXNx1mntFCaqSS+ oCir0vSYayFxV5CxeZPWQg4lzOpauuDAosXwPw8zdoJ7Y6WplEF1KC3ONiJ4+SnMPE+R YbUN+I20aKxjGTMa/LPE2No8bzRaiNDMJf9s9ketL6gfPorY4DZvp4iEaWykOh0Q4v9e XTP07HHQdjn11lmOZ/egsR/9XHMIOj07/Xl965c0INCq60CtFF05cZPOG6Ogwb3bJqS3 zRww== X-Gm-Message-State: AGi0PubSMAvbMAnxjVFG+5mYeXQ20dRC+LPUzc1C7Suya+FugiGnLwyL B9rqZEMCOX2zM7q/kuQibCWQWQ== X-Google-Smtp-Source: APiQypLwlYFf18uBo+jfC26cvoH7AqKeY4MEhPzSMIyKaNwga5O97X2GrG0P30+6HD8/aszlGaAbDg== X-Received: by 2002:a1c:bbc5:: with SMTP id l188mr27784086wmf.163.1589459573864; Thu, 14 May 2020 05:32:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x23sm38645260wmj.6.2020.05.14.05.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 05:32:53 -0700 (PDT) Date: Thu, 14 May 2020 14:32:51 +0200 From: Daniel Vetter To: Daniel Stone Message-ID: <20200514123251.GR206103@phenom.ffwll.local> References: <20200408162403.3616785-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 Subject: Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Stone , Daniel Vetter , Intel Graphics Development , stable , DRI Development , Daniel Vetter , Pekka Paalanen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, May 14, 2020 at 08:40:21AM +0100, Daniel Stone wrote: > On Thu, 14 May 2020 at 08:25, Daniel Vetter wrote: > > On Thu, May 14, 2020 at 9:18 AM Daniel Stone wrote: > > > On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > > I'd be very much in favour of putting the blocking down in the kernel > > > at least until the kernel can give us a clear indication to tell us > > > what's going on, and ideally which other resources need to be dragged > > > in, in a way which is distinguishable from your compositor having > > > broken synchronisation. > > > > We know, the patch already computes that ... So would be a matter of > > exporting that to userspace. We have a mask of all additional crtc > > that will get an event and will -EBUSY until that's done. > > Yep, but unless and until that happens, could we please get this in? > Given it would require uAPI changes, we'd need to modify all the > compositors to work with the old path (random EBUSY) and the new path > (predictable and obvious), so at least preserving the promise that > per-CRTC updates are really independent would be good. I haven't found the time to look at the intel-gfx-ci fail in igt nor really think about that. Nor care enough to just hammer this ignoring ci, since I didn't even get around to understand why the igt now fails If someone else takes this over, happy to see it land. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx