All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: Deepak Kodihalli <dkodihal@linux.vnet.ibm.com>
Cc: Sunitha Harish <sunithaharish04@gmail.com>,
	dkodihal@in.ibm.com, suryakanth.sekar@linux.intel.com,
	openbmc <openbmc@lists.ozlabs.org>
Subject: Re: Storing host data on the BMC
Date: Thu, 14 May 2020 07:33:50 -0500	[thread overview]
Message-ID: <20200514123350.GB1166713@heinlein> (raw)
In-Reply-To: <10275d64-bebd-cb33-0a16-21299b7b1880@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2064 bytes --]

On Thu, May 14, 2020 at 09:13:47AM +0530, Deepak Kodihalli wrote:
> On 14/05/20 2:48 am, Patrick Williams wrote:
> > On Wed, May 13, 2020 at 08:37:32PM +0530, Sunitha Harish wrote:
 
> I think the current proposal from Surya enables this already. Do you 
> just mean the design doc should explicitly state this isn't restricted 
> to the "BIOS" firmware.

Yep.

> As far as Sunitha's question goes, my point is that not all host 
> firmware generated data is a BIOS attribute. For eg if the host tells me 
> about the presence of certain FRUs, or their functional states, I 
> wouldn't want to store those in the BIOS attributes backend, I'd rather 
> associates those with the existing D-Bus interfaces for the FRU 
> inventory. I think the same applies to the Origin property that has been 
> described - associate with the networking D-Bus backend.

I think we're in agreement here.  Data which is interesting to represent
on the BMC, for which we already have a defined-interface, use it.  For
data which isn't interesting the to BMC, use the generic BIOS attribute
table.

> > If you are wanting the data to be managed, utilizing existing DBus
> > interfaces we have around networking, doesn't phosphor-settingsd cover
> > that from an implementation perspective?
> 
> I don't think the 'Origin' property is a setting.

Well the name "settingsd" is somewhat arbitrary based on its original
definition.  I believe the current implementation can make a placeholder
instance of any dbus interface.

Having said that, one weakness with settingsd is that you can't easily
restrict property changes to data coming from the host.  Once you make a
settingsd object, anyone can make dbus calls to change properties on it.
If we want to be able to restrict that to specific interfaces, we might
want to look at a phosphor-inventory-manager like implementation which
has a special "backdoor" method to create / update the instances but
prevents modification through the normal property change interfaces.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-14 12:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 14:52 Storing host data on the BMC Sunitha Harish
2020-05-04 15:56 ` Deepak Kodihalli
2020-05-05  6:42   ` Sunitha Harish
2020-05-05  6:59     ` Deepak Kodihalli
2020-05-06  7:23       ` Sunitha Harish
2020-05-11  6:14         ` Sunitha Harish
2020-05-11 12:07           ` Patrick Williams
2020-05-11 16:05             ` Sunitha Harish
2020-05-13 15:07               ` Sunitha Harish
2020-05-13 15:27                 ` Deepak Kodihalli
2020-05-13 21:18                 ` Patrick Williams
2020-05-14  3:43                   ` Deepak Kodihalli
2020-05-14 12:33                     ` Patrick Williams [this message]
2020-05-18 11:53                       ` Sunitha Harish
2020-05-21  5:12                         ` Sunitha Harish
2020-05-21  5:16                           ` Deepak Kodihalli
2020-05-21 10:30                             ` Sunitha Harish
2020-05-22  3:59                             ` Sunitha Harish
2020-05-29 10:57                               ` Sunitha Harish
2020-05-29 11:03                                 ` Deepak Kodihalli
2020-05-29 11:26                                   ` Sunitha Harish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514123350.GB1166713@heinlein \
    --to=patrick@stwcx.xyz \
    --cc=dkodihal@in.ibm.com \
    --cc=dkodihal@linux.vnet.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=sunithaharish04@gmail.com \
    --cc=suryakanth.sekar@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.