All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/vblank: remove outdated and noisy output
@ 2020-05-13 20:10 ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-05-13 20:10 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel

The R-Car DU driver calls drm_vblank_init via some helper functions in
probe(). From what I checked, most drivers do this as well. I have a
config now where DU always stays in deferred_probe state because of a
missing dependency. This means that every time I rebind another driver
like MMC, the vblank init message is displayed again when the DU driver
is retried. Because the message doesn't really carry a useful
information, I suggest to simply drop it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/gpu/drm/drm_vblank.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index da7b0b0c1090..ce9bed24c2da 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs)
 		seqlock_init(&vblank->seqlock);
 	}
 
-	DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n");
-
 	return 0;
 
 err:
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] drm/vblank: remove outdated and noisy output
@ 2020-05-13 20:10 ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-05-13 20:10 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Thomas Zimmermann, David Airlie, linux-kernel, Wolfram Sang, dri-devel

The R-Car DU driver calls drm_vblank_init via some helper functions in
probe(). From what I checked, most drivers do this as well. I have a
config now where DU always stays in deferred_probe state because of a
missing dependency. This means that every time I rebind another driver
like MMC, the vblank init message is displayed again when the DU driver
is retried. Because the message doesn't really carry a useful
information, I suggest to simply drop it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/gpu/drm/drm_vblank.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index da7b0b0c1090..ce9bed24c2da 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs)
 		seqlock_init(&vblank->seqlock);
 	}
 
-	DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n");
-
 	return 0;
 
 err:
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vblank: remove outdated and noisy output
  2020-05-13 20:10 ` Wolfram Sang
@ 2020-05-14 12:35   ` Daniel Vetter
  -1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2020-05-14 12:35 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel

On Wed, May 13, 2020 at 10:10:16PM +0200, Wolfram Sang wrote:
> The R-Car DU driver calls drm_vblank_init via some helper functions in
> probe(). From what I checked, most drivers do this as well. I have a
> config now where DU always stays in deferred_probe state because of a
> missing dependency. This means that every time I rebind another driver
> like MMC, the vblank init message is displayed again when the DU driver
> is retried. Because the message doesn't really carry a useful
> information, I suggest to simply drop it.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Makes sense, queued up in drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/drm_vblank.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index da7b0b0c1090..ce9bed24c2da 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs)
>  		seqlock_init(&vblank->seqlock);
>  	}
>  
> -	DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n");
> -
>  	return 0;
>  
>  err:
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vblank: remove outdated and noisy output
@ 2020-05-14 12:35   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2020-05-14 12:35 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Thomas Zimmermann, David Airlie, linux-kernel, linux-renesas-soc,
	dri-devel

On Wed, May 13, 2020 at 10:10:16PM +0200, Wolfram Sang wrote:
> The R-Car DU driver calls drm_vblank_init via some helper functions in
> probe(). From what I checked, most drivers do this as well. I have a
> config now where DU always stays in deferred_probe state because of a
> missing dependency. This means that every time I rebind another driver
> like MMC, the vblank init message is displayed again when the DU driver
> is retried. Because the message doesn't really carry a useful
> information, I suggest to simply drop it.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Makes sense, queued up in drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/drm_vblank.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index da7b0b0c1090..ce9bed24c2da 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs)
>  		seqlock_init(&vblank->seqlock);
>  	}
>  
> -	DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n");
> -
>  	return 0;
>  
>  err:
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-15  6:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 20:10 [PATCH] drm/vblank: remove outdated and noisy output Wolfram Sang
2020-05-13 20:10 ` Wolfram Sang
2020-05-14 12:35 ` Daniel Vetter
2020-05-14 12:35   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.