From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Eric Whitney <enwlinux@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: translate a few more map flags to strings in tracepoints
Date: Thu, 14 May 2020 10:43:19 -0400 [thread overview]
Message-ID: <20200514144319.GR1596452@mit.edu> (raw)
In-Reply-To: <20200422161413.GF20756@quack2.suse.cz>
On Wed, Apr 22, 2020 at 06:14:13PM +0200, Jan Kara wrote:
> On Wed 15-04-20 16:31:40, Eric Whitney wrote:
> > As new ext4_map_blocks() flags have been added, not all have gotten flag
> > bit to string translations to make tracepoint output more readable.
> > Fix that, and go one step further by adding a translation for the
> > EXT4_EX_NOCACHE flag as well. The EXT4_EX_FORCE_CACHE flag can never
> > be set in a tracepoint in the current code, so there's no need to
> > bother with a translation for it right now.
> >
> > Signed-off-by: Eric Whitney <enwlinux@gmail.com>
>
> Looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-05-14 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 20:31 [PATCH 0/2] remove EXT4_GET_BLOCKS_KEEP_SIZE flag, etc Eric Whitney
2020-04-15 20:31 ` [PATCH 1/2] ext4: remove EXT4_GET_BLOCKS_KEEP_SIZE flag Eric Whitney
2020-04-22 16:12 ` Jan Kara
2020-05-14 14:43 ` Theodore Y. Ts'o
2020-04-15 20:31 ` [PATCH 2/2] ext4: translate a few more map flags to strings in tracepoints Eric Whitney
2020-04-22 16:14 ` Jan Kara
2020-05-14 14:43 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514144319.GR1596452@mit.edu \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.