From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: michael.srba@seznam.cz
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: msm8916-samsung-a3u: add nodes for display panel
Date: Thu, 14 May 2020 10:23:26 -0700 [thread overview]
Message-ID: <20200514172326.GC279327@builder.lan> (raw)
In-Reply-To: <20200514170129.10902-1-michael.srba@seznam.cz>
On Thu 14 May 10:01 PDT 2020, michael.srba@seznam.cz wrote:
> From: Michael Srba <michael.srba@seznam.cz>
>
> This patch wires up display support on Samsung Galaxy A3 2015.
>
> Signed-off-by: Michael Srba <michael.srba@seznam.cz>
>
> ---
> .../qcom/msm8916-samsung-a2015-common.dtsi | 44 +++++++++++++++
> .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 54 +++++++++++++++++++
> 2 files changed, 98 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> index af812f76e8be..2a64aa269f52 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> @@ -72,6 +72,24 @@ phy {
> };
> };
>
> + mdss@1a00000 {
> + dsi@1a98000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vdda-supply = <&pm8916_l2>;
> + vddio-supply = <&pm8916_l6>;
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&mdss_default>;
> + pinctrl-1 = <&mdss_sleep>;
> + };
> +
> + dsi-phy@1a98300 {
> + vddio-supply = <&pm8916_l6>;
> + };
> + };
> +
> wcnss@a21b000 {
> status = "okay";
> };
> @@ -172,6 +190,32 @@ pinconf {
> bias-disable;
> };
> };
> +
> + pmx-mdss {
> + mdss_default: mdss-default {
> + pinmux {
> + function = "gpio";
> + pins = "gpio25";
> + };
> + pinconf {
> + pins = "gpio25";
> + drive-strength = <8>;
> + bias-disable;
> + };
> + };
Fyi, when you have a state with a single set of properties you don't
need the pinmux/pinconf level here, you can directly do:
mdss_default: mdss-default {
pins = "gpio25";
function = "gpio";
drive-strength = <8>;
bias-disable;
};
But this looks good, applied towards v5.8.
Regards,
Bjorn
prev parent reply other threads:[~2020-05-14 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 17:01 [PATCH] arm64: dts: qcom: msm8916-samsung-a3u: add nodes for display panel michael.srba
2020-05-14 17:23 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514172326.GC279327@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.srba@seznam.cz \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.