All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: qemu-devel@nongnu.org
Cc: aleksandar.rikalo@rt-rk.com,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments
Date: Thu, 14 May 2020 21:20:47 +0200	[thread overview]
Message-ID: <20200514192047.5297-18-aleksandar.qemu.devel@gmail.com> (raw)
In-Reply-To: <20200514192047.5297-1-aleksandar.qemu.devel@gmail.com>

The checkpatch complain about "#ifdef 0". Convert corresponding
dead code to comments. In future, these cases could be converted
to some no-nonsense logging/tracing.

Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
CC: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/mips/mips_malta.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index e4c4de1b4e..f91fa34b06 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -427,10 +427,12 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr addr,
         break;
 
     default:
-#if 0
-        printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
-               addr);
-#endif
+/*
+ * Possible logging:
+ *
+ *        printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
+ *               addr);
+ */
         break;
     }
     return val;
@@ -515,10 +517,12 @@ static void malta_fpga_write(void *opaque, hwaddr addr,
         break;
 
     default:
-#if 0
-        printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
-               addr);
-#endif
+/*
+ * Possible logging:
+ *
+ *        printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
+ *               addr);
+ */
         break;
     }
 }
-- 
2.20.1



  parent reply	other threads:[~2020-05-14 19:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 19:20 [PATCH v2 00/17] target/mips: FPU and other cleanups and improvements Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 01/17] target/mips: fpu: Demacro ADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 02/17] target/mips: fpu: Demacro SUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 03/17] target/mips: fpu: Demacro MUL.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 04/17] target/mips: fpu: Demacro DIV.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 05/17] target/mips: fpu: Remove now unused macro FLOAT_BINOP Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 06/17] target/mips: fpu: Demacro MADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 07/17] target/mips: fpu: Demacro MSUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 08/17] target/mips: fpu: Demacro NMADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 09/17] target/mips: fpu: Demacro NMSUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 10/17] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 11/17] target/mips: fpu: Demacro CLASS.<D|S> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 12/17] target/mips: fpu: Remove now unused FLOAT_CLASS macro Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 13/17] target/mips: fpu: Demacro RINT.<D|S> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 14/17] target/mips: fpu: Remove now unused FLOAT_RINT macro Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 15/17] target/mips: fpu: Name better paired-single variables Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 16/17] target/mips: fpu: Refactor conversion from ieee to mips exception flags Aleksandar Markovic
2020-05-14 19:20 ` Aleksandar Markovic [this message]
2020-05-15  7:53   ` [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments Markus Armbruster
2020-05-15 11:05     ` Aleksandar Markovic
2020-05-15 11:12       ` Peter Maydell
2020-05-15 11:19         ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514192047.5297-18-aleksandar.qemu.devel@gmail.com \
    --to=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.