All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Matthew Auld <matthew.auld@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/params: fix i915.fake_lmem_start module param sysfs permissions
Date: Thu, 14 May 2020 15:42:56 -0700	[thread overview]
Message-ID: <20200514224256.GB2129902@intel.com> (raw)
In-Reply-To: <20200514154006.4761-2-jani.nikula@intel.com>

On Thu, May 14, 2020 at 06:40:04PM +0300, Jani Nikula wrote:
> fake_lmem_start does not need to be mutable via module param sysfs. It's
> only used during driver probe.
> 
> Fixes: 1629224324b6 ("drm/i915/lmem: add the fake lmem region")
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index add00ec1f787..a3dde770226d 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -173,7 +173,7 @@ i915_param_named(enable_gvt, bool, 0400,
>  #endif
>  
>  #if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM)
> -i915_param_named_unsafe(fake_lmem_start, ulong, 0600,
> +i915_param_named_unsafe(fake_lmem_start, ulong, 0400,
>  	"Fake LMEM start offset (default: 0)");
>  #endif
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-05-14 22:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 15:40 [Intel-gfx] [PATCH 1/4] drm/i915/params: don't expose inject_probe_failure in debugfs Jani Nikula
2020-05-14 15:40 ` [Intel-gfx] [PATCH 2/4] drm/i915/params: fix i915.fake_lmem_start module param sysfs permissions Jani Nikula
2020-05-14 22:42   ` Rodrigo Vivi [this message]
2020-05-14 15:40 ` [Intel-gfx] [PATCH 3/4] drm/i915/params: prevent changing module params runtime Jani Nikula
2020-05-14 19:16   ` Juha-Pekka Heikkila
2020-05-14 15:40 ` [Intel-gfx] [PATCH 4/4] drm/i915/params: switch to device specific parameters Jani Nikula
2020-05-14 22:44   ` Rodrigo Vivi
2020-05-14 19:16 ` [Intel-gfx] [PATCH 1/4] drm/i915/params: don't expose inject_probe_failure in debugfs Juha-Pekka Heikkila
2020-05-15 14:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
2020-05-15 14:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-05-18 14:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/params: don't expose inject_probe_failure in debugfs (rev2) Patchwork
2020-05-18 14:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514224256.GB2129902@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.