From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jZRKL-0006N9-Ox for mharc-grub-devel@gnu.org; Thu, 14 May 2020 23:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZRKK-0006Lp-DD for grub-devel@gnu.org; Thu, 14 May 2020 23:48:00 -0400 Received: from mailout03.mx.bawue.net ([193.7.176.64]:51238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZRKJ-0000eZ-NB for grub-devel@gnu.org; Thu, 14 May 2020 23:48:00 -0400 Received: from infty.fritz.box (p5b17584c.dip0.t-ipconnect.de [91.23.88.76]) (Authenticated sender: pdim@bawue.de) by smtp.bawue.net (Postfix) with ESMTPSA id BADF020942; Fri, 15 May 2020 05:47:52 +0200 (CEST) From: Hans Ulrich Niedermann To: grub-devel@gnu.org Cc: Hans Ulrich Niedermann Subject: [MULTIBOOT2 SPEC PATCH v4 20/27] multiboot2: mips build wants __start symbol Date: Fri, 15 May 2020 05:43:43 +0200 Message-Id: <20200515034349.133092-21-hun@n-dimensional.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200515034349.133092-1-hun@n-dimensional.de> References: <20200515034349.133092-1-hun@n-dimensional.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanner: SAV Dynamic Interface 2.6.0, Engine: 3.77.1, SAV: 5.75 (A93B943C) on relay01.mx.bawue.net using milter-sssp 0.1.0 X-Virus-Scan: Found to be clean. Received-SPF: pass client-ip=193.7.176.64; envelope-from=hun@n-dimensional.de; helo=mailout03.mx.bawue.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/14 23:46:17 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 03:48:00 -0000 When building the example kernel for mips, there is a warning about __start being undefined and some default address being chosen as start address. As this does not inspire confidence, we add a __start symbol at the same place where start and _start are already defined. Now the mips build builds nicely. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_mips.S b/doc/boot_mips.S index b59e3fd6a..a6881528f 100644 --- a/doc/boot_mips.S +++ b/doc/boot_mips.S @@ -31,9 +31,10 @@ .set noreorder .set nomacro - .globl start, _start + .globl start, _start, __start start: _start: +__start: b multiboot_entry nop -- 2.26.2