From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E86C433E0 for ; Fri, 15 May 2020 07:51:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5B5F205CB for ; Fri, 15 May 2020 07:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fRA0I55P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgEOHvV (ORCPT ); Fri, 15 May 2020 03:51:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbgEOHvU (ORCPT ); Fri, 15 May 2020 03:51:20 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36CBCC061A0C for ; Fri, 15 May 2020 00:51:20 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k13so249689wrx.3 for ; Fri, 15 May 2020 00:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/hbVzyFGS1UmGEvVIj57oHLIBKMXLaE4t9FY/qY/HWM=; b=fRA0I55PCsxOBnUcYqMa2WZtI05hG6KwLouBvGq4PEw6YZmmrCap11xAqL4f+TFlci 4jBAiBJtif+AK0o1ZKEX4SCHE9oBCddNuun2WN7VlS9TTt0GqBScoJN2u4fbLCehoFo5 iDVxWOz/sqyy1Rn16DU485TpB3VlSwa6x/2svSQ+Ultn8YFz2a6IWrWdrKrGVlrkIuST 9Cj3Vw9l6AOb44eeCondkvBsalwoY3Ek2ZvWaE6Kxc2ndAiYvOdbAm+a1RXTlLWFGauh 9jkEokfw7pmXwygCvykKFjckA5tO6OGcQbPcduCGkH+SaEGR2LhBX5zl0pAa3tcQyQyx JauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/hbVzyFGS1UmGEvVIj57oHLIBKMXLaE4t9FY/qY/HWM=; b=TGN7e09a6EqrYH7eB7u0dubrhtJt5e20FFSkc5MLNBv+VsRHvoiAfZShRBnDye8tyP TU6GX2WH8lcoFMvnLkxFGQPNm50jncHyKeN8szHLL3EL7+Jrv54PEOvyVa+sskItRer9 qHA2v/ZpnzA1nN9Uu+6xvI1XpOxLrR1487dFUNwlWX+uzIu3+Er6U6IVPoQT4ZfOPt1t Xv8gU6ss9dB/gRJHmcWsSLeo8fThcwNGgvqK0trrlKWWrfS/r8vvnc+yCjITRQnQsQIt +11ELOUlFeolIGNjFgA2BM9IfH4cTdQwbQ5fQ+DvorZrKdO8xxY7sP14buzmVrne0Ul/ IyfA== X-Gm-Message-State: AOAM533k6O+nY9nIF6xofmdRfPOjD9/DihTat4eYOoq7iNhuuZcnIUpG Huyc0HyDo0xZGrFapQ943g4Rwg== X-Google-Smtp-Source: ABdhPJzzgIqRYccdOCLaRm5r/FwnYo3XCP3xReZ1daSwHywCpusrhkeHpNhGtbsM39QclzulKTXiaQ== X-Received: by 2002:adf:fa0b:: with SMTP id m11mr2706089wrr.417.1589529078722; Fri, 15 May 2020 00:51:18 -0700 (PDT) Received: from lmecxl0524.lme.st.com (2a01cb058702ff00bc4b798f4f30d41e.ipv6.abo.wanadoo.fr. [2a01:cb05:8702:ff00:bc4b:798f:4f30:d41e]) by smtp.gmail.com with ESMTPSA id m3sm2246686wrn.96.2020.05.15.00.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 00:51:18 -0700 (PDT) From: Etienne Carriere To: sudeep.holla@arm.com Cc: arnd@arndb.de, catalin.marinas@arm.com, harb@amperecomputing.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, steven.price@arm.com, will@kernel.org Subject: RE: [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Date: Fri, 15 May 2020 09:50:32 +0200 Message-Id: <20200515075032.5325-1-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200506164411.3284-1-sudeep.holla@arm.com> References: <20200506164411.3284-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Sudeep Holla > > Hi, > > This patch series adds support for SMCCCv1.2 ARCH_SOC_ID. > This doesn't add other changes added in SMCCC v1.2 yet. They will > follow these soon along with its first user SPCI/PSA-FF. > > This is tested using upstream TF-A + the patch[2] fixing the original > implementation there. > > > v1[0]->v2[1]: > - Incorporated comments from Steven Price in patch 5/5 > - Fixed build for CONFIG_PSCI_FW=n on some arm32 platforms > - Added Steven Price's review tags > > v2[1]->v3: > - Incorporated additional comments from Steven Price in patch 5/5 > and added his review tags > - Refactored SMCCC code from PSCI and moved it under > drivers/firmware/smccc/smccc.c > - Also moved soc_id.c under drivers/firmware/smccc > > Regards, > Sudeep Hello Sudeep, In case it helps. I have successfully tested the 7 patches series on some platforms, playing a bit with few configurations. Qemu emulator for arm64/cortex-a57 with TF-A (v2.x) as secure firmware. Qemu emulator for arm/cortex-a15. OP-TEE (v3.x) as secure firmware. A stm32mp15 device (arm/cortex-a7), tested both TF-A (v2.x) and OP-TEE (3.7.0, 3.9.0-rc) as runtime secure firmware. Helper functions arm_smccc_1_1_get_conduit()/arm_smccc_1_1_invoke() works as expected AFAICT. No regression seen with older secure firmwares. For the patches 1 to 6, as I poorly tested [v3,7/7] soc ids, based on tag next-20200505 [1]: Tested-by: Etienne Carriere Reviewed-by: Etienne Carriere For [v3,7/7] firmware: smccc: Add ARCH_SOC_ID support Acked-by: Etienne Carriere [1] 7def1ef0f72c ("Add linux-next specific files for 20200505") Regards, Etienne From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63545C433E0 for ; Fri, 15 May 2020 07:51:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33E16205CB for ; Fri, 15 May 2020 07:51:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NDbyJkdG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fRA0I55P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33E16205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ohe7PZsJ4A1ZY7GsQ7pEvONo2UY94MKnUaTyxazcSHo=; b=NDbyJkdGTjGZ15WslW084zaHmh y18tOUSuCYC9VNRshSG8yYtpqMqLHvN4jiBduwzNEwWPoxrEf6XmXY4cdnHGV23y0ZSHZK/KSFpU+ VFqkIK7EAYTItyM1avrBORWXRbzYmhBMjVYaYaQaoYYxqXHoawdJ4WIyxtee/LSvbi9t2uzXbxIuv IaPN12A0xQIkiJdkAHXoQzKN/b7XzLwkqIbk+erSvYb8tZndzS6gSV7d5tR9iOsV1e0DRmga3RQlz mNmPdo/e7K91rChKXefU0c1vpDHTSgpRF0+4jh7CWQ1v5UyanyH9hDdGTMYmNQBOqYLsqHrihIio4 RLt+/x7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZV7t-0003en-NC; Fri, 15 May 2020 07:51:25 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZV7o-0003dp-Bm for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 07:51:24 +0000 Received: by mail-wr1-x443.google.com with SMTP id l11so2410925wru.0 for ; Fri, 15 May 2020 00:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/hbVzyFGS1UmGEvVIj57oHLIBKMXLaE4t9FY/qY/HWM=; b=fRA0I55PCsxOBnUcYqMa2WZtI05hG6KwLouBvGq4PEw6YZmmrCap11xAqL4f+TFlci 4jBAiBJtif+AK0o1ZKEX4SCHE9oBCddNuun2WN7VlS9TTt0GqBScoJN2u4fbLCehoFo5 iDVxWOz/sqyy1Rn16DU485TpB3VlSwa6x/2svSQ+Ultn8YFz2a6IWrWdrKrGVlrkIuST 9Cj3Vw9l6AOb44eeCondkvBsalwoY3Ek2ZvWaE6Kxc2ndAiYvOdbAm+a1RXTlLWFGauh 9jkEokfw7pmXwygCvykKFjckA5tO6OGcQbPcduCGkH+SaEGR2LhBX5zl0pAa3tcQyQyx JauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/hbVzyFGS1UmGEvVIj57oHLIBKMXLaE4t9FY/qY/HWM=; b=NW6YgZHGw3/jbf3WaMoDDln7kdE7DBRbLIhwDpLf4IEL1FJ4uKpTUQN9KBUZNaZnRh f4bv4UdREoqQWYvSa55C+RJAyywO/bNPsiFqgxYGtS6UmZZCe4qYSOHsbv8zK/Da/axg 91Jx6SVhxWMZXDREsWvmKA+HOXhUcBdWc/n6m+rc1wcJDT1wEDR+vTluW3BFcF4zmGGi sI6otS+/n8EOlbpCHk3eBhjuHwkPyQu80voackNZtDk02J8vRX9m4RUW3t2m6i0V/+MA W6Pol6ZjJZx8Seq2jcTn+dwyrBfeyim6sSIPYR0t+VP1fGBYU+R5g/myq+ftY2r3+jlq sN5Q== X-Gm-Message-State: AOAM532YBSL+v7Q23uVvt7jaQkuD8ad04d+S4zaUEkfL66KVmjwbw/TL xwRqeHwRGmETofB+QGfmRDnrbQ== X-Google-Smtp-Source: ABdhPJzzgIqRYccdOCLaRm5r/FwnYo3XCP3xReZ1daSwHywCpusrhkeHpNhGtbsM39QclzulKTXiaQ== X-Received: by 2002:adf:fa0b:: with SMTP id m11mr2706089wrr.417.1589529078722; Fri, 15 May 2020 00:51:18 -0700 (PDT) Received: from lmecxl0524.lme.st.com (2a01cb058702ff00bc4b798f4f30d41e.ipv6.abo.wanadoo.fr. [2a01:cb05:8702:ff00:bc4b:798f:4f30:d41e]) by smtp.gmail.com with ESMTPSA id m3sm2246686wrn.96.2020.05.15.00.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 00:51:18 -0700 (PDT) From: Etienne Carriere To: sudeep.holla@arm.com Subject: RE: [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Date: Fri, 15 May 2020 09:50:32 +0200 Message-Id: <20200515075032.5325-1-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200506164411.3284-1-sudeep.holla@arm.com> References: <20200506164411.3284-1-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_005120_439133_862CFDC6 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, arnd@arndb.de, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, steven.price@arm.com, harb@amperecomputing.com, will@kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Sudeep Holla > > Hi, > > This patch series adds support for SMCCCv1.2 ARCH_SOC_ID. > This doesn't add other changes added in SMCCC v1.2 yet. They will > follow these soon along with its first user SPCI/PSA-FF. > > This is tested using upstream TF-A + the patch[2] fixing the original > implementation there. > > > v1[0]->v2[1]: > - Incorporated comments from Steven Price in patch 5/5 > - Fixed build for CONFIG_PSCI_FW=n on some arm32 platforms > - Added Steven Price's review tags > > v2[1]->v3: > - Incorporated additional comments from Steven Price in patch 5/5 > and added his review tags > - Refactored SMCCC code from PSCI and moved it under > drivers/firmware/smccc/smccc.c > - Also moved soc_id.c under drivers/firmware/smccc > > Regards, > Sudeep Hello Sudeep, In case it helps. I have successfully tested the 7 patches series on some platforms, playing a bit with few configurations. Qemu emulator for arm64/cortex-a57 with TF-A (v2.x) as secure firmware. Qemu emulator for arm/cortex-a15. OP-TEE (v3.x) as secure firmware. A stm32mp15 device (arm/cortex-a7), tested both TF-A (v2.x) and OP-TEE (3.7.0, 3.9.0-rc) as runtime secure firmware. Helper functions arm_smccc_1_1_get_conduit()/arm_smccc_1_1_invoke() works as expected AFAICT. No regression seen with older secure firmwares. For the patches 1 to 6, as I poorly tested [v3,7/7] soc ids, based on tag next-20200505 [1]: Tested-by: Etienne Carriere Reviewed-by: Etienne Carriere For [v3,7/7] firmware: smccc: Add ARCH_SOC_ID support Acked-by: Etienne Carriere [1] 7def1ef0f72c ("Add linux-next specific files for 20200505") Regards, Etienne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel