On Fri, 15 May 2020 03:16:18 +0000
"Zhang, Chen" <chen.zhang@intel.com> wrote:

> Hi Hailiang/Dave.
> 
> I found a urgent problem in current upstream code, COLO will stuck on secondary checkpoint and later.
> The guest will stuck by this issue.
> I have bisect upstream code, this issue caused by Hailiang's optimize patch:

Hmm, I'm on v5.0.0 (where that commit is in) and I don't have this issue in my testing.

Regards,
Lukas Straub

> From 0393031a16735835a441b6d6e0495a1bd14adb90 Mon Sep 17 00:00:00 2001
> From: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Date: Mon, 24 Feb 2020 14:54:10 +0800
> Subject: [PATCH] COLO: Optimize memory back-up process
> 
> This patch will reduce the downtime of VM for the initial process,
> Previously, we copied all these memory in preparing stage of COLO
> while we need to stop VM, which is a time-consuming process.
> Here we optimize it by a trick, back-up every page while in migration
> process while COLO is enabled, though it affects the speed of the
> migration, but it obviously reduce the downtime of back-up all SVM'S
> memory in COLO preparing stage.
> 
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Message-Id: <20200224065414.36524-5-zhang.zhanghailiang@huawei.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>   minor typo fixes
> 
> Hailiang, do you have time to look into it?
> 
> ...