From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 4/6] x86/mem-paging: add minimal lock order enforcement to p2m_mem_paging_prep()
Date: Fri, 15 May 2020 12:21:49 +0200 [thread overview]
Message-ID: <20200515102149.GS54375@Air-de-Roger> (raw)
In-Reply-To: <8b9fd4ce-177f-6f57-8d24-8468fea0c299@suse.com>
On Fri, May 15, 2020 at 11:46:23AM +0200, Jan Beulich wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
>
> On 14.05.2020 18:25, Roger Pau Monné wrote:
> > On Thu, Apr 23, 2020 at 10:38:44AM +0200, Jan Beulich wrote:
> >> While full checking is impossible (as the lock is being acquired/
> >> released down the call tree), perform at least a lock level check.
> >
> > I'm slightly confused, doesn't alloc_domheap_page already have it's
> > own lock order checking?
>
> I don't see how it would, as it doesn't (and can't legitimately)
> include arch/x86/mm/mm-locks.h. Also maybe this comment in the
> header clarifies it:
>
> /* Page alloc lock (per-domain)
> *
> * This is an external lock, not represented by an mm_lock_t. However,
> * pod code uses it in conjunction with the p2m lock, and expecting
> * the ordering which we enforce here.
> * The lock is not recursive. */
Thanks.
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
next prev parent reply other threads:[~2020-05-15 10:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 8:34 [PATCH v2 0/6] x86/mem-paging: misc cleanup Jan Beulich
2020-04-23 8:37 ` [PATCH v2 1/6] x86/mem-paging: fold p2m_mem_paging_prep()'s main if()-s Jan Beulich
2020-05-14 15:45 ` Roger Pau Monné
2020-05-14 15:51 ` Jan Beulich
2020-05-15 12:02 ` Andrew Cooper
2020-04-23 8:37 ` [PATCH v2 2/6] x86/mem-paging: correct p2m_mem_paging_prep()'s error handling Jan Beulich
2020-05-14 15:57 ` Roger Pau Monné
2020-05-15 14:40 ` Andrew Cooper
2020-05-15 15:15 ` Jan Beulich
2020-05-15 20:02 ` Andrew Cooper
2020-04-23 8:38 ` [PATCH v2 3/6] x86/mem-paging: use guest handle for XENMEM_paging_op_prep Jan Beulich
2020-05-14 16:13 ` Roger Pau Monné
2020-05-15 14:14 ` Ping: " Jan Beulich
2020-05-15 14:46 ` Andrew Cooper
2020-05-15 16:40 ` Wei Liu
2020-04-23 8:38 ` [PATCH v2 4/6] x86/mem-paging: add minimal lock order enforcement to p2m_mem_paging_prep() Jan Beulich
2020-05-14 16:25 ` Roger Pau Monné
2020-05-15 9:46 ` Jan Beulich
2020-05-15 10:21 ` Roger Pau Monné [this message]
2020-04-23 8:39 ` [PATCH v2 5/6] x86/mem-paging: move code to its dedicated source file Jan Beulich
2020-05-14 16:29 ` Roger Pau Monné
2020-05-15 15:45 ` Andrew Cooper
2020-04-23 8:39 ` [PATCH v2 6/6] x86/mem-paging: consistently use gfn_t Jan Beulich
2020-05-14 16:36 ` Roger Pau Monné
2020-05-15 15:49 ` Andrew Cooper
2020-05-15 15:52 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515102149.GS54375@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.