From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B03C433E0 for ; Fri, 15 May 2020 11:37:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E29B2065C for ; Fri, 15 May 2020 11:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726122AbgEOLhf (ORCPT ); Fri, 15 May 2020 07:37:35 -0400 Received: from foss.arm.com ([217.140.110.172]:54356 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726003AbgEOLhf (ORCPT ); Fri, 15 May 2020 07:37:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BEC50D6E; Fri, 15 May 2020 04:37:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.24.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97EF83F305; Fri, 15 May 2020 04:37:32 -0700 (PDT) Date: Fri, 15 May 2020 12:37:27 +0100 From: Mark Rutland To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Steven Price , linux-kernel@vger.kernel.org, Arnd Bergmann , harb@amperecomputing.com Subject: Re: [PATCH v3 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Message-ID: <20200515113727.GA67718@C02TD0UTHF1T.local> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506164411.3284-2-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 05:44:05PM +0100, Sudeep Holla wrote: > SMCCC v1.0 lacked discoverability of version and features. To accelerate > adoption of few mitigations and protect systems more rapidly from various > vulnerability, PSCI v1.0 was updated to add SMCCC discovery mechanism > though the PSCI firmware implementation of PSCI_FEATURES(SMCCC_VERSION) > which returns success on firmware compliant to SMCCC v1.1 and above. > > This inturn makes SMCCC v1.1 and above dependent on ARM_PSCI_FW for > backward compatibility. Let us introduce a new hidden config for the > same to build more features on top of SMCCC v1.1 and above. > > While at it, also sort alphabetically the psci entry. > > Signed-off-by: Sudeep Holla Acked-by: Mark Rutland Thanks, Mark. > --- > drivers/firmware/Kconfig | 6 ++---- > drivers/firmware/smccc/Kconfig | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+), 4 deletions(-) > create mode 100644 drivers/firmware/smccc/Kconfig > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 8007d4aa76dc..4843e94713a4 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -295,15 +295,13 @@ config TURRIS_MOX_RWTM > other manufacturing data and also utilize the Entropy Bit Generator > for hardware random number generation. > > -config HAVE_ARM_SMCCC > - bool > - > -source "drivers/firmware/psci/Kconfig" > source "drivers/firmware/broadcom/Kconfig" > source "drivers/firmware/google/Kconfig" > source "drivers/firmware/efi/Kconfig" > source "drivers/firmware/imx/Kconfig" > source "drivers/firmware/meson/Kconfig" > +source "drivers/firmware/psci/Kconfig" > +source "drivers/firmware/smccc/Kconfig" > source "drivers/firmware/tegra/Kconfig" > source "drivers/firmware/xilinx/Kconfig" > > diff --git a/drivers/firmware/smccc/Kconfig b/drivers/firmware/smccc/Kconfig > new file mode 100644 > index 000000000000..d93f1ab52cb2 > --- /dev/null > +++ b/drivers/firmware/smccc/Kconfig > @@ -0,0 +1,17 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config HAVE_ARM_SMCCC > + bool > + help > + Include support for the Secure Monitor Call (SMC) and Hypervisor > + Call (HVC) instructions on Armv7 and above architectures. > + > +config HAVE_ARM_SMCCC_DISCOVERY > + bool > + depends on ARM_PSCI_FW > + default y > + help > + SMCCC v1.0 lacked discoverability and hence PSCI v1.0 was updated > + to add SMCCC discovery mechanism though the PSCI firmware > + implementation of PSCI_FEATURES(SMCCC_VERSION) which returns > + success on firmware compliant to SMCCC v1.1 and above. > + > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3FDC433E0 for ; Fri, 15 May 2020 11:37:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C2B2065C for ; Fri, 15 May 2020 11:37:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ud50ZVvZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C2B2065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DVEJC6alIV/oD38N/HAdQBM7KBxMnzVsw0cD3SJ9Ugg=; b=Ud50ZVvZcYvEfg hZnz3pub3r4dOTEq/Oi3IGDFCspqgQ8Lucvk7jCbOefwSPvVCOCUGf7E9tnnKF9f9zC3P8dTeCkLQ 3GzAwPnnxcpHmiD9e20wbJ77zgV/5gDZxDF0C5ApbsAIbL7hRFhYykXOOOvueycOfRkPhUKNGOOkL +rea26sYVxTNsngwRHTY76sKn2sF8XHnCCGZrQWR6rs3Jn+GIPBml3B9RmtHzB1dJGzuOdzI4xHeH Jx73iU6geCLtMz4BxJFiUG5XcRs3uxnu9+kWyA/7HW2shpF1x0vysEJZQjUl09vLbSehX7mKudfkG EnH0/Ub4sg3EllzcKMGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYeq-00049I-0f; Fri, 15 May 2020 11:37:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYem-00048Y-QT for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 11:37:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BEC50D6E; Fri, 15 May 2020 04:37:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.24.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97EF83F305; Fri, 15 May 2020 04:37:32 -0700 (PDT) Date: Fri, 15 May 2020 12:37:27 +0100 From: Mark Rutland To: Sudeep Holla Subject: Re: [PATCH v3 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Message-ID: <20200515113727.GA67718@C02TD0UTHF1T.local> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506164411.3284-2-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_043736_902876_B348D6C7 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Arnd Bergmann , Catalin Marinas , linux-kernel@vger.kernel.org, Steven Price , harb@amperecomputing.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 06, 2020 at 05:44:05PM +0100, Sudeep Holla wrote: > SMCCC v1.0 lacked discoverability of version and features. To accelerate > adoption of few mitigations and protect systems more rapidly from various > vulnerability, PSCI v1.0 was updated to add SMCCC discovery mechanism > though the PSCI firmware implementation of PSCI_FEATURES(SMCCC_VERSION) > which returns success on firmware compliant to SMCCC v1.1 and above. > > This inturn makes SMCCC v1.1 and above dependent on ARM_PSCI_FW for > backward compatibility. Let us introduce a new hidden config for the > same to build more features on top of SMCCC v1.1 and above. > > While at it, also sort alphabetically the psci entry. > > Signed-off-by: Sudeep Holla Acked-by: Mark Rutland Thanks, Mark. > --- > drivers/firmware/Kconfig | 6 ++---- > drivers/firmware/smccc/Kconfig | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+), 4 deletions(-) > create mode 100644 drivers/firmware/smccc/Kconfig > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 8007d4aa76dc..4843e94713a4 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -295,15 +295,13 @@ config TURRIS_MOX_RWTM > other manufacturing data and also utilize the Entropy Bit Generator > for hardware random number generation. > > -config HAVE_ARM_SMCCC > - bool > - > -source "drivers/firmware/psci/Kconfig" > source "drivers/firmware/broadcom/Kconfig" > source "drivers/firmware/google/Kconfig" > source "drivers/firmware/efi/Kconfig" > source "drivers/firmware/imx/Kconfig" > source "drivers/firmware/meson/Kconfig" > +source "drivers/firmware/psci/Kconfig" > +source "drivers/firmware/smccc/Kconfig" > source "drivers/firmware/tegra/Kconfig" > source "drivers/firmware/xilinx/Kconfig" > > diff --git a/drivers/firmware/smccc/Kconfig b/drivers/firmware/smccc/Kconfig > new file mode 100644 > index 000000000000..d93f1ab52cb2 > --- /dev/null > +++ b/drivers/firmware/smccc/Kconfig > @@ -0,0 +1,17 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config HAVE_ARM_SMCCC > + bool > + help > + Include support for the Secure Monitor Call (SMC) and Hypervisor > + Call (HVC) instructions on Armv7 and above architectures. > + > +config HAVE_ARM_SMCCC_DISCOVERY > + bool > + depends on ARM_PSCI_FW > + default y > + help > + SMCCC v1.0 lacked discoverability and hence PSCI v1.0 was updated > + to add SMCCC discovery mechanism though the PSCI firmware > + implementation of PSCI_FEATURES(SMCCC_VERSION) which returns > + success on firmware compliant to SMCCC v1.1 and above. > + > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel